From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3D733D8080A for ; Wed, 15 Nov 2023 16:21:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WDlisrk9sPuq6aQLcEnh/MtCas8hFAv5OMtL3nCWglg=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1700065306; v=1; b=VB4EVRH7oHtrfPf0HK252TnyYjCf0DrIbs+IxBYDnz85sQ/wemwxWKS/SYlsrFQqvhgWXkvb c08q3+lfaSej4oDZYznAhBXR6el/URkA3t3DhGg7yj+kFdfmkAMObeg4gmpF2HJ/JMJ5LZsOMuY V27Cyy2TpeCJrek07pwJbpBw= X-Received: by 127.0.0.2 with SMTP id Ahx2YY7687511x3T8snv3oaI; Wed, 15 Nov 2023 08:21:46 -0800 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.17544.1700065306099460175 for ; Wed, 15 Nov 2023 08:21:46 -0800 X-Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AFFTmdp003199; Wed, 15 Nov 2023 16:21:43 GMT X-Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uck901wpg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Nov 2023 16:21:42 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3AFGL7OY006538 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Nov 2023 16:21:07 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Wed, 15 Nov 2023 08:21:05 -0800 Date: Wed, 15 Nov 2023 16:21:02 +0000 From: "Leif Lindholm" To: Ashish Singhal CC: , , , Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation Message-ID: References: <0dfe6159ce24094f914dbe340a5656b95895b808.1700018266.git.ashishsingha@nvidia.com> MIME-Version: 1.0 In-Reply-To: <0dfe6159ce24094f914dbe340a5656b95895b808.1700018266.git.ashishsingha@nvidia.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: _MaVZlP7JP89cAItR1EHRYHaBWhj9iDn X-Proofpoint-ORIG-GUID: _MaVZlP7JP89cAItR1EHRYHaBWhj9iDn Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xDdR9MR0G13VYfEmVk5HJmi0x7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=VB4EVRH7; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none) On Tue, Nov 14, 2023 at 20:19:04 -0700, Ashish Singhal wrote: > Just like CPU _UID, ETE UID also needs to be unique so > use AcpiProcessorUid instead of CpuName > > Signed-off-by: Ashish Singhal > --- > .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c > index 8228c7845a..724f33c660 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c > @@ -359,6 +359,7 @@ CreateAmlCpcNode ( > > @param [in] Generator The SSDT Cpu Topology generator. > @param [in] ParentNode Parent node to attach the Cpu node to. > + @param [in] GicCInfo CM_ARM_GICC_INFO object used to create the node. > @param [in] CpuName Value used to generate the node name. Can that replace both uses of CpuName in the function (so it can be dropped), or does Status = WriteAslName ('E', CpuName, AslName); have other requirements? / Leif > @param [out] EtNodePtr If not NULL, return the created Cpu node. > > @@ -372,6 +373,7 @@ EFIAPI > CreateAmlEtd ( > IN ACPI_CPU_TOPOLOGY_GENERATOR *Generator, > IN AML_NODE_HANDLE ParentNode, > + IN CM_ARM_GICC_INFO *GicCInfo, > IN UINT32 CpuName, > OUT AML_OBJECT_NODE_HANDLE *EtNodePtr OPTIONAL > ) > @@ -397,7 +399,7 @@ CreateAmlEtd ( > > Status = AmlCodeGenNameInteger ( > "_UID", > - CpuName, > + GicCInfo->AcpiProcessorUid, > EtNode, > NULL > ); > @@ -474,6 +476,7 @@ CreateAmlEtNode ( > Status = CreateAmlEtd ( > Generator, > Node, > + GicCInfo, > CpuName, > NULL > ); > -- > 2.17.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111279): https://edk2.groups.io/g/devel/message/111279 Mute This Topic: https://groups.io/mt/102598848/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-