From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: <ndhillon@marvell.com>
Cc: <devel@edk2.groups.io>, <mw@semihalf.com>, <sbalcerak@marvell.com>
Subject: Re: [edk2-devel] [edk2-platforms PATCH v2 0/1] Marvell package restructure
Date: Thu, 16 Nov 2023 17:11:23 +0000 [thread overview]
Message-ID: <ZVZNO1we9E/1s5qp@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <20231102034552.4515-1-ndhillon@marvell.com>
Apologies, I managed to misfile this.
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
Typo in subject line fixed, pushed as ec5de71d83f3.
Thanks!
/
Leif
On Thu, Nov 02, 2023 at 09:15:51 +0530, ndhillon@marvell.com wrote:
> From: Narinder Dhillon <ndhillon@marvell.com>
>
> Current Silicon/Marvell package structure does not allow sharing of
> components that are common to different SoC's. This restructure will
> increase shared code and better seperation.
>
> Credit to Leif Lindholm for providing this new structure.
>
> v2:
> - Remove three lines for libraries that were erroneously introduced
> into MarvellSiliconPkg.dec file. These libraries are present in
> Armada7k8k.dsc.inc
> - Removed trailing new line at the end of MarvellSiliconPkg.dec
> - Squashed patches 2,3,4 into 1 as they don't build separately
>
> v1:
> - Original patch series restructuring Marvell package
>
>
> Narinder Dhillon (1):
> Silicon/Marvell: Retructure package
>
> .../Marvell/Armada70x0Db/Armada70x0Db.dsc | 108 ++++-----
> .../Armada70x0DbBoardDescLib.inf | 2 +-
> .../NonDiscoverableInitLib.inf | 2 +-
> .../Marvell/Armada80x0Db/Armada80x0Db.dsc | 133 ++++++-----
> .../Armada80x0DbBoardDescLib.inf | 2 +-
> .../NonDiscoverableInitLib.inf | 2 +-
> .../Cn9130DbABoardDescLib.inf | 2 +-
> .../Cn9132DbABoardDescLib.inf | 2 +-
> Platform/Marvell/Cn913xDb/Cn9130DbA.dsc.inc | 100 ++++-----
> Platform/Marvell/Cn913xDb/Cn9131DbA.dsc.inc | 66 +++---
> Platform/Marvell/Cn913xDb/Cn9132DbA.dsc.inc | 66 +++---
> Platform/Marvell/Cn913xDb/Cn913xDbA.dsc | 8 +-
> .../NonDiscoverableInitLib.inf | 2 +-
> .../Armada80x0McBin/Armada80x0McBin.dsc | 116 +++++-----
> .../Armada80x0McBinBoardDescLib.inf | 2 +-
> .../NonDiscoverableInitLib.inf | 2 +-
> .../BoardDescriptionLib.inf | 2 +-
> .../Cn913xCEx7Eval/Cn9130Eval.dsc.inc | 40 ++--
> .../Cn913xCEx7Eval/Cn9131Eval.dsc.inc | 56 ++---
> .../Cn913xCEx7Eval/Cn9132Eval.dsc.inc | 56 ++---
> .../Cn913xCEx7Eval/Cn913xCEx7.dsc.inc | 60 ++---
> .../Cn913xCEx7Eval/Cn913xCEx7Eval.dsc | 6 +-
> .../NonDiscoverableInitLib.inf | 2 +-
> .../Applications/EepromCmd/EepromCmd.inf | 2 +-
> .../Applications/FirmwareUpdate/FUpdate.inf | 6 +-
> .../Applications/SpiTool/SpiFlashCmd.inf | 6 +-
> .../Armada7k8k/AcpiTables/Armada70x0Db.inf | 2 +-
> .../Armada7k8k/AcpiTables/Armada80x0Db.inf | 2 +-
> .../Armada7k8k/AcpiTables/Armada80x0McBin.inf | 2 +-
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 22 +-
> .../Armada7k8kRngDxe/Armada7k8kRngDxe.inf | 4 +-
> .../Drivers/PlatInitDxe/PlatInitDxe.inf | 6 +-
> .../PlatformFlashAccessLib.inf | 6 +-
> .../Library/Armada7k8kLib/Armada7k8kLib.inf | 4 +-
> .../Armada7k8kMemoryInitPeiLib.inf | 14 +-
> .../PciHostBridgeLib.inf | 2 +-
> .../Armada7k8kPciSegmentLib/PciSegmentLib.inf | 2 +-
> .../Armada7k8kSampleAtResetLib.inf | 2 +-
> .../Armada7k8kSoCDescLib.inf | 4 +-
> .../RealTimeClockLib/RealTimeClockLib.inf | 4 +-
> .../Marvell/Documentation/PortingGuide.txt | 114 +++++-----
> .../Drivers/BoardDesc/MvBoardDescDxe.inf | 18 +-
> .../Drivers/Gpio/MvGpioDxe/MvGpioDxe.inf | 2 +-
> .../Gpio/MvPca95xxDxe/MvPca95xxDxe.inf | 2 +-
> .../Drivers/I2c/MvEepromDxe/MvEepromDxe.inf | 6 +-
> .../Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.inf | 14 +-
> .../Drivers/Net/MvMdioDxe/MvMdioDxe.inf | 2 +-
> .../Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.inf | 12 +-
> Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf | 16 +-
> .../NonDiscoverableDxe/NonDiscoverableDxe.inf | 2 +-
> .../Drivers/SdMmc/XenonDxe/XenonDxe.inf | 2 +-
> .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 14 +-
> .../Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.inf | 8 +-
> .../Spi/MvSpiFlashDxe/MvSpiFlashDxe.inf | 2 +-
> .../Spi/MvSpiOrionDxe/MvSpiOrionDxe.inf | 8 +-
> .../Marvell/Library/ComPhyLib/ComPhyLib.inf | 28 +--
> Silicon/Marvell/Library/IcuLib/IcuLib.inf | 4 +-
> Silicon/Marvell/Library/MppLib/MppLib.inf | 94 ++++----
> .../Marvell/Library/MvGpioLib/MvGpioLib.inf | 2 +-
> .../Marvell/Library/UtmiPhyLib/UtmiPhyLib.inf | 2 +-
> Silicon/Marvell/Marvell.dec | 208 ------------------
> .../Include/IndustryStandard/MvSmc.h | 0
> .../Include/Library/ArmadaBoardDescLib.h | 0
> .../Include/Library/ArmadaIcuLib.h | 0
> .../Include/Library/ArmadaSoCDescLib.h | 0
> .../Include/Library/MppLib.h | 0
> .../Include/Library/MvComPhyLib.h | 0
> .../Include/Library/MvGpioLib.h | 0
> .../Include/Library/NonDiscoverableInitLib.h | 0
> .../Include/Library/SampleAtResetLib.h | 0
> .../Include/Library/UtmiPhyLib.h | 0
> .../Include/Protocol/BoardDesc.h | 0
> .../Include/Protocol/Eeprom.h | 0
> .../Include/Protocol/Mdio.h | 0
> .../Include/Protocol/MvI2c.h | 0
> .../Include/Protocol/MvPhy.h | 0
> .../Include/Protocol/Spi.h | 0
> .../Include/Protocol/SpiFlash.h | 0
> .../MarvellSiliconPkg/MarvellSiliconPkg.dec | 207 +++++++++++++++++
> .../OcteonTx/AcpiTables/T91/Cn9130DbA.inf | 2 +-
> .../OcteonTx/AcpiTables/T91/Cn9131DbA.inf | 2 +-
> .../AcpiTables/T91/Cn913xCEx7Eval.inf | 2 +-
> 82 files changed, 848 insertions(+), 852 deletions(-)
> delete mode 100644 Silicon/Marvell/Marvell.dec
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/IndustryStandard/MvSmc.h (100%)
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/Library/ArmadaBoardDescLib.h (100%)
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/Library/ArmadaIcuLib.h (100%)
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/Library/ArmadaSoCDescLib.h (100%)
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/Library/MppLib.h (100%)
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/Library/MvComPhyLib.h (100%)
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/Library/MvGpioLib.h (100%)
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/Library/NonDiscoverableInitLib.h (100%)
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/Library/SampleAtResetLib.h (100%)
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/Library/UtmiPhyLib.h (100%)
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/Protocol/BoardDesc.h (100%)
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/Protocol/Eeprom.h (100%)
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/Protocol/Mdio.h (100%)
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/Protocol/MvI2c.h (100%)
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/Protocol/MvPhy.h (100%)
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/Protocol/Spi.h (100%)
> rename Silicon/Marvell/{ => MarvellSiliconPkg}/Include/Protocol/SpiFlash.h (100%)
> create mode 100644 Silicon/Marvell/MarvellSiliconPkg/MarvellSiliconPkg.dec
>
>
> base-commit: c1d04ecedf3246ec7c2e0cc12658c9c6a26f91ac
> --
> 2.34.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111321): https://edk2.groups.io/g/devel/message/111321
Mute This Topic: https://groups.io/mt/102335606/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-11-16 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 3:45 [edk2-devel] [edk2-platforms PATCH v2 0/1] Marvell package restructure Narinder Dhillon
2023-11-02 3:45 ` [edk2-devel] [edk2-platforms PATCH v2 1/1] Silicon/Marvell: Retructure package Narinder Dhillon
2023-11-14 20:24 ` Marcin Wojtas via groups.io
2023-11-16 17:11 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVZNO1we9E/1s5qp@qc-i7.hemma.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox