From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DC5F974003B for ; Tue, 21 Nov 2023 14:26:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gkMxc++ebd/jm9AuZqz38dFl7vTsQpI0re0af509cMw=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20140610; t=1700576798; v=1; b=c/0MlJIpW4+2KwBIkKjXjZKMTR59JXk+8NqS2ZCRvMYdrVGSrfboj446OF64Z1LGGNmPtr9i C0EBs/1nn30Zgv3t8omdNM9YqE6qOUA7li2diBTx2S3k+T8/+2/VtwiFdAY8JB9EzZQK/hjAObZ OwfhGTh1UQgN7p1P9ufUBqpQ= X-Received: by 127.0.0.2 with SMTP id nVd4YY7687511x5iwvdLOyh9; Tue, 21 Nov 2023 06:26:38 -0800 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.41881.1700576797914480705 for ; Tue, 21 Nov 2023 06:26:37 -0800 X-Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALE1q8B002602; Tue, 21 Nov 2023 14:26:35 GMT X-Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ugssks440-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 14:26:35 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3ALEQYk8025358 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 14:26:34 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 21 Nov 2023 06:26:31 -0800 Date: Tue, 21 Nov 2023 14:26:28 +0000 From: "Leif Lindholm" To: "Yao, Jiewen" CC: Pierre Gondois , "devel@edk2.groups.io" , "Li, Yi1" , "Lu, Xiaoyu1" , "Jiang, Guomin" , Ard Biesheuvel , Sami Mujawar , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency upon ArmPkg Message-ID: References: <20231121084715.1393672-1-pierre.gondois@arm.com> <20231121084715.1393672-3-pierre.gondois@arm.com> MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: JHrWMvqAfCsL_saWWx6VEy9eGfoyYIJv X-Proofpoint-ORIG-GUID: JHrWMvqAfCsL_saWWx6VEy9eGfoyYIJv X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 3ALE1q8B002602 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5nWOeuEHWLBYMg95pnY82rPKx7686176AA= Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="c/0MlJIp"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Jiewen, On Tue, Nov 21, 2023 at 13:41:21 +0000, Yao, Jiewen wrote: > Thanks to let me know the background. >=20 > Please be aware that there is fundamental difference between > dependency in INF and dependency in DSC. >=20 > What we have previously in the ArmPkg in *DSC*. We don=E2=80=99t need add > ArmPkg in yaml. > However, what you try to introduce is ArmPkg in *INF*, e.g. your > patch v5 5/6. Then we have to add ArmPkg in yaml. >=20 > Personally, I don=E2=80=99t think it is a good idea to add ArmPkg to yaml= , > because it means that you have to pull ArmPkg when you build > CryptoPkg,. >=20 > As long as what you add is industry standard, it is OK to add to > MdePkg, like what you did in v2. I would like to suggest this > approach. Ultimately, all of ArmPkg needs to migrate to MdePkg. See https://bugzilla.tianocore.org/show_bug.cgi?id=3D4121 But this is a BIG task. The reason I asked Pierre to add this functionality in ArmPkg rather than MdePkg is because that is where the existing related discovery code lives. (Think of it as CPUID.) For historical reasons, predating mine and Ard's involvement with edk2, this functionality (as well as other critical Arm functionality) lives in a library called ArmLib, under ArmPkg. For Ia32/X64, all such support lives in BaseLib, under MdePkg. This is why I referred to ArmPkg as an exclave of MdePkg in my original reply to Pierre. And until someone untangles this, it's not realistic to treat ArmPkg as anything else. And I don't think it's fair to expect Pierre to untangle this as part of this series. But I also don't think "Arm architectures need to duplicate their basic support code across multiple packages" is a solution. Regards, Leif > But I would like to have ARM expert to check if those are really ARM > standard, and also have MdePkg owner check if it is acceptable. >=20 > Thank you > Yao, Jiewen >=20 >=20 >=20 >=20 > > -----Original Message----- > > From: Pierre Gondois > > Sent: Tuesday, November 21, 2023 8:59 PM > > To: Yao, Jiewen ; devel@edk2.groups.io; Leif Lind= holm > > > > Cc: Li, Yi1 ; Lu, Xiaoyu1 ; Jia= ng, Guomin > > ; Ard Biesheuvel ; S= ami > > Mujawar ; Gerd Hoffmann > > Subject: Re: [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependen= cy > > upon ArmPkg > >=20 > > Hello Jiewen, > >=20 > > On 11/21/23 12:27, Yao, Jiewen wrote: > > > Why CryptoPkg needs to depend on ArmPkg? > > > > > > Can we move content to MdePkg? > >=20 > > The OpensslLib needs to discover the native instruction supported by th= e > > underlying platform before using them. This could also be done through = the > > MdePkg as you suggested. The v2 is implemented that way: > > https://edk2.groups.io/g/devel/message/110953 > >=20 > > Also, as noted by Leif, it seems there is already a dependency over Arm= Pkg: > > # git grep ArmPkg CryptoPkg/ > > CryptoPkg/CryptoPkg.dsc: ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > > CryptoPkg/CryptoPkg.dsc: > > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > > CryptoPkg/CryptoPkg.dsc: > > ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf > > CryptoPkg/CryptoPkgMbedTls.dsc: > > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > > CryptoPkg/CryptoPkgMbedTls.dsc: > > ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf > > CryptoPkg/CryptoPkgMbedTls.dsc: > > PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/Pe= iServic > > esTablePointerLib.inf > >=20 > > Both solutions suit me (discovering capabilities through ArmPkg or MdeP= kg), > > I just need to know which one is preferred, > >=20 > > Regards, > > Pierre > >=20 > > > > > >> -----Original Message----- > > >> From: Pierre Gondois > > >> Sent: Tuesday, November 21, 2023 4:47 PM > > >> To: devel@edk2.groups.io > > >> Cc: Yao, Jiewen ; Li, Yi1 ; = Lu, > > Xiaoyu1 > > >> ; Jiang, Guomin ; Leif > > Lindholm > > >> ; Ard Biesheuvel ; > > >> Sami Mujawar ; Gerd Hoffmann > > >> > > >> Subject: [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependenc= y upon > > >> ArmPkg > > >> > > >> Allow dependency upon ArmPkg to pass the dependency Check. > > >> > > >> Signed-off-by: Pierre Gondois > > >> --- > > >> CryptoPkg/CryptoPkg.ci.yaml | 1 + > > >> 1 file changed, 1 insertion(+) > > >> > > >> diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.ya= ml > > >> index f961d85927c0..3bbb220d3224 100644 > > >> --- a/CryptoPkg/CryptoPkg.ci.yaml > > >> +++ b/CryptoPkg/CryptoPkg.ci.yaml > > >> @@ -69,6 +69,7 @@ > > >> }, > > >> > > >> "DependencyCheck": { > > >> > > >> "AcceptableDependencies": [ > > >> > > >> + "ArmPkg/ArmPkg.dec", > > >> > > >> "MdePkg/MdePkg.dec", > > >> > > >> "MdeModulePkg/MdeModulePkg.dec", > > >> > > >> "CryptoPkg/CryptoPkg.dec", > > >> > > >> -- > > >> 2.25.1 > > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111549): https://edk2.groups.io/g/devel/message/111549 Mute This Topic: https://groups.io/mt/102725178/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-