From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F39B67803D0 for ; Tue, 21 Nov 2023 15:55:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ViOgy40eFzltsdKeafDgiIETnLnAo+zJdppevAJMSTQ=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20140610; t=1700582155; v=1; b=EVRdF5g0cRZrHfNihrx9KENEwQlRoCoeqt+4layOBNdQYzWMaJYasYXYcuyyF44lVmVS3Q5J BFv0QifdW/RAmk7W7lK0Wqf3A5DD0IeB+7y0SPKscORxALayCuiPjfqNRQbeozh9tt+0FQDKBa5 pQivsSrisst+UtmMB8ig0R4U= X-Received: by 127.0.0.2 with SMTP id VFwqYY7687511x69izJKfomN; Tue, 21 Nov 2023 07:55:55 -0800 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.44949.1700582154554506899 for ; Tue, 21 Nov 2023 07:55:54 -0800 X-Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALFV09U011664; Tue, 21 Nov 2023 15:55:51 GMT X-Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ugr85shdn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 15:55:50 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3ALFtnM2020436 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 15:55:49 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 21 Nov 2023 07:55:47 -0800 Date: Tue, 21 Nov 2023 15:55:43 +0000 From: "Leif Lindholm" To: "Yao, Jiewen" CC: Pierre Gondois , "devel@edk2.groups.io" , "Li, Yi1" , "Lu, Xiaoyu1" , "Jiang, Guomin" , Ard Biesheuvel , Sami Mujawar , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency upon ArmPkg Message-ID: References: <20231121084715.1393672-1-pierre.gondois@arm.com> <20231121084715.1393672-3-pierre.gondois@arm.com> MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: 8DxaT8WYDy-wNt4mWVvRv1eSEEQqGnQA X-Proofpoint-ORIG-GUID: 8DxaT8WYDy-wNt4mWVvRv1eSEEQqGnQA X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 3ALFV09U011664 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: raYwNGieNfPAQbTRPMCeVcGWx7686176AA= Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=EVRdF5g0; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, Nov 21, 2023 at 14:46:05 +0000, Yao, Jiewen wrote: > This Bugzilla is filed in 2022-10-26. Now it is 2023-11-21. Oh, I'm sure I voiced the same opinion for many years before someone (rightly) told me to go gile that bugzilla. > I agree with you that it is a big task. May I know what is the plan? > E.g. who is working on that? When do you expect it will be done? On my list of "big items" to deal with, this comes after github PR migration and line-ending conversion. > According to the dependency rule, what we need is only *interface* > definition, but not *implementation*. > That means the really requirement here is to move *interface* from > ArmPkg to MdePkg, you can still keep the library implementation in > ArmPkg. (It is just a subset of this Bugzilla) That ... is an option I had not previously considered. Long-term we would still like to smash ArmLib into BaseLib, but if MdePkg maintainers would be OK with moving ArmLib.h into MdePkg... > Also, I don=E2=80=99t think CPUID check really matters here - since it is= only implementation. > As long as, you have interface in MdePkg, then your INF can declare that = interface. > You can still put real implementation in ArmPkg - no requirement to move. > That benefit is that you don=E2=80=99t need to add ArmPkg dependency in y= aml. I can spin up a patch for that to get merged shortly after stable tag to give plenty of time to catch any issues that may arise from moving such a fundamental file. (These would likely be bugs, but nevertheless...) Thanks! / Leif > Thank you > Yao, Jiewen >=20 > > -----Original Message----- > > From: Leif Lindholm > > Sent: Tuesday, November 21, 2023 10:26 PM > > To: Yao, Jiewen > > Cc: Pierre Gondois ; devel@edk2.groups.io; Li, = Yi1 > > ; Lu, Xiaoyu1 ; Jiang, Guomin > > ; Ard Biesheuvel ; S= ami > > Mujawar ; Gerd Hoffmann > > Subject: Re: [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependen= cy > > upon ArmPkg > >=20 > > Hi Jiewen, > >=20 > > On Tue, Nov 21, 2023 at 13:41:21 +0000, Yao, Jiewen wrote: > > > Thanks to let me know the background. > > > > > > Please be aware that there is fundamental difference between > > > dependency in INF and dependency in DSC. > > > > > > What we have previously in the ArmPkg in *DSC*. We don=E2=80=99t need= add > > > ArmPkg in yaml. > > > However, what you try to introduce is ArmPkg in *INF*, e.g. your > > > patch v5 5/6. Then we have to add ArmPkg in yaml. > > > > > > Personally, I don=E2=80=99t think it is a good idea to add ArmPkg to = yaml, > > > because it means that you have to pull ArmPkg when you build > > > CryptoPkg,. > > > > > > As long as what you add is industry standard, it is OK to add to > > > MdePkg, like what you did in v2. I would like to suggest this > > > approach. > >=20 > > Ultimately, all of ArmPkg needs to migrate to MdePkg. > > See https://bugzilla.tianocore.org/show_bug.cgi?id=3D4121 > > But this is a BIG task. > >=20 > > The reason I asked Pierre to add this functionality in ArmPkg rather > > than MdePkg is because that is where the existing related discovery > > code lives. (Think of it as CPUID.) > >=20 > > For historical reasons, predating mine and Ard's involvement with > > edk2, this functionality (as well as other critical Arm functionality) > > lives in a library called ArmLib, under ArmPkg. > > For Ia32/X64, all such support lives in BaseLib, under MdePkg. > >=20 > > This is why I referred to ArmPkg as an exclave of MdePkg in my > > original reply to Pierre. And until someone untangles this, it's not > > realistic to treat ArmPkg as anything else. > >=20 > > And I don't think it's fair to expect Pierre to untangle this as part > > of this series. But I also don't think "Arm architectures need to > > duplicate their basic support code across multiple packages" is a > > solution. > >=20 > > Regards, > >=20 > > Leif > >=20 > > > But I would like to have ARM expert to check if those are really ARM > > > standard, and also have MdePkg owner check if it is acceptable. > > > > > > Thank you > > > Yao, Jiewen > > > > > > > > > > > > > > > > -----Original Message----- > > > > From: Pierre Gondois > > > > Sent: Tuesday, November 21, 2023 8:59 PM > > > > To: Yao, Jiewen ; devel@edk2.groups.io; Leif > > Lindholm > > > > > > > > Cc: Li, Yi1 ; Lu, Xiaoyu1 ;= Jiang, > > Guomin > > > > ; Ard Biesheuvel ; > > Sami > > > > Mujawar ; Gerd Hoffmann > > > > Subject: Re: [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow depe= ndency > > > > upon ArmPkg > > > > > > > > Hello Jiewen, > > > > > > > > On 11/21/23 12:27, Yao, Jiewen wrote: > > > > > Why CryptoPkg needs to depend on ArmPkg? > > > > > > > > > > Can we move content to MdePkg? > > > > > > > > The OpensslLib needs to discover the native instruction supported b= y the > > > > underlying platform before using them. This could also be done thro= ugh the > > > > MdePkg as you suggested. The v2 is implemented that way: > > > > https://edk2.groups.io/g/devel/message/110953 > > > > > > > > Also, as noted by Leif, it seems there is already a dependency over= ArmPkg: > > > > # git grep ArmPkg CryptoPkg/ > > > > CryptoPkg/CryptoPkg.dsc: ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.i= nf > > > > CryptoPkg/CryptoPkg.dsc: > > > > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > > > > CryptoPkg/CryptoPkg.dsc: > > > > ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf > > > > CryptoPkg/CryptoPkgMbedTls.dsc: > > > > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > > > > CryptoPkg/CryptoPkgMbedTls.dsc: > > > > ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf > > > > CryptoPkg/CryptoPkgMbedTls.dsc: > > > > > > PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/Pe= iServic > > > > esTablePointerLib.inf > > > > > > > > Both solutions suit me (discovering capabilities through ArmPkg or = MdePkg), > > > > I just need to know which one is preferred, > > > > > > > > Regards, > > > > Pierre > > > > > > > > > > > > > >> -----Original Message----- > > > > >> From: Pierre Gondois > > > > >> Sent: Tuesday, November 21, 2023 4:47 PM > > > > >> To: devel@edk2.groups.io > > > > >> Cc: Yao, Jiewen ; Li, Yi1 ; Lu, > > > > Xiaoyu1 > > > > >> ; Jiang, Guomin ; = Leif > > > > Lindholm > > > > >> ; Ard Biesheuvel > > ; > > > > >> Sami Mujawar ; Gerd Hoffmann > > > > >> > > > > >> Subject: [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow depen= dency > > upon > > > > >> ArmPkg > > > > >> > > > > >> Allow dependency upon ArmPkg to pass the dependency Check. > > > > >> > > > > >> Signed-off-by: Pierre Gondois > > > > >> --- > > > > >> CryptoPkg/CryptoPkg.ci.yaml | 1 + > > > > >> 1 file changed, 1 insertion(+) > > > > >> > > > > >> diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.c= i.yaml > > > > >> index f961d85927c0..3bbb220d3224 100644 > > > > >> --- a/CryptoPkg/CryptoPkg.ci.yaml > > > > >> +++ b/CryptoPkg/CryptoPkg.ci.yaml > > > > >> @@ -69,6 +69,7 @@ > > > > >> }, > > > > >> > > > > >> "DependencyCheck": { > > > > >> > > > > >> "AcceptableDependencies": [ > > > > >> > > > > >> + "ArmPkg/ArmPkg.dec", > > > > >> > > > > >> "MdePkg/MdePkg.dec", > > > > >> > > > > >> "MdeModulePkg/MdeModulePkg.dec", > > > > >> > > > > >> "CryptoPkg/CryptoPkg.dec", > > > > >> > > > > >> -- > > > > >> 2.25.1 > > > > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111555): https://edk2.groups.io/g/devel/message/111555 Mute This Topic: https://groups.io/mt/102725178/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-