From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D36EDAC1252 for ; Wed, 6 Dec 2023 14:30:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Xsm7N3zOA8QUMuAcvXPn+nMGsf5W5WzToSoibP0hfdw=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1701873002; v=1; b=LLemmgk2Tx1ur5Ywgslr2nnoXEmjLIghwBHsRCy1e3eu1TsmX1zkhE84FcpEbFjyrSYjhR/F EcG31U9Im0mx+R5/XbvVgN16LyVKdtT+V2ink/Ss9roy9zDU/Pip7m2y/uDT+jAh5v5IxMYNJpN DgM8vr+qyL65cR52uVQfenH4= X-Received: by 127.0.0.2 with SMTP id tYBaYY7687511xu45Cc5IYeW; Wed, 06 Dec 2023 06:30:02 -0800 X-Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mx.groups.io with SMTP id smtpd.web10.33007.1701873001977398342 for ; Wed, 06 Dec 2023 06:30:02 -0800 X-Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1ce28faa92dso30712805ad.2 for ; Wed, 06 Dec 2023 06:30:01 -0800 (PST) X-Gm-Message-State: rlEAg4ZqaVlJzM2qieJCqEnZx7686176AA= X-Google-Smtp-Source: AGHT+IEYm14sX/pSsIIlHr4gReg0/UXEGZBoiAbi/0To64kTFhMbOexxTBCUc13BKfZ3uGP0c+iKPQ== X-Received: by 2002:a17:902:db06:b0:1d0:7adc:1af0 with SMTP id m6-20020a170902db0600b001d07adc1af0mr673354plx.35.1701873001415; Wed, 06 Dec 2023 06:30:01 -0800 (PST) X-Received: from sunil-laptop ([106.51.188.200]) by smtp.gmail.com with ESMTPSA id b11-20020a170902650b00b001c71ec1866fsm12380512plk.258.2023.12.06.06.29.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 06:30:01 -0800 (PST) Date: Wed, 6 Dec 2023 19:59:54 +0530 From: "Sunil V L" To: Dhaval Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Andrei Warkentin , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v9 5/5] OvmfPkg/RiscVVirt: Override for RV CPU Features Message-ID: References: <20231204082950.96914-1-dhaval@rivosinc.com> <20231204082950.96914-6-dhaval@rivosinc.com> MIME-Version: 1.0 In-Reply-To: <20231204082950.96914-6-dhaval@rivosinc.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=LLemmgk2; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Dhaval, Few minor comments. 1) Please use RISC-V instead of RV every where. On Mon, Dec 04, 2023 at 01:59:50PM +0530, Dhaval wrote: > This PCD provides a way for platform to override any > HW features that are default enabled by previous stages > of FW (like OpenSBI). For the case where previous/prev > stage has disabled the feature, this override is not > useful and its usage should be avoided. > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Sunil V L > Cc: Andrei Warkentin > Cc: Laszlo Ersek > > Signed-off-by: Dhaval Sharma > Acked-by: Laszlo Ersek > Reviewed-by: Andrei Warkentin > --- > > Notes: > V8: > - Added RV tag > V7: > - Added RB tag > v6: > - Modify PCD name according to changes made in Baselib implementation > V5: > - Introduce PCD for platform > > OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > index fe320525153f..5d66f7fe6ae6 100644 > --- a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > +++ b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > @@ -203,6 +203,7 @@ [PcdsFeatureFlag] > gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE > > [PcdsFixedAtBuild.common] > + gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0 Could you set this to 0xFFFFFFFFFFFFFFFE? Just disable only CMO? Thanks, Snil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112127): https://edk2.groups.io/g/devel/message/112127 Mute This Topic: https://groups.io/mt/102967059/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-