From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9AD07D801B2 for ; Mon, 11 Dec 2023 15:20:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=aFvUXc2lx358h5EbalhTq+/1q5Md63DaXvFdUljgYAM=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20140610; t=1702308048; v=1; b=R+G71mkWrtx4wmdibbbn0jR1nKd1lgNHNekhcVZvxWsNhzYdcVllqkfOd9OqzaqNHhTqR2Yb fk97DKa1nBhD6coffzWm3qWJsQIYIloT1rv7U5na7N9TOPa0RffOCzgNJPNZBldOq4LBRklef0y +rk1ziTy9/SkiRF8i69pyYx8= X-Received: by 127.0.0.2 with SMTP id 5FXTYY7687511x4JYY1gSYC2; Mon, 11 Dec 2023 07:20:48 -0800 X-Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mx.groups.io with SMTP id smtpd.web11.10916.1702308047597280643 for ; Mon, 11 Dec 2023 07:20:47 -0800 X-Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1d0bb7ff86cso41352655ad.1 for ; Mon, 11 Dec 2023 07:20:47 -0800 (PST) X-Gm-Message-State: xJchWAdrl8WgxVJkEBLKYasKx7686176AA= X-Google-Smtp-Source: AGHT+IGI0TdO+EXifgJR906KY0YGCIywp7lGf0pgzRSAEHoXCwHI5NoiUBev9fDnwmj9yn4GfRCBKg== X-Received: by 2002:a17:903:22c7:b0:1cf:e9b5:90ee with SMTP id y7-20020a17090322c700b001cfe9b590eemr6504999plg.24.1702308046955; Mon, 11 Dec 2023 07:20:46 -0800 (PST) X-Received: from sunil-laptop ([106.51.188.200]) by smtp.gmail.com with ESMTPSA id p17-20020a170903249100b001d0b4693539sm6748350plw.189.2023.12.11.07.20.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 07:20:46 -0800 (PST) Date: Mon, 11 Dec 2023 20:50:40 +0530 From: "Sunil V L" To: Pedro Falcato Cc: devel@edk2.groups.io, Dhaval Sharma , Michael D Kinney , Liming Gao , Zhiguang Liu , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v9 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V Message-ID: References: <20231204082950.96914-1-dhaval@rivosinc.com> <20231204082950.96914-5-dhaval@rivosinc.com> MIME-Version: 1.0 In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=R+G71mkW; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none On Mon, Dec 11, 2023 at 03:09:19PM +0000, Pedro Falcato wrote: > On Mon, Dec 11, 2023 at 1:12 PM Sunil V L wrote: > > > > On Sun, Dec 10, 2023 at 07:51:12PM +0530, Dhaval Sharma wrote: > [...] > > > nit: Can we pick a log style here? Like : > > > In this case, "CacheOpCacheRange: Performing ...". It's just prettier > > > and more greppable. > > > My interpretation of this was removing __func__ and instead having some > > > relevant text would make it more searchable. > > > And it kind of did make sense to me. I know many places __func__ is used > > > but this is just a perspective. > > > > > I think the comment meant to follow a standard logging format since > > there was no ":" and a space in original change. I prefer __func__ over > > this so that we don't need to update multiple lines in case function > > name gets changed. > > I definitely meant that __func__ should not be used for this as well. > You can't really search for an error message if you're doing > gratuitous printf formatting for no reason. > Linux even has a policy where user-facing strings (i.e logs) cannot > get broken up, even if you run out of line width. > Thanks Pedro. Do you mean __func__ should not be used at all in any of logging? Or is there a case where it is allowed vs not allowed? Thanks, Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112307): https://edk2.groups.io/g/devel/message/112307 Mute This Topic: https://groups.io/mt/102967058/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-