From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5E842740056 for ; Tue, 19 Dec 2023 07:31:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nH9Vf/IlaGTaGjl7DquEWxGLw8ZtX1fEOT8uq+jWlIE=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1702971068; v=1; b=XJGUwC8eyXJAtf6M9z5T+R/5pZSXBqWL+jWRrM35ZXEjkyUJ39zbrzP2E1Nb1BwxyTfVRpev hUmy0GSIjDkdhq5ENQYb0mbx0xqhMuru/ZOXpO6JANVLTSZ2YJNYJXK3f3KwMUKQxUB0VYmE/fn iPQzUmmq/QRIzwjhsGYxPDrc= X-Received: by 127.0.0.2 with SMTP id 0oWFYY7687511xQLGHC4chnn; Mon, 18 Dec 2023 23:31:08 -0800 X-Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mx.groups.io with SMTP id smtpd.web10.7453.1702971068364398067 for ; Mon, 18 Dec 2023 23:31:08 -0800 X-Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1d3536cd414so33390225ad.2 for ; Mon, 18 Dec 2023 23:31:08 -0800 (PST) X-Gm-Message-State: SXZi9LTDk2aI40cqD2hPQxwZx7686176AA= X-Google-Smtp-Source: AGHT+IH/NMbZZBNelKjBQXGYat7TZDfsjtzWFApcqBqAMl1yNkSTwowFf/hn0cJTADl6pKN8YQOFlg== X-Received: by 2002:a17:902:c40c:b0:1d3:155b:8181 with SMTP id k12-20020a170902c40c00b001d3155b8181mr18860952plk.1.1702971067823; Mon, 18 Dec 2023 23:31:07 -0800 (PST) X-Received: from sunil-laptop ([106.51.188.200]) by smtp.gmail.com with ESMTPSA id h8-20020a170902704800b001d0c09cc6ebsm20291327plt.92.2023.12.18.23.31.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 23:31:07 -0800 (PST) Date: Tue, 19 Dec 2023 13:01:02 +0530 From: "Sunil V L" To: Dhaval Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Andrei Warkentin , Laszlo Ersek , Pedro Falcato Subject: Re: [edk2-devel] [PATCH v10 5/5] OvmfPkg/RiscVVirt: Override for RISC-V CPU Features Message-ID: References: <20231213145931.28307-1-dhaval@rivosinc.com> <20231213145931.28307-6-dhaval@rivosinc.com> MIME-Version: 1.0 In-Reply-To: <20231213145931.28307-6-dhaval@rivosinc.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=XJGUwC8e; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Dec 13, 2023 at 08:29:31PM +0530, Dhaval wrote: > This PCD provides a way for platform to override any > HW features that are default enabled by previous stages > of FW (like OpenSBI). For the case where previous/prev > stage has disabled the feature, this override is not > useful and its usage should be avoided. > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Sunil V L > Cc: Andrei Warkentin > Cc: Laszlo Ersek > Cc: Pedro Falcato > > Signed-off-by: Dhaval Sharma > Acked-by: Laszlo Ersek > Reviewed-by: Andrei Warkentin > --- > > Notes: > V10: > - Only keep CMO feature bitmask bit to disabled. Unimplemented bits > remain 1. > V8: > - Added RV tag > V7: > - Added RB tag > v6: > - Modify PCD name according to changes made in Baselib implementation > V5: > - Introduce PCD for platform > > OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > index fe320525153f..a050f1ffc1d4 100644 > --- a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > +++ b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > @@ -203,6 +203,7 @@ [PcdsFeatureFlag] > gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE > > [PcdsFixedAtBuild.common] > + gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFE This needs to be a 64-bit value. Again, I will fix it before merging. Reviewed-by: Sunil V L -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112711): https://edk2.groups.io/g/devel/message/112711 Mute This Topic: https://groups.io/mt/103150443/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-