From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4A6EBAC1224 for ; Tue, 19 Dec 2023 11:50:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=tU3PtVyloBgkgh54hHpUSvTbUDjmY3sekJvfcYgjNvY=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20140610; t=1702986652; v=1; b=agx2BcfAyaYk2DSPPAgJMfVSnWXm49hAxBOkNkaK+NoMIgxVQ5EMjHJ9GXgJ5781pcBdMOCs pE831rfWRuyGONDvAI0650q0VByXCrT4lBH7nkrUT5rDAOqG7X/Yu7MBKWE+bz03t3rs8m5ChRh OLqpSM4Uzc+dwKyHWHV6NHqE= X-Received: by 127.0.0.2 with SMTP id AenEYY7687511xZqnl6P5jFY; Tue, 19 Dec 2023 03:50:52 -0800 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.10188.1702986651090581328 for ; Tue, 19 Dec 2023 03:50:51 -0800 X-Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3BJAbdbO018680; Tue, 19 Dec 2023 11:50:40 GMT X-Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3v35tm8t82-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Dec 2023 11:50:40 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3BJBod8g009443 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Dec 2023 11:50:39 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 19 Dec 2023 03:50:36 -0800 Date: Tue, 19 Dec 2023 11:50:33 +0000 From: "Leif Lindholm" To: , CC: , "Liming Gao (Byosoft address)" , Michael Kinney , Laszlo Ersek , Jeremy Linton , Pete Batard , Daniel P =?iso-8859-1?Q?=2E_Berrang=E9?= , Gerd Hoffmann , Samer El-Haj-Mahmoud Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery Message-ID: References: <20231031173700.647004-1-ngompa@fedoraproject.org> <58ec87dc-ce03-6ad8-681a-d815bc5c39f9@arm.com> MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: YxIIjh8SfRlsRd1SauX3tWSsP9n4vz5G X-Proofpoint-ORIG-GUID: YxIIjh8SfRlsRd1SauX3tWSsP9n4vz5G X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 3BJAbdbO018680 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: G4jGAuAyNkjLyXC7pFfmRo8ox7686176AA= Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=agx2BcfA; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Dec 18, 2023 at 22:55:21 +0100, Ard Biesheuvel wrote: > Hello all, >=20 > Same question again. Could we please make some progress on this? >=20 > Full thread here: > https://openfw.io/edk2-devel/20231031173700.647004-1-ngompa@fedoraproject= .org/ >=20 > If nobody objects, I will assume that the change is acceptable and > merge it by the end of the week. I'm OK with this. The last comment from Liming in https://bugzilla.tianocore.org/show_bug.cgi?id=3D2831 was that the fix could be merged after "the next UEFI is published", which it was - in August 2022. Reviewed-by: Leif Lindholm Regards, Leif > Thanks, > Ard. >=20 >=20 >=20 > On Tue, 12 Dec 2023 at 09:11, Ard Biesheuvel wrote: > > > > (cc Mike, Leif) > > > > On Thu, 7 Dec 2023 at 08:40, Ard Biesheuvel wrote: > > > > > > (cc Liming) > > > > > > On Thu, 7 Dec 2023 at 05:48, Neal Gompa wrote: > > > > > > > > On Fri, Nov 24, 2023 at 6:36=E2=80=AFPM Neal Gompa wrote: > > > > > > > > > > On Thu, Nov 2, 2023 at 6:35=E2=80=AFAM Laszlo Ersek wrote: > > > > > > > > > > > > On 10/31/23 23:27, Jeremy Linton wrote: > > > > > > > On 10/31/23 12:37, Neal Gompa via groups.io wrote: > > > > > > >> From: Neal Gompa > > > > > > >> > > > > > > >> Currently, the ReadyToBoot event is only signaled when a for= mal Boot > > > > > > >> Manager option is executed (in BmBoot.c -> EfiBootManagerBoo= t ()). > > > > > > >> > > > > > > >> However, the introduction of Platform Recovery in UEFI 2.5 m= akes it > > > > > > >> necessary to signal ReadyToBoot when a Platform Recovery boo= t loader > > > > > > >> runs because otherwise it may lead to the execution of a boo= t loader > > > > > > >> that has similar requirements to a regular one that is not l= aunched > > > > > > >> as a Boot Manager option. > > > > > > >> > > > > > > >> This is especially critical to ensuring that the graphical c= onsole > > > > > > >> is actually usable during platform recovery, as some platfor= ms do > > > > > > >> rely on the ConsolePrefDxe driver, which only performs conso= le > > > > > > >> initialization after ReadyToBoot is triggered. > > > > > > >> > > > > > > >> This patch fixes that behavior by calling EfiSignalEventRead= yToBoot () > > > > > > >> in EfiBootManagerProcessLoadOption () when invoking platform= recovery, > > > > > > >> which is the function that sets up the platform recovery boo= t process. > > > > > > >> > > > > > > >> The expected behavior has been clarified in the UEFI 2.10 sp= ecification > > > > > > >> to explicitly indicate this behavior is required for correct= operation. > > > > > > >> > > > > > > >> This is a rebased version of the patch originally written by= Pete Batard. > > > > > > > > > > > > > > Took me a bit to swap in that whole conversation again, and r= echeck the > > > > > > > spec's and code paths, but this all looks fine to me and shou= ld allow > > > > > > > the PFTF build to drop the similar patch from Pete that has b= een carried > > > > > > > downstream for the past couple years. > > > > > > > > > > > > > > As for testing the previous patch has been in the field for a= couple > > > > > > > years now and i'm not aware of it causing any issues. The add= itional > > > > > > > restriction of limiting it to platform recovery logically mak= es sense, > > > > > > > and as far as I can see shouldn't cause any problems. > > > > > > > > > > > > > > So, > > > > > > > > > > > > > > Reviewed-by: Jeremy Linton > > > > > > > > > > > > > > > > > > > > > As a PS: I also went to check the ready to boot behavior for = OsRecovery > > > > > > > and realized that apparently none of that support was ever me= rged? > > > > > > > > > > > > What else is there, outside of this patch, in need of upstreami= ng? > > > > > > > > > > > > > That seems a bit of an oversight since its been in the spec f= or a few years now. > > > > > > > > > > > > "ready-to-boot for OsRecovery" is new in UEFI 2.10 (according t= o the > > > > > > commit message), which is quite recent ("Aug 29, 2022"). > > > > > > > > > > > > I couldn't find the Mantis ticket in the Revision History (for = 2.10) though. > > > > > > > > > > > > > > > > Is there anything else holding up committing this patch? Jeremy a= nd > > > > > you reviewed it earlier in the month... > > > > > > > > > > > > > Friendly ping again? It's been a month now... > > > > > > > > > > Apologies for the delay - Liming, can we progress with this? > > > > Can we please make some progress with this? This has been in limbo for > > far too long. > > > > Thanks, >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112718): https://edk2.groups.io/g/devel/message/112718 Mute This Topic: https://groups.io/mt/102302654/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-