From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2090C740038 for ; Wed, 10 Jan 2024 04:20:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=yxWJZaBh/kUKWoW/Cpo17xnK3Jqb1BrFsksJtP03T7Y=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1704860426; v=1; b=ZN1NFA4oRtesGv7HAnV9iopaS8V4tzSKKe4Bt1ZdsgZN67jgNASeuk+vMd3cF4xHo8Msrjrp ObBO3VQw8fsWE8vmX1GkB7OAecYpAoEq6kpDqWvIZJ0lDtLaVB/cMX+k6EyLIgRdY2s2pm5yzBM P5XFiyiG2Ez8/nPthmg+cLhI= X-Received: by 127.0.0.2 with SMTP id Wb1QYY7687511xmokxiOPF2l; Tue, 09 Jan 2024 20:20:26 -0800 X-Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by mx.groups.io with SMTP id smtpd.web10.5080.1704860425831491052 for ; Tue, 09 Jan 2024 20:20:25 -0800 X-Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-7bee6a5ba1aso38511639f.1 for ; Tue, 09 Jan 2024 20:20:25 -0800 (PST) X-Gm-Message-State: v9DPr7c6rv65TxNHYcR7LOutx7686176AA= X-Google-Smtp-Source: AGHT+IHv3cPGdvXkvAZTWsBCSgzXaSWYw9TRlHmbfk7wo8bF1+c7RuDALlAiTlkkwUSrYNs7UBoKYg== X-Received: by 2002:a5e:d613:0:b0:7bb:41bd:715f with SMTP id w19-20020a5ed613000000b007bb41bd715fmr156822iom.39.1704860425132; Tue, 09 Jan 2024 20:20:25 -0800 (PST) X-Received: from sunil-laptop ([106.51.83.242]) by smtp.gmail.com with ESMTPSA id q12-20020a0566380ecc00b0046e2fcd0322sm1067574jas.60.2024.01.09.20.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 20:20:24 -0800 (PST) Date: Wed, 10 Jan 2024 09:50:17 +0530 From: "Sunil V L" To: Jeshua Smith Cc: "devel@edk2.groups.io" , Ard Biesheuvel , Leif Lindholm , Pierre Gondois , Sami Mujawar , Andrei Warkentin , Laszlo Ersek , AbdulLateef Attar , Jeff Brasen Subject: Re: [edk2-devel] [RFC PATCH v1 00/20] DynamicTablesPkg: Prepare to add RISC-V support Message-ID: References: <20240109162944.528006-1-sunilvl@ventanamicro.com> MIME-Version: 1.0 In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ZN1NFA4o; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Jeshua, On Tue, Jan 09, 2024 at 06:37:43PM +0000, Jeshua Smith wrote: > > From: devel@edk2.groups.io On Behalf Of Sunil V L > > via groups.io > > Sent: Tuesday, January 9, 2024 9:29 AM > > DynamicTablesPkg can be used by RISC-V platforms to generate ACPI tables > > from FDT passed from previous stage FW. However, DynamicTablesPkg > > currently is ARM specific even though several parsers and ACPI generators can > > be used across architectures. For ex: SSDT (PCIe), SSDT (CPU), MCFG, SPCR, > > DBG2, FADT, SRAT, Raw (DSDT) are mostly common across architectures. Only > > MADT, IORT and GTDT are ARM specific. > > > > This series tries to refactor the DynamicTablesPkg so that RISC-V support can > > be added fairly easily later. > > It looks like instead of moving the common code to EObjNameSpaceStandard namespace or a new (Arch? Common?) namespace, you're renaming the entire EObjNameSpaceArm namespace to EObjNameSpaceArch. It seems to me that if ARM code vs. common code is being separated out, then the EObjNameSpaceArm namespace should continue to be used for the ARM-specific code and a common namespace should be used for the common code. I agree. I started with separating common things into new common space and create one for risc-v. However, I dropped that approach for two reasons. 1) The commit "b2bbe3df5470 DynamicTablesPkg: Remove PPTT ID structure from ACPI 6.4 generator" when removed one of the enums from ArmObjectID, didn't change the other values for other enums but reserved the removed one. So, I thought there may be some assumptions which will break if the enum value changes. 2) DynamicPlatformRepositoryInfo structure has ArmCmObjList and ArmCmObjArray. With separate spaces for Arm, RiscV and Common, list management needs some redesign and I was not sure it is worth it. Hence, I thought a single list of all possible Obj Ids for all architectures and common things would be a good trade off. But I can go back to that approach in v2 if above issues are fine. Thanks! Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113511): https://edk2.groups.io/g/devel/message/113511 Mute This Topic: https://groups.io/mt/103622702/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-