From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F3C3F7803E0 for ; Tue, 23 Jan 2024 16:54:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ObrEJB90nDfzCW6FuuMbzFVP+3988Gyb/GNfNlCS/+I=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1706028887; v=1; b=qKjo9XXd5PrXHRtr2B22Hyc00kQB2MXlbjxVMd9P7W++/6OaWO+IMWyhEKccAeO0c2QUHbPU 5VBPSmQ3TbTaegpiGmm3lQfIqeFfzaNRLBasEE4l24oKJA3qgMVd8ekSUXRtDSlkitnjv6df3AQ wSWXje+czBEQ88Pa3o1xrtpw= X-Received: by 127.0.0.2 with SMTP id qfv1YY7687511xJRkSJsfMEk; Tue, 23 Jan 2024 08:54:47 -0800 X-Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by mx.groups.io with SMTP id smtpd.web11.18263.1706028886688589365 for ; Tue, 23 Jan 2024 08:54:46 -0800 X-Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-7bc32b0fdadso210453539f.2 for ; Tue, 23 Jan 2024 08:54:46 -0800 (PST) X-Gm-Message-State: 5yZC6RJrTvLWqF4u2ReYPsvlx7686176AA= X-Google-Smtp-Source: AGHT+IH1msKfx9DJJVZ3iXyMpwKY//7PmW03T9saLF95kgp5Y37JHev4EafWy46WRMnM6rX6FWY3xg== X-Received: by 2002:a92:c68e:0:b0:361:933c:7048 with SMTP id o14-20020a92c68e000000b00361933c7048mr118728ilg.118.1706028885870; Tue, 23 Jan 2024 08:54:45 -0800 (PST) X-Received: from sunil-laptop ([106.51.188.200]) by smtp.gmail.com with ESMTPSA id a17-20020a056638165100b0046f0123f26esm226181jat.86.2024.01.23.08.54.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 08:54:45 -0800 (PST) Date: Tue, 23 Jan 2024 22:24:37 +0530 From: "Sunil V L" To: Dhaval Sharma Cc: devel@edk2.groups.io, Liming Gao , Michael D Kinney , Zhiguang Liu , Andrei Warkentin , Laszlo Ersek , Pedro Falcato , Yang Cheng Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg/BaseCacheMaintenanceLib: RV64 replace asserts with logs Message-ID: References: <20240118095018.509362-1-dhaval@rivosinc.com> <20240118095018.509362-2-dhaval@rivosinc.com> MIME-Version: 1.0 In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=qKjo9XXd; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, Jan 23, 2024 at 11:42:57AM +0530, Dhaval Sharma wrote: > Sunil, > I thought "WriteBackDataCacheRange not supported" is more explicit over > "CMO not available". > Okay. > @Pedro Falcato For the example you mentioned, is > your concern more about someone not being able to notice the problem (that > the system is non-coherent) at the time of development and later ending up > with corrupted data during production? And you are suggesting that an > Assert helps address that problem by making that problem more visible to > the developer and a verbose warning does not? > > I can create a patch for CpuFlushCpuDataCache but I think we should avoid > CMO based return in there. Because in case of InvalidateDataCacheRange we > have an alternate implementation of fence in the absence of CMO. So it is > better to let riscvcache decide the right implementation. > The CpuDxe interface will be the wrapper. See Arm's implementation. Since CMO support is added now, the CpuDxe interface should be updated. Thanks, Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114218): https://edk2.groups.io/g/devel/message/114218 Mute This Topic: https://groups.io/mt/103805230/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-