From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D2E9C740032 for ; Tue, 23 Jan 2024 07:01:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=RI8VgnVjpPhPBKZzqEPpAc8zGzenUQgUO57qWTH2vUo=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20140610; t=1705993299; v=1; b=jLOnkwDtHWTQUCur7wYH2AwrCodC5L3gChSiFjSZcnpIruS8wI4Ie7f8hmzzRO+/V75Y9W9V dOdYba5o+owyJS+UU260er2r+EDPshqVvzBMM0EZVT1/9xNDWnPDNi18YfRlnZCul7UDCyjNNZC /Pl+kizPW75KbPwPW/o/NY4Y= X-Received: by 127.0.0.2 with SMTP id OoehYY7687511xKugu9FYs1z; Mon, 22 Jan 2024 23:01:39 -0800 X-Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by mx.groups.io with SMTP id smtpd.web10.6340.1705993298760903470 for ; Mon, 22 Jan 2024 23:01:38 -0800 X-Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-7bc3e297bc9so198413439f.3 for ; Mon, 22 Jan 2024 23:01:38 -0800 (PST) X-Gm-Message-State: ebswP7JnLWvhncoC3SHwtXBRx7686176AA= X-Google-Smtp-Source: AGHT+IGAOXliX8zZUUoRaibFPzAeqrhpJrXSiMBJiKx5p52OwuJN/R81jJIp6/zmP5pnQrj162BXng== X-Received: by 2002:a5d:88c7:0:b0:7bf:33a:3aa1 with SMTP id i7-20020a5d88c7000000b007bf033a3aa1mr6890889iol.35.1705993297891; Mon, 22 Jan 2024 23:01:37 -0800 (PST) X-Received: from sunil-laptop ([106.51.188.200]) by smtp.gmail.com with ESMTPSA id y6-20020a02ce86000000b0046eec9217cbsm734249jaq.164.2024.01.22.23.01.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 23:01:37 -0800 (PST) Date: Tue, 23 Jan 2024 12:31:27 +0530 From: "Sunil V L" To: Sami Mujawar Cc: Jeshua Smith , Pierre Gondois , "devel@edk2.groups.io" , Ard Biesheuvel , Leif Lindholm , Andrei Warkentin , Laszlo Ersek , AbdulLateef Attar , "Jeff Brasen (jbrasen@nvidia.com)" , Yeo Reum Yun , "Meenakshi Aggarwal (meenakshi.aggarwal@nxp.com)" , Girish Mahadevan , nd Subject: Re: [edk2-devel] [RFC PATCH v1 00/20] DynamicTablesPkg: Prepare to add RISC-V support Message-ID: References: <20240109162944.528006-1-sunilvl@ventanamicro.com> <6F2DEA68-0743-4676-BBF3-A8D8FA1AE32B@arm.com> MIME-Version: 1.0 In-Reply-To: <6F2DEA68-0743-4676-BBF3-A8D8FA1AE32B@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=jLOnkwDt; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Sami, On Mon, Jan 22, 2024 at 05:15:44PM +0000, Sami Mujawar wrote: > Hi All, > > DynamicTablesPkg currently supports Arm architecture, and we welcome the adoption by other architectures. > > Following is my proposal for moving forward. > > Goals: > - reuse common code > - streamline the adoption by other architectures > - minimise the impact on migration of the existing platforms > - maintain flexibility across architectural components > - use this opportunity to integrate Dynamic SMBIOS support > (Ref: https://edk2.groups.io/g/devel/message/107254) > > The following steps would help in achieving the goals: > 1. Create an edk2 staging branch. For the edk2-platforms updates, I will create a branch on my Github fork (note this is required as there is no staging repo for edk2-platforms). > 2. The design aspects and changes shall be discussed on the mailing list with patches to support the details. > 3. A new section in DynamicTablesPkg\Readme.md shall be added to reflect the design updates, e.g. changes to CM Objects, Namespace definitions, etc. > 4. The design changes should typically be supported by patches for the DynamicTables core framework and demonstrate the impact on the existing platform code by typically providing patches for at least one existing platform (possibly edk2-platforms/Platform/ARM/[Juno | FVP]). > 5. The design changes should be small and typically be reflected in separate patch series. > 6. The first phase would be to partition the codebase into common code vs architectural specific code. This would involve moving files and reflecting the associated changes such that the build does not break. > 7. Define a new namespace e.g. “ArchCommon” for the common architectural components. > 8. Identify the CM_ARM_OBJECTs that can be moved to the “ArchCommon” namespace. As part of this identify if any object needs to be dropped, e.g. EArmObjReserved29 > 9. Identify overlap of SMBIOS objects with existing CM Objects. > 10. Submit patches to move CM objects from Arm Namespace to ArchCommon Namespace. Ideally one object (and any dependencies) should be moved at a time. > 11. Submit patches to migrate upstream platforms that use DynamicTablesPkg > 12. Define a new namespace for RISCV specific objects > 13. Submit patches for enabling RISCV > 14. In the next phase support for Dynamic SMBIOS can be enabled. > > Notes: > a. Periodically rebase with edk2 & edk2-platforms master branch to sync with latest changes. > b. We can decide to merge the updates after point 11 above to edk2 & edk2-platforms master branch. > c. Similarly, the RISCV support can be merged after point 13. > > I will send out a request for creating the staging branch shortly. > This is great!. I think staging branches is a great idea considering the amount of changes this work needs. Thank you very much!. I can send small patch sets to partition the code base as per #6 along with documentation changes. Let me know once staging branches are created. Thanks! Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114181): https://edk2.groups.io/g/devel/message/114181 Mute This Topic: https://groups.io/mt/103622702/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-