From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 21268AC1316 for ; Thu, 11 Jan 2024 15:21:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2DDclIuDuYRG15Myc52lvmDXfQrQqoIKg28mpme46Qw=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1704986488; v=1; b=XP3qiP5vpIeMi/qpaU1Db3F5pRmHcAO+aDUtJCkVvvrUw0QwG77/krQwPrLJWSPmHFQ07RE6 1ssbQOIGs51DOuH6bjk/n5e5FUXamWQJL/tnU8DSmXkDETamjIFv94snMZlE9ECiolg303fQCX7 VwEFMiLokUZfAfDu3l6XRCV0= X-Received: by 127.0.0.2 with SMTP id FVyEYY7687511xklM4b07ROu; Thu, 11 Jan 2024 07:21:28 -0800 X-Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mx.groups.io with SMTP id smtpd.web11.13791.1704986488023082483 for ; Thu, 11 Jan 2024 07:21:28 -0800 X-Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1d3f8af8297so29328085ad.2 for ; Thu, 11 Jan 2024 07:21:27 -0800 (PST) X-Gm-Message-State: 8vQr3Kuqd2Q3tPCUYoNSpSoqx7686176AA= X-Google-Smtp-Source: AGHT+IHfwQqFPFb/Az0olK4nRVKpQxrwoYQav0OpdEAUGs1+qAq8dh/pW0OLH2406x2p7C1v7Vb4kA== X-Received: by 2002:a17:902:a38b:b0:1d4:638f:3ff2 with SMTP id x11-20020a170902a38b00b001d4638f3ff2mr1096943pla.43.1704986486559; Thu, 11 Jan 2024 07:21:26 -0800 (PST) X-Received: from sunil-laptop ([106.51.188.200]) by smtp.gmail.com with ESMTPSA id x12-20020a170902a38c00b001d4b1d190e3sm1315966pla.58.2024.01.11.07.21.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 07:21:26 -0800 (PST) Date: Thu, 11 Jan 2024 20:51:21 +0530 From: "Sunil V L" To: devel@edk2.groups.io, andrei.warkentin@intel.com Cc: Yang Wang , Ran Wang , Bamvor Jian ZHANG , "Gao, Liming" , "Kinney, Michael D" , "Liu, Zhiguang" Subject: Re: [edk2-devel] [PATCH v2] MdePkg/BaseLib:Fix boot DxeCore hang on riscv platform Message-ID: References: <63fe1c56bfa5d917d34c6ca9c5d85494385687bb.1703678382.git.wangyang@bosc.ac.cn> MIME-Version: 1.0 In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=XP3qiP5v; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, Jan 05, 2024 at 03:47:07PM +0000, Andrei Warkentin wrote: > Looks reasonable to me. > > Reviewed-by: Andrei Warkentin > > > -----Original Message----- > > From: Yang Wang > > Sent: Wednesday, December 27, 2023 8:57 PM > > To: Warkentin, Andrei ; devel@edk2.groups.io > > Cc: Yang Wang ; Ran Wang ; > > Bamvor Jian ZHANG ; Gao, Liming > > ; Kinney, Michael D > > ; Sunil V L ; Liu, > > Zhiguang > > Subject: [PATCH v2] MdePkg/BaseLib:Fix boot DxeCore hang on riscv platform > > > > For scene of > > HandOffToDxeCore()->SwitchStack(DxeCoreEntryPoint)-> > > InternalSwitchStack()->LongJump(),Variable HobList.Raw > > will be passed (from *Context1 to register a0) to > > DxeMain() in parameter *HobStart. > > > > However, meanwhile the function LongJump() overrides > > register a0 with a1 (-1) due to commit (ea628f28e5 "RISCV: Fix > > InternalLongJump to return correct value"), then cause hang. > > > > Replacing calling LongJump() with new InternalSwitchStackAsm() to pass > > addres data in register s0 to register a0 could fix this issue (just > > like the solution in MdePkg/Library/BaseLib/AArch64/SwitchStack.S) > > > > Signed-off-by: Yang Wang > > Reviewed-by: Ran Wang > > Cc: Bamvor Jian ZHANG > > Cc: Andrei Warkentin > > Cc: Liming Gao > > Cc: Michael D Kinney > > Cc: Sunil V L > > Cc: Zhiguang Liu > > --- Thanks for the patch!. Merged this as #5255 after fixing a minor formatting issue. Thanks, Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113624): https://edk2.groups.io/g/devel/message/113624 Mute This Topic: https://groups.io/mt/103395756/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-