From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4F353AC1323 for ; Fri, 12 Jan 2024 10:19:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5JyhwhCFzIdXIrBpKRSltTP5zlPpv+MRIiqVtkNMvbE=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1705054750; v=1; b=tWH/+MSCF/P5lG4l3+X7Nb/V7fJng7owyK1PgEiE7euvugeV1K5TE3CZcFXvMaQ28BxwIy9p tqGz4c+dhupbUZ1xPAw7FwjPRxuYsulUIq0bBUWsxR2y6YcJxVIFrQ4QNw+xbHhuBnmdi8SUNqD Y0pmzbYArth4JbDHxnkKWI1Q= X-Received: by 127.0.0.2 with SMTP id FMNHYY7687511xhgM0C1iFwm; Fri, 12 Jan 2024 02:19:10 -0800 X-Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mx.groups.io with SMTP id smtpd.web11.4179.1705054749788099945 for ; Fri, 12 Jan 2024 02:19:09 -0800 X-Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1d54b763d15so31777585ad.0 for ; Fri, 12 Jan 2024 02:19:09 -0800 (PST) X-Gm-Message-State: NZESVPTQI3nxKdJ8Wp4WRbVnx7686176AA= X-Google-Smtp-Source: AGHT+IENFR1zENs8G3Bv1VXdeG2+UXSVvg6HHNoRUnQutTuUDS92/tqr8Ty1EOkUhm6i5t9mrlUPug== X-Received: by 2002:a17:902:d485:b0:1d4:2266:64bf with SMTP id c5-20020a170902d48500b001d4226664bfmr674308plg.52.1705054749104; Fri, 12 Jan 2024 02:19:09 -0800 (PST) X-Received: from sunil-laptop ([106.51.188.200]) by smtp.gmail.com with ESMTPSA id kr4-20020a170903080400b001d36dbb22a9sm2782618plb.4.2024.01.12.02.19.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 02:19:08 -0800 (PST) Date: Fri, 12 Jan 2024 15:49:02 +0530 From: "Sunil V L" To: "Ni, Ray" Cc: "devel@edk2.groups.io" , "lichao@loongson.cn" , "Kinney, Michael D" , Laszlo Ersek , Gerd Hoffmann Subject: Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg Message-ID: References: MIME-Version: 1.0 In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="tWH/+MSC"; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Ray, On Fri, Jan 12, 2024 at 09:12:34AM +0000, Ni, Ray wrote: > Sunil, > I would like to hear your feedback regarding locations of following RiscV64 components in UefiCpuPkg: > * UefiCpuPkg/Library/BaseRiscV64CpuExceptionHandlerLib/ > * UefiCpuPkg/Library/BaseRiscV64CpuTimerLib/ > * UefiCpuPkg/CpuDxeRiscV64/ > * UefiCpuPkg/CpuTimerDxeRiscV64/ > > I would like to move them to the following new locations accordingly: > * UefiCpuPkg/Library/CpuExceptionHandlerLib/RiscV64/ > * UefiCpuPkg/Library/CpuTimerLib/RiscV64/ > * UefiCpuPkg/CpuDxe/RiscV64/ > * UefiCpuPkg/CpuTimerDxe/RiscV64/ > > > I want to avoid too many similar drivers in root folder, and too many libraries in Library folder. > > Movement of the first 3 ones put the RiscV components under existing folders. > Movement of the last one creates the UefiCpuPkg/CpuTimerDxe folder, that could be potentially shared by other archs as well. > > I raised similar comments to Chao Li who is working on LoongArch upstream. > > The location movement follows the 2nd pattern defined by edk2 coding standard: > Driver's location could be: > [[]] > or > [/[/]] > > Library's location could be: > > [[]][] > > or > > []/[[/]] > > Your proposal looks good to me except better to keep directory name as RiscV as in other packages. Thanks, Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113707): https://edk2.groups.io/g/devel/message/113707 Mute This Topic: https://groups.io/mt/103679850/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-