From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E4011740035 for ; Fri, 19 Jan 2024 18:57:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=97YPLgnKCN3Swq7/GjsX7I/ioloX9RF6/+kZETs7vlM=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1705690626; v=1; b=CVRkvgwOeUHGzB4NPNL43/meQ0I2JMPr8AnErdx1i4y25TeHNcHNhuPCssnlvPE8x2xjzt2m tnrZhIo5mqLQFRVC7ZN6zjxOComn6st6ecwZVtxkYNQf9ptVFzY+Ax9k7jZC6ZfpT7XpEIs0bng 0+fJ3cJhG404F4nncMYleItU= X-Received: by 127.0.0.2 with SMTP id yRVJYY7687511x0QI75QvJMc; Fri, 19 Jan 2024 10:57:06 -0800 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.2136.1705690625956786514 for ; Fri, 19 Jan 2024 10:57:06 -0800 X-Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40JITvs0023960; Fri, 19 Jan 2024 18:57:05 GMT X-Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vqvdu8bec-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Jan 2024 18:57:05 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40JIv5o4014452 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Jan 2024 18:57:05 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 19 Jan 2024 10:57:03 -0800 Date: Fri, 19 Jan 2024 18:57:00 +0000 From: "Leif Lindholm" To: , CC: Ard Biesheuvel , Graeme Gregory Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/SbsaQemu: update doc a bit Message-ID: References: <20240116180535.1524849-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 In-Reply-To: <20240116180535.1524849-1-marcin.juszkiewicz@linaro.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: ncF9EYv1iiBWwsM4Zi4IlJbN0YW7lOUO X-Proofpoint-ORIG-GUID: ncF9EYv1iiBWwsM4Zi4IlJbN0YW7lOUO Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Tq7GtyZpt0oHvthpnzogm3SWx7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CVRkvgwO; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, Jan 16, 2024 at 19:05:35 +0100, Marcin Juszkiewicz wrote: > We emulate XHCI controller already. No need to add it. > > Signed-off-by: Marcin Juszkiewicz > --- > Platform/Qemu/SbsaQemu/Readme.md | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platform/Qemu/SbsaQemu/Readme.md b/Platform/Qemu/SbsaQemu/Readme.md > index 3355adebd4c6..883535dfd20e 100644 > --- a/Platform/Qemu/SbsaQemu/Readme.md > +++ b/Platform/Qemu/SbsaQemu/Readme.md > @@ -113,9 +113,9 @@ Create a directory $WORKSPACE that would hold source code of the components. > ``` > $INSTALL_PATH/qemu-system-aarch64 -m 1024 -M sbsa-ref -pflash SBSA_FLASH0.fd -pflash SBSA_FLASH1.fd -serial stdio > ``` > - You can add XHCI controller with keyboard and mouse by: > + You can keyboard and mouse by: missing "add". I added that. Reviewed-by: Leif Lindholm Pushed as 82c4c4b03865. Thanks! / Leif > ``` > - -device qemu-xhci -device usb-mouse -device usb-kbd > + -device usb-mouse -device usb-kbd > ``` > You can add the hard drive to platform AHCI controller by `hda` parameter: > ``` > -- > 2.43.0 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114094): https://edk2.groups.io/g/devel/message/114094 Mute This Topic: https://groups.io/mt/103768126/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-