From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 40013941980 for ; Wed, 24 Jan 2024 14:34:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=PO99QrpgWGo5OTw7eXhic+GD8YVHBRJt6tJSXjx89o4=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20140610; t=1706106846; v=1; b=tHy/1CF5he42pH0jmhVcnlx4WwCuXsWHpN8dd+921bBAlRJXr90IWECMZNt9pii9DR1eJQ26 LroPmLV21pRmyuzTviaMaGfA26n8vs/35e3crXes7nikOVhST9LnbGTINgOJFYdqN3tUMmMwmwi /As69vRWtUtQxo5T+Hj6jgEk= X-Received: by 127.0.0.2 with SMTP id guU3YY7687511xEJ22KLsWho; Wed, 24 Jan 2024 06:34:06 -0800 X-Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by mx.groups.io with SMTP id smtpd.web11.24048.1706106845974761206 for ; Wed, 24 Jan 2024 06:34:06 -0800 X-Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-7beddc139c4so242023139f.0 for ; Wed, 24 Jan 2024 06:34:05 -0800 (PST) X-Gm-Message-State: mntZjYCLc7e96rzdiyRr9vsPx7686176AA= X-Google-Smtp-Source: AGHT+IFoPDDCUAs9SsVbvmKPIS3lOZT2uYhjQqik1KX4PV5YTCr0fXPUZxAca5uERdmel4450GJXaw== X-Received: by 2002:a6b:c884:0:b0:7bf:8a65:8069 with SMTP id y126-20020a6bc884000000b007bf8a658069mr1862389iof.7.1706106845210; Wed, 24 Jan 2024 06:34:05 -0800 (PST) X-Received: from sunil-laptop ([106.51.188.200]) by smtp.gmail.com with ESMTPSA id cd23-20020a0566381a1700b0046e4195769csm308806jab.79.2024.01.24.06.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 06:34:04 -0800 (PST) Date: Wed, 24 Jan 2024 20:03:57 +0530 From: "Sunil V L" To: Dhaval Sharma Cc: devel@edk2.groups.io, Liming Gao , Michael D Kinney , Zhiguang Liu , Andrei Warkentin , Laszlo Ersek , Pedro Falcato , Yang Cheng Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg/BaseCacheMaintenanceLib: RV64 replace asserts with logs Message-ID: References: <20240118095018.509362-1-dhaval@rivosinc.com> <20240118095018.509362-2-dhaval@rivosinc.com> MIME-Version: 1.0 In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="tHy/1CF5"; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Jan 24, 2024 at 07:57:27PM +0530, Dhaval Sharma wrote: > "The CpuDxe interface will be the wrapper." Yes, of course. It needs to be > added. I was just saying that maybe any CMO checking is not required there > as cmo library will take care of it. > That's correct. > On Tue, Jan 23, 2024 at 10:24 PM Sunil V L wrote: > > > On Tue, Jan 23, 2024 at 11:42:57AM +0530, Dhaval Sharma wrote: > > > Sunil, > > > I thought "WriteBackDataCacheRange not supported" is more explicit over > > > "CMO not available". > > > > > Okay. > > > > > @Pedro Falcato For the example you mentioned, > > is > > > your concern more about someone not being able to notice the problem > > (that > > > the system is non-coherent) at the time of development and later ending > > up > > > with corrupted data during production? And you are suggesting that an > > > Assert helps address that problem by making that problem more visible to > > > the developer and a verbose warning does not? > > > > > > I can create a patch for CpuFlushCpuDataCache but I think we should avoid > > > CMO based return in there. Because in case of InvalidateDataCacheRange we > > > have an alternate implementation of fence in the absence of CMO. So it is > > > better to let riscvcache decide the right implementation. > > > > > The CpuDxe interface will be the wrapper. See Arm's implementation. > > Since CMO support is added now, the CpuDxe interface should be updated. > > > > Thanks, > > Sunil > > > > > -- > Thanks! > =D -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114303): https://edk2.groups.io/g/devel/message/114303 Mute This Topic: https://groups.io/mt/103805230/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-