From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 693FBAC0C2B for ; Tue, 30 Jan 2024 05:52:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oJhM+nhsHhrPu87D34VYL1k9sqRHn9Pj9ibKEELuGYU=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1706593966; v=1; b=n05nZNxDDVLH40wz5aZFSYpqwBdWh/mMa/ZE8u0N+Rndb85vWASlynl4njrQVz5KFyrM1OLD s2v8hwNdxK9Cite+OhZQUhbAhE2B5QKYzsJnNcQojL1OLEx40+tE+JeNRwfhgrgLSkyn6zCUq8D XGTv1PhQhteuTbqxKwvHt360= X-Received: by 127.0.0.2 with SMTP id c2i2YY7687511xA2n4ctWjEc; Mon, 29 Jan 2024 21:52:46 -0800 X-Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by mx.groups.io with SMTP id smtpd.web10.12507.1706593965982999505 for ; Mon, 29 Jan 2024 21:52:46 -0800 X-Received: by mail-vs1-f43.google.com with SMTP id ada2fe7eead31-46b2230116dso557446137.2 for ; Mon, 29 Jan 2024 21:52:45 -0800 (PST) X-Gm-Message-State: 8eZVPwdqkHi2V2davrPppGFjx7686176AA= X-Google-Smtp-Source: AGHT+IF6C1UDWjlkdnbgjiKVKnNo9AqEWexxVbB4K/2cwHFNdxMsNrgYEKES/kq5kAeqXYInyAMLSA== X-Received: by 2002:a05:6102:311c:b0:46b:2041:ad1 with SMTP id e28-20020a056102311c00b0046b20410ad1mr2450492vsh.34.1706593964314; Mon, 29 Jan 2024 21:52:44 -0800 (PST) X-Received: from sunil-laptop ([106.51.190.212]) by smtp.gmail.com with ESMTPSA id k22-20020a02a716000000b00470b2cecc5esm1470609jam.105.2024.01.29.21.52.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 21:52:43 -0800 (PST) Date: Tue, 30 Jan 2024 11:22:36 +0530 From: "Sunil V L" To: devel@edk2.groups.io, dhaval@rivosinc.com Cc: Gerd Hoffmann , Laszlo Ersek , Rahul Kumar , Ray Ni , Sunil VL , Andrei Warkentin Subject: Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Add cache operations support for Arch proto Message-ID: References: <20240129040116.296175-1-dhaval@rivosinc.com> <20240129040116.296175-2-dhaval@rivosinc.com> MIME-Version: 1.0 In-Reply-To: <20240129040116.296175-2-dhaval@rivosinc.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=n05nZNxD; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Dhaval, Thank you very much for the patch!. On Mon, Jan 29, 2024 at 09:31:16AM +0530, Dhaval Sharma wrote: > With CMO operations available for RISC-V, utilize them in CPU > Architecture protocol. > > Signed-off-by: Dhaval Sharma > Gerd Hoffmann > Laszlo Ersek > Rahul Kumar > Ray Ni > Sunil VL > Andrei Warkentin > devel@edk2.groups.io You have missed adding "Cc:". Without this tag, they will not be copied explicitly. I am copying them in this reply and I will update the commit message during merge to fix it. > --- > UefiCpuPkg/CpuDxeRiscV64/CpuDxe.h | 1 + > UefiCpuPkg/CpuDxeRiscV64/CpuDxe.c | 14 ++++++++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/UefiCpuPkg/CpuDxeRiscV64/CpuDxe.h b/UefiCpuPkg/CpuDxeRiscV64/CpuDxe.h > index 68e6d038b66e..d4d67778eb1c 100644 > --- a/UefiCpuPkg/CpuDxeRiscV64/CpuDxe.h > +++ b/UefiCpuPkg/CpuDxeRiscV64/CpuDxe.h > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/UefiCpuPkg/CpuDxeRiscV64/CpuDxe.c b/UefiCpuPkg/CpuDxeRiscV64/CpuDxe.c > index 2af3b6223450..c6bae100a9e4 100644 > --- a/UefiCpuPkg/CpuDxeRiscV64/CpuDxe.c > +++ b/UefiCpuPkg/CpuDxeRiscV64/CpuDxe.c > @@ -90,6 +90,20 @@ CpuFlushCpuDataCache ( > IN EFI_CPU_FLUSH_TYPE FlushType > ) > { > + switch (FlushType) { > + case EfiCpuFlushTypeWriteBack: > + WriteBackDataCacheRange ((VOID *)(UINTN)Start, (UINTN)Length); > + break; > + case EfiCpuFlushTypeInvalidate: > + InvalidateDataCacheRange ((VOID *)(UINTN)Start, (UINTN)Length); > + break; > + case EfiCpuFlushTypeWriteBackInvalidate: > + WriteBackInvalidateDataCacheRange ((VOID *)(UINTN)Start, (UINTN)Length); > + break; > + default: > + return EFI_INVALID_PARAMETER; > + } > + > return EFI_SUCCESS; > } > Reviewed-by: Sunil V L -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114760): https://edk2.groups.io/g/devel/message/114760 Mute This Topic: https://groups.io/mt/104025802/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-