From: "Sunil V L" <sunilvl@ventanamicro.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
USER0FISH <libing1202@outlook.com>,
caiyuqing379 <caiyuqing_hz@outlook.com>,
dahogn <dahogn@hotmail.com>, meng-cz <mengcz1126@gmail.com>
Subject: Re: [edk2-devel] [edk2-platforms PATCH v2 4/4] SG2042Pkg/Sec: clean up ProcessLibraryConstructorList() decl
Date: Tue, 5 Mar 2024 19:37:23 +0530 [thread overview]
Message-ID: <ZecnG2ZlXi3hYMjd@sunil-laptop> (raw)
In-Reply-To: <20240305120126.70259-5-lersek@redhat.com>
On Tue, Mar 05, 2024 at 01:01:26PM +0100, Laszlo Ersek wrote:
> <Library/PeimEntryPoint.h> declares a bogus
> ProcessLibraryConstructorList() for the SG2042Pkg SEC module. Rely on
> AutoGen for (properly) declaring ProcessLibraryConstructorList(). Remove
> the correct, but superfluous, declaration as well.
>
> Build-tested with:
>
> build -a RISCV64 -b DEBUG -m Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf \
> -p Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc -t GCC5
>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: USER0FISH <libing1202@outlook.com>
> Cc: caiyuqing379 <caiyuqing_hz@outlook.com>
> Cc: dahogn <dahogn@hotmail.com>
> Cc: meng-cz <mengcz1126@gmail.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf | 2 +-
> Silicon/Sophgo/SG2042Pkg/Sec/SecMain.h | 12 ------------
> Silicon/Sophgo/SG2042Pkg/Sec/Memory.c | 1 -
> 3 files changed, 1 insertion(+), 14 deletions(-)
>
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116393): https://edk2.groups.io/g/devel/message/116393
Mute This Topic: https://groups.io/mt/104742763/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-05 14:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 12:01 [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 1/4] BeagleBoardPkg: auto-generate SEC ProcessLibraryConstructorList() decl Laszlo Ersek
2024-03-05 13:01 ` Ard Biesheuvel
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 2/4] SimicsOpenBoardPkg: auto-gen & fix " Laszlo Ersek
2024-03-06 21:10 ` Laszlo Ersek
2024-03-06 22:24 ` Michael D Kinney
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 3/4] LoongArchQemuPkg: " Laszlo Ersek
2024-03-05 13:05 ` Chao Li
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 4/4] SG2042Pkg/Sec: clean up " Laszlo Ersek
2024-03-05 14:07 ` Sunil V L [this message]
2024-03-08 9:20 ` [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZecnG2ZlXi3hYMjd@sunil-laptop \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox