From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2451A740034 for ; Wed, 3 Apr 2024 03:49:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KvY5s/WwDVSBfbGTr5cF3odXmDyUweXhkVyEc8FrXoE=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1712116147; v=1; b=YLiUzGvVYMkvf5VkQ6j5/S9j7Xz7J+QonVmGixaJjkC+g1h9nrr45I80vmLarIrFRqrfBzJR 2so65EyGG8q3TA/bvMxOfv7iUNNGgZc9baI+4mdfswXVpU/ejb4QO0PX27u9wkGKIsK5VYNR27r 2pnwwW7MEGPMXgN2FwUkytczwtbBgoPKtEWJpMD6oO2yeQHzPhHwW3eQCHvoJxTzuXL6gp9OAKJ xn5zTS2/2OM3cfZhVKPNyVvgcSk5Etb/HU5EegF8STBP4Yd53atSqCNmETKnqTtJAVbZXjw4Kam VPGHi4bPDK+w5eJtLeSjKKaGbmv1f06xHPn9L4LaYBMHQ== X-Received: by 127.0.0.2 with SMTP id NWtaYY7687511xmRMiWktie3; Tue, 02 Apr 2024 20:49:07 -0700 X-Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by mx.groups.io with SMTP id smtpd.web11.3115.1712116147006752461 for ; Tue, 02 Apr 2024 20:49:07 -0700 X-Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3c396fec63aso2254664b6e.0 for ; Tue, 02 Apr 2024 20:49:06 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWf7wJZVILWyoYK2PtFrJAQo7BiFu24L+q19p2/kOpGafWSUy/gF87vPqeJy+gSc+j9AJolFW4MqmKX6wbOOJN7OfkulQ== X-Gm-Message-State: 8oB1HFDyVxy7BDT2leVmWrKox7686176AA= X-Google-Smtp-Source: AGHT+IHhEARzDVyIuQ1xeVBuj7XCuT+DNuPhM2IVADDumQqO1EFzJtK6N7BiBff9tRr0Z2zThPkFGw== X-Received: by 2002:a05:6808:16a5:b0:3c3:ec6e:ad4e with SMTP id bb37-20020a05680816a500b003c3ec6ead4emr16823879oib.46.1712116146281; Tue, 02 Apr 2024 20:49:06 -0700 (PDT) X-Received: from sunil-laptop ([106.51.83.242]) by smtp.gmail.com with ESMTPSA id x19-20020a05680801d300b003c4f688d038sm329115oic.18.2024.04.02.20.49.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 20:49:05 -0700 (PDT) Date: Wed, 3 Apr 2024 09:18:59 +0530 From: "Sunil V L" To: Yang Wang Cc: caiyuqing_hz@outlook.com, devel@edk2.groups.io, USER0FISH , dahogn , meng-cz Subject: Re: [edk2-devel] [PATCH] SG2042Pkg/Sec:Modify Calculation LowestMemSize Message-ID: References: <20240325020928.2737-1-wangyang@bosc.ac.cn> MIME-Version: 1.0 In-Reply-To: <20240325020928.2737-1-wangyang@bosc.ac.cn> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 02 Apr 2024 20:49:07 -0700 Resent-From: sunilvl@ventanamicro.com Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=YLiUzGvV; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Mar 25, 2024 at 10:09:28AM +0800, Yang Wang wrote: > Adapting memory addresses may not start from 0x0, > for example, the starting memory address starts > from 0x8000_0000. > > I understand: LowestMemBase is the lowest DDR > address in the system. > > UefiMemoryBase = LowestMemBase + > CodeSize(opensbi+UEFI); > > LowestMemSize -= CodeSize(UefiMemoryBase - > LowestMemBase) > > Cc: Sunil V L > Cc: USER0FISH > Cc: caiyuqing379 > Cc: dahogn > Cc: meng-cz > > Signed-off-by: Yang Wang > --- > Silicon/Sophgo/SG2042Pkg/Sec/Memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c b/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c > index df49a17695..a160278eaa 100644 > --- a/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c > +++ b/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c > @@ -301,8 +301,8 @@ MemoryPeimInitialization ( > } > > if (UefiMemoryBase > LowestMemBase) { > + LowestMemSize -= (UefiMemoryBase - LowestMemBase); > LowestMemBase = UefiMemoryBase; > - LowestMemSize -= UefiMemoryBase; > } > LGTM. Jingyu, Do you mind adding RB tag? Reviewed-by: Sunil V L Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117341): https://edk2.groups.io/g/devel/message/117341 Mute This Topic: https://groups.io/mt/105131337/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-