From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6DC49AC108F for ; Fri, 21 Jun 2024 11:37:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3QMiwbpZSGJQ6xGIDvx3M4QWjOmP6s44e6JPCn2F444=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1718969852; v=1; b=GgbO7l7UvlT9cz3YOTTXDZndB4Agqoam2ymjCt/FMpNO0nbVoVDF7tznamcPZppTcAPidBy4 9sWWeOxu5G45ca4WVyj5kHT9Abp62YBVCuN6ahrvLdNmAY+JD/tZQZrZLacOEi9N+e7Guac886s fXX0EFaTTSAlb3LM7OVG5o+abzhLFoIB/pVY89mETaL+HDdHxM7gl+gMyWNMOj5AUrqTuIch5Nt b5+fJwPlCQP13YjUmQ3RFvWfvimdguuw2RirieV0VcJnayPk1pn11q4+9ip4DMeWOSuF8tuaDq4 ho1SkPsXMxdslERfXEaVwHyVnE5XEcHtsiR5WcdDMi3cQ== X-Received: by 127.0.0.2 with SMTP id 8YsjYY7687511x9xn5ipVMef; Fri, 21 Jun 2024 04:37:30 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.70827.1718969845392026196 for ; Fri, 21 Jun 2024 04:37:25 -0700 X-Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45L5pXsR024934; Fri, 21 Jun 2024 11:37:22 GMT X-Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3yvrkstg56-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jun 2024 11:37:21 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 45LBbKZD007780 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jun 2024 11:37:20 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 21 Jun 2024 04:37:16 -0700 Date: Fri, 21 Jun 2024 12:37:13 +0100 From: "Leif Lindholm" To: Ard Biesheuvel CC: , Ard Biesheuvel , Chuong Tran , Graeme Gregory , Marcin Juszkiewicz , Marcin Wojtas , Meenakshi Aggarwal , Narinder Dhillon , Nhi Pham , Rebecca Cran , Sami Mujawar , Thomas Abraham , Wenyi Xie Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz Message-ID: References: <20240620143243.460947-1-quic_llindhol@quicinc.com> MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: wu02zNprSFmUt9KUdWJUnyYFVppA8CVn X-Proofpoint-GUID: wu02zNprSFmUt9KUdWJUnyYFVppA8CVn Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 21 Jun 2024 04:37:25 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OoFXxzJDqsOPmFE2IQHbdQEFx7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=GgbO7l7U; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, Jun 20, 2024 at 16:43:00 +0200, Ard Biesheuvel wrote: > On Thu, 20 Jun 2024 at 16:33, Leif Lindholm wrote: > > > > Related to https://github.com/tianocore/edk2/pull/5797 > > > > PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete. > > Its functionality has been partially broken, and mostly ignored, for > > all AArch64 platforms since December 2020. > > > > This set cleans up some broken line endings in .dsc* files, then > > drops all non-invasive references to the Pcd: > > - .dsc* files setting it to 0 (which is the default in the definition, > > and means "just read it from the system register instead") > > - .inf files declaring a dependency that is in fact not there in > > current code. > > > > Finally, it drops the setting of the Pcd for platforms that set it to > > non-0. This has *never* done the right thing on these platforms since > > they are all AArch64, but it may affect timer timeout, so deserves > > deeper testing. > > > > Cc: Ard Biesheuvel > > Cc: Chuong Tran > > Cc: Graeme Gregory > > Cc: Marcin Juszkiewicz > > Cc: Marcin Wojtas > > Cc: Meenakshi Aggarwal > > Cc: Narinder Dhillon > > Cc: Nhi Pham > > Cc: Rebecca Cran > > Cc: Sami Mujawar > > Cc: Thomas Abraham > > Cc: Wenyi Xie > > > > Leif Lindholm (5): > > Platform/SbsaQemu: fix .dsc line endings > > Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz > > Platform/ARM: drop use of PcdArmArchTimerFreqInHz > > Platform/Hisilicon: drop D05 use of PcdArmArchTimerFreqInHz > > Silicon/Marvell: drop use of PcdArmArchTimerFreqInHz > > > > Looks fine to me > > Reviewed-by: Ard Biesheuvel Thanks! Since 1-2 are just cleanup, I have now pushed those two commits, with R-b:s given, as 3f08401365d6..b29e69a688d6. I am tempted to now merge https://github.com/tianocore/edk2/pull/5797, at which point the platforms affected by 3-5 will break. Any objection? / Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119670): https://edk2.groups.io/g/devel/message/119670 Mute This Topic: https://groups.io/mt/106780872/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-