From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id B3648D80220 for ; Fri, 21 Jun 2024 13:54:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=iSNeRFPZDnepnxc2i+xKnmNxaGEWv7dcxX7IClCsQPI=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1718978053; v=1; b=CiWtkHAoRS69S95BIT6a6xynITsdcQaGJQ/UJXpI2/tdbSEN35Ehu93PIpgIjsAXgR/KbO/k mepY5R3RioI2uGNVoYpxSfWt9wPX8GT6HcOmYoqBqXTNOpDDp4a7jYlL6jRSsLYITcCx9z1jccu j+M4/Nmck4rmy5oGzgzgy8X+mlUY3zh1eW70KtCFjv2C7NCLG3zzgqqjimm4kI1s4naQu53vUxn jqagrXJpyyK7cHkjrCnLoie8nvgU1A08/Lk0NJ4pDN2iJhATQFfSpa+6j6kIwuiLGh02dpIyUfq P4PKk20rc2lTKFGuDNsQVqI1rJUP3SXXy9nf5SYEnAuIQ== X-Received: by 127.0.0.2 with SMTP id rR0tYY7687511x31RXKfs9r8; Fri, 21 Jun 2024 06:54:12 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.73639.1718978051152910879 for ; Fri, 21 Jun 2024 06:54:11 -0700 X-Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45L8i624021513; Fri, 21 Jun 2024 13:54:10 GMT X-Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3yw6920ppn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jun 2024 13:54:10 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 45LDs9pA002413 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jun 2024 13:54:09 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 21 Jun 2024 06:54:07 -0700 Date: Fri, 21 Jun 2024 14:54:04 +0100 From: "Leif Lindholm" To: Marcin Juszkiewicz CC: , Ard Biesheuvel , Michael Kubacki Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: reformat all sources using uncrustify Message-ID: References: <20240621133901.88152-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 In-Reply-To: <20240621133901.88152-1-marcin.juszkiewicz@linaro.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: FtDa3fOQbs55b1DqVepKOT0EL0diGUMP X-Proofpoint-GUID: FtDa3fOQbs55b1DqVepKOT0EL0diGUMP Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 21 Jun 2024 06:54:11 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 2aFPRMsg3XfEvztvyj5vwWWwx7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=CiWtkHAo; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none) On Fri, Jun 21, 2024 at 15:39:01 +0200, Marcin Juszkiewicz wrote: > uncrustify is required in EDK2 repository. SbsaQemu (and other platforms > in edk2-platforms) code was free from using it IIRC. > > Reformat all files to make new contributions easier. We can recommend > formatting sources without generating extra work for developers. > > Signed-off-by: Marcin Juszkiewicz Everything in here except one thing is improvement. > --- > .../Include/Library/QemuOpenFwCfgLib.h | 7 +- > .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.h | 50 +- > .../Include/IndustryStandard/SbsaQemuAcpi.h | 86 +-- > .../SbsaQemuPlatformVersion.h | 2 +- > .../Include/IndustryStandard/SbsaQemuSmc.h | 14 +- > .../Include/Library/HardwareInfoLib.h | 8 +- > .../BoardBootManagerLib/BoardBootManager.c | 14 +- > .../Library/PeiReportFvLib/PeiReportFvLib.c | 237 ++++----- > .../QemuOpenBoardPkg/PlatformInitPei/Memory.c | 4 +- > .../Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 78 +-- > .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 490 +++++++++--------- > .../SbsaQemuHighMemDxe/SbsaQemuHighMemDxe.c | 8 +- > .../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 88 ++-- > .../SbsaQemuSmbiosDxe/SbsaQemuSmbiosDxe.c | 94 ++-- > .../SbsaQemuHardwareInfoLib.c | 66 +-- > .../Library/SbsaQemuLib/SbsaQemuLib.c | 23 +- > .../Library/SbsaQemuLib/SbsaQemuMem.c | 49 +- > .../SbsaQemuNorFlashLib/SbsaQemuNorFlashLib.c | 14 +- > .../SbsaQemuPciHostBridgeLib.c | 90 ++-- > 19 files changed, 735 insertions(+), 687 deletions(-) > > --- a/Platform/Qemu/QemuOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.c > +++ b/Platform/Qemu/QemuOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.c > @@ -16,7 +16,7 @@ > #include > > // Use a FV pointer PCD to get a pointer to the FileSystemGuid in the FV header > -#define PCD_TO_FV_HEADER_FILE_SYSTEM_GUID(Pcd) (&((EFI_FIRMWARE_VOLUME_HEADER *)(UINTN) PcdGet32 (Pcd))->FileSystemGuid) > +#define PCD_TO_FV_HEADER_FILE_SYSTEM_GUID(Pcd) (&((EFI_FIRMWARE_VOLUME_HEADER *)(UINTN) PcdGet32 (Pcd))->FileSystemGuid) > > /** > Reports FVs necessary for MinPlarform pre-memory initialization > @@ -38,13 +38,14 @@ ReportPreMemFv ( > > DEBUG_CODE ( > for (Index = 0; Status == EFI_SUCCESS; Index++) { > - Status = PeiServicesLocatePpi (&gEfiPeiFirmwareVolumeInfo2PpiGuid, Index, &Descriptor, (VOID**) &Ppi); > - if (!EFI_ERROR (Status)) { > - FvHeader = (EFI_FIRMWARE_VOLUME_HEADER*) Ppi->FvInfo; > - DEBUG ((DEBUG_INFO, "Found FV at 0x%x, size 0x%x\n", FvHeader, FvHeader->FvLength)); > - } > + Status = PeiServicesLocatePpi (&gEfiPeiFirmwareVolumeInfo2PpiGuid, Index, &Descriptor, (VOID **)&Ppi); > + if (!EFI_ERROR (Status)) { > + FvHeader = (EFI_FIRMWARE_VOLUME_HEADER *)Ppi->FvInfo; > + DEBUG ((DEBUG_INFO, "Found FV at 0x%x, size 0x%x\n", FvHeader, FvHeader->FvLength)); Uncrustify gets this hunk wrong. > } > - ); > + } > + > + ); And this too. Michael, do you have any known tweaks for this format? Marcin, since the point was to clean up SbsaQemu, maybe you could re-run this without including QemuOpenBoardPkg? Regards, Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119672): https://edk2.groups.io/g/devel/message/119672 Mute This Topic: https://groups.io/mt/106798688/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-