Re: [edk2-devel] [PATCH edk2-platforms 4/4] Silicon/RiscVOpensbiLib: fix submodule version

["Sunil V L" <sunilvl@ventanamicro.com>]

On Tue, Jun 25, 2024 at 10:07:37AM +1000, Alistair Francis wrote:
> On Mon, Jun 24, 2024 at 11:33 PM Leif Lindholm via groups.io
> <quic_llindhol=quicinc.com@groups.io> wrote:
> >
> > Commit 4f32c34865de,
> > ("Platform/AMD: Initial commit of cross platform/board interfaces")
> > presumably by accident reverts the opensbi submodule update done in
> > commmit 2d8289634ec9 ("ProcessorPkg/opensbi: Update opensbi library").
> >
> > Correct this and restore the submodule version.
> >
> > Cc: Daniel Schaefer <git@danielschaefer.me>
> > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
> > ---
> >  Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi b/Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi
> > index 937caee08331..a731c7e36988 160000
> > --- a/Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi
> > +++ b/Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi
> > @@ -1 +1 @@
> > -Subproject commit 937caee0833115f69d697ca190001ba0aa5c7368
> > +Subproject commit a731c7e36988c3308e1978ecde491f2f6182d490
> 
> While this is being updated why not just update to the latest 1.4 release?
> 
> This commit is 3 years old and not an official release (it's not even 1.0)
> 
Hi Alistair,

The plan is to obsolete this and move to payload based design. All new
platforms including qemu virt are already using the payload design.
Upgrading opensbi in EDK2 is not a trivial effort.

Thanks,
Sunil


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119703): https://edk2.groups.io/g/devel/message/119703
Mute This Topic: https://groups.io/mt/106849456/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-