From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6D04B780091 for ; Tue, 9 Jul 2024 15:03:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZTj/fltkWbrYSoxLupOSOAlA6N4YBSkzCdyagetAjr0=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20240206; t=1720537419; v=1; b=QrEKpa5g5SAiTUC/OvltKU2zV15wJTYhUPDGYc/ivPhwNJuGy2Zg3e8n76td+THBGKvjzlvi dQ28QAMn/SSpwxysVhnGOPzHYSlZQ0aEqMl8XtHUtqiWw+rWWBtgJgFvCFpBWLgsnLkMZPIXF3X 3YVlrhjmvRiNbUWQn7QjSOc+uH/WxyWrc5LMUZcz793oqhZIHJGH6MvRwPZ06s4tV1vkwgqoOBV dMgt4OUBqnjk+bZV4a46Ai0VJOxuEQhJxqv11dWqozvb0bmPcAP69nT8+Dv3hgv/XnJlY+1lYNK zJy3rOhRmdMTnGQ1RVuoCltzHoCP6zGXyV+neMcGl6Ylw== X-Received: by 127.0.0.2 with SMTP id 83xeYY7687511xqYrBMSUkuz; Tue, 09 Jul 2024 08:03:37 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.454.1720537416970863909 for ; Tue, 09 Jul 2024 08:03:37 -0700 X-Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4699v4gZ000478; Tue, 9 Jul 2024 15:03:36 GMT X-Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 406wgwprtb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jul 2024 15:03:35 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 469F3YTR014137 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 9 Jul 2024 15:03:34 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 9 Jul 2024 08:03:33 -0700 Date: Tue, 9 Jul 2024 16:03:30 +0100 From: "Leif Lindholm" To: , CC: "discuss@edk2.groups.io" , "Kinney, Michael D" Subject: Re: [edk2-devel] github impact:breaking-change Message-ID: References: <4f3b1520-065f-4f43-9950-162cbdc0266a@quicinc.com> <8f418b6d-c3d3-49b9-ab90-3e1acb0b880a@linux.microsoft.com> MIME-Version: 1.0 In-Reply-To: <8f418b6d-c3d3-49b9-ab90-3e1acb0b880a@linux.microsoft.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: D5TGfIsWmfcBpZ8dFvqjnralNGUgs6T6 X-Proofpoint-ORIG-GUID: D5TGfIsWmfcBpZ8dFvqjnralNGUgs6T6 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 4699v4gZ000478 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 09 Jul 2024 08:03:37 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: blfDkpuVsjQ0zYUTXj5Twbd4x7686176AA= Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=QrEKpa5g; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Michael, On Tue, Jul 09, 2024 at 10:44:46 -0400, Michael Kubacki wrote: > Hi Leif, >=20 > Thanks for raising this. The label was intended to be set from the PR > template which has an explanation: >=20 > https://github.com/tianocore/edk2/blob/master/.github/pull_request_templa= te.md >=20 > If the breaking change box is checked, it will be added automatically. Right, so it seems some people have misunderstood the description in the template. The current text is "Breaking change - Will this cause a break in build or boot behavior?" I raised https://github.com/tianocore/edk2/pull/5895 for some minor language tweaks that hopefully reduce the risk of misinterpretation. > I added a description in GitHub for the label as well: >=20 > https://github.com/tianocore/edk2/labels Thanks! Regards, Leif >=20 > Thanks, > Michael >=20 > On 7/8/2024 7:00 AM, Leif Lindholm wrote: > > Hi, > >=20 > > I'm seeing something in several PRs in flight (and merged) that have > > "impact:breaking-change" set, where the purpose of the PR is to fix sai= d > > breakage, not introduce API compatibilities. > >=20 > > Am I correct in my understanding that this is not the intended use, and > > if so how do we address the misconception? > > Can we start by adding a description for the label? It currently has no= ne. > >=20 > > Mu uses "Requires integration attention", which matches my > > understanding, but feels a bit abstract. How about > > "This change breaks existing APIs" > > or > > "This change may require corresponding updates to code in other > > repositories"? > >=20 > > / > > =A0=A0=A0 Leif >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119851): https://edk2.groups.io/g/devel/message/119851 Mute This Topic: https://groups.io/mt/107100295/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-