From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id D1628D811B1 for ; Wed, 10 Jul 2024 14:33:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=zAeQhXYHn/RLEkoIPLTYGxac2ypRrxKmN0VJaCwKCiQ=; c=relaxed/simple; d=groups.io; h=Date:From:To:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20240206; t=1720621994; v=1; b=XVZpymistwHZu0pWLSPuMq46MqeGCIj5ZGc/2biYRJsqGNm2co+37OM2CmrXYe+jdvLWq4e7 y6LjXCLTgrNahv3JwoyerVPCeoaRUW1TdP1an9hidT2aOBh6EXdGlJ1wsQrZkkPTuQExMJlkwUO +1hqLPLPSexTYt1i5CpR4ihbwmg/eoNvG2lkvvWIdyYyP4S/hp6L2FHqJqsQywp73olxoLABvXS e2WyOHbQE0144XO7xW30MASvGsle7LuXWmi1pimKdKM56O37bUYifhRaQHYAOVmGkzFeh2VGLzQ ICEn3JTGo6Zj/Bv092pwoBg7wmZa4kAIoncKQTuUu7qAg== X-Received: by 127.0.0.2 with SMTP id wCLhYY7687511xMavMtLrgit; Wed, 10 Jul 2024 07:33:13 -0700 X-Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by mx.groups.io with SMTP id smtpd.web10.16019.1720621992766350087 for ; Wed, 10 Jul 2024 07:33:12 -0700 X-Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-250ca14422aso3486098fac.0 for ; Wed, 10 Jul 2024 07:33:12 -0700 (PDT) X-Gm-Message-State: 0Z330e96a9xJS4ESHKEeXaLax7686176AA= X-Google-Smtp-Source: AGHT+IEdy7/qKi7zU9b24JwBebNMqpAXZWdlhOK6DxXNsPtepnUqJSzQmL3LqUqDfljKn3HSjzSwyQ== X-Received: by 2002:a05:6870:e2c9:b0:23d:a1d0:7334 with SMTP id 586e51a60fabf-25eae7ee4a0mr4544446fac.17.1720621991378; Wed, 10 Jul 2024 07:33:11 -0700 (PDT) X-Received: from sunil-laptop ([106.51.187.237]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-70374fcbe1csm850526a34.72.2024.07.10.07.33.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 07:33:10 -0700 (PDT) Date: Wed, 10 Jul 2024 20:03:05 +0530 From: "Sunil V L" To: devel@edk2.groups.io, evan.chai@linux.alibaba.com Subject: =?UTF-8?B?UmU6IFtlZGsyLWRldmVsXSDovazlj5HvvJpbZWRrMi1kZXZlbF0gW1BBVENIIFYyIDAvMl0gSW5pdGlhbCBjb21taXQgZm9yIFJJU0MtViBRZW11LWJhc2VkIFNlcnZlcg==?= Message-ID: References: <28726.1720602861709569726@groups.io> MIME-Version: 1.0 In-Reply-To: <28726.1720602861709569726@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 10 Jul 2024 07:33:12 -0700 Resent-From: sunilvl@ventanamicro.com Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=XVZpymis; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none Hi Evan, On Wed, Jul 10, 2024 at 02:14:21AM -0700, EvanChai via groups.io wrote: > Hi Sunil, > I just saw two comments below. > 'These images are generic. I don't think we need to have a copy here. Ifyou need to refer to this in any documentation, please add the link tooriginal image/document.' > ‘It is better to split these documentation changes to a separate commit.’ > Oh OK. At high level, here is my feedback. 1) It is wonderful that you have added lot of details including design of qemu, todo etc. However, I think it is better to keep Readme simple and provide a reference to RISE wiki page where you can add all these details. That way, we can avoid having stale data in Readme or need to do several patches for updates. Better to keep readme with just build and test instructions and a link to more details. For example, adding qemu design (ex: memory map) in edk2 readme. Every time qemu design changes, the edk2 readme becomes stale and keeping them in sync may not be productive. 2) Please split documentation changes (readme) and platform changes (dsc etc) to separate commits. 3) In the latest series, I see you have 2 commits where first commit adds .inc file and in the next commit itself it gets removed. I see no reason to do so. 4) Why would .inc files cause fragmentation? Rather, I think a common .inc (qemu and real servers) will reduce the effort and copying same for several platforms. 5) I have few more comments on the contents of readme as well. But if it can be moved to wiki, we can discuss and correct there. > BTW, the only uploaded picture comes from my presentation on the RV server platform proposal. It doesn't have an online source because I drew it myself. Do you have any recommended places where I can upload it? Then we can just reference its link in the README. > My recommendation is to keep them in RISE wiki for now. Thanks, Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119866): https://edk2.groups.io/g/devel/message/119866 Mute This Topic: https://groups.io/mt/107121708/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-