From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 31F35AC11E4 for ; Tue, 23 Jul 2024 15:32:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nBQjdhwqIDZRgq+P035fJXrqHBGw/nVPc6mrRy0I5VQ=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1721748762; v=1; b=YkF9KP4P7/VBseBSNkjY1AYJudRWgNtmahzHJ7FA+Dmxk6pOtp/fl7886RgERG92j8kMpn9z leh/orgCC1yw7XJUwiZiTMvgPyn86Zon2sDDoP7v30LS95Cn2Bbcck6TIBt56zReKP6w+5tG/4x mB77uehnjMV2fUFX5tEqGA/aQtq2U8Jwb7E3doG5Ci0r4CWzzvT94yWrZOmvjNL+OR7JlE86Xi5 D4HZrVQ9MK7wSoIojzSDevBXLdfx8WvFyRlKaySv715ABlxU/zpc28FfPTSZgAHBFtdYdItdg8E XBzHCxmp/QVJlVcEgPiUIiBCOqEnyhs2PLXdaXliLTXtw== X-Received: by 127.0.0.2 with SMTP id tglcYY7687511xcnjXtcYuB6; Tue, 23 Jul 2024 08:32:41 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.94.1721748760484564486 for ; Tue, 23 Jul 2024 08:32:40 -0700 X-Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46N9DW7d016912; Tue, 23 Jul 2024 15:32:39 GMT X-Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 40g5m6yekt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Jul 2024 15:32:39 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 46NFWc6F012397 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Jul 2024 15:32:38 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 23 Jul 2024 08:32:35 -0700 Date: Tue, 23 Jul 2024 16:32:32 +0100 From: "Leif Lindholm" To: Ard Biesheuvel CC: , Ard Biesheuvel , Oliver Smith-Denny , Rebecca Cran , Nhi Pham , Chuong Tran , Peng Xie , Ling Jia , Yiqi Shu Subject: Re: [edk2-devel] [PATCH edk2-platforms 3/4] Platform/Ampere: Switch to generic ResetRuntime DXE driver Message-ID: References: <20240721145155.324900-1-ardb+git@google.com> <20240721145155.324900-4-ardb+git@google.com> MIME-Version: 1.0 In-Reply-To: <20240721145155.324900-4-ardb+git@google.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: _w3zfJTFWtW3pqFMOjoQf1U5FjvbQHv_ X-Proofpoint-ORIG-GUID: _w3zfJTFWtW3pqFMOjoQf1U5FjvbQHv_ Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 23 Jul 2024 08:32:40 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: GetW2JXqfmBmGK6gNW9l0zVxx7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=YkF9KP4P; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Sun, Jul 21, 2024 at 16:51:54 +0200, Ard Biesheuvel wrote: > From: Ard Biesheuvel > > The reset runtime DXE driver is deprecated and will be removed soon. It > is superseded by a generic implementation in MdeModulePkg, which is > shared between all architectures, and implements the notification > protocols that the EFI spec describes. So move the Ampere Jade platform > to this implementation the of ResetSystem EFI runtime service. > > Signed-off-by: Ard Biesheuvel > --- > Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 3 +-- > Platform/Ampere/JadePkg/Jade.fdf | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > index 1f705c68579a..fb170d436d00 100644 > --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > @@ -259,7 +259,6 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > !endif > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > > - EfiResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf Would it make sense to move the existing ResetSystemLib mapping here? Not for any particular reason other than it's not actually used anywhere else. Regardless, for the series: Reviewed-by: Leif Lindholm Thanks! > ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf > NVParamLib|Silicon/Ampere/AmpereAltraPkg/Library/NVParamLib/RuntimeNVParamLib.inf > AmpereCpuLib|Silicon/Ampere/AmpereAltraPkg/Library/AmpereCpuLib/RuntimeAmpereCpuLib.inf > @@ -588,7 +587,7 @@ [Components.common] > !endif > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf > - EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf > + MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf > EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > diff --git a/Platform/Ampere/JadePkg/Jade.fdf b/Platform/Ampere/JadePkg/Jade.fdf > index 7795f0e11115..127e4401f69b 100644 > --- a/Platform/Ampere/JadePkg/Jade.fdf > +++ b/Platform/Ampere/JadePkg/Jade.fdf > @@ -222,7 +222,7 @@ [FV.FvMain] > INF SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf > !endif > INF MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf > - INF EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf > + INF MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf > INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > INF EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > -- > 2.45.2.1089.g2a221341d9-goog > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120014): https://edk2.groups.io/g/devel/message/120014 Mute This Topic: https://groups.io/mt/107476835/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-