Re: [edk2-devel] [PATCH edk2-platforms v2 0/8] RPi: Drop EmbeddedPkg reset runtime

["Leif Lindholm" <quic_llindhol@quicinc.com>]

On Sun, Jul 28, 2024 at 22:44:27 +0200, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
> 
> The EmbeddedPkg runtime DXE is being retired in favour of the generic
> one in MdeModulePkg which is actually being maintained.
> 
> RPi uses this driver and the associated EfiResetSystemLib, of which it
> has an implementation with value-add for reset notification. So this
> logic needs to be moved elsewhere and hooked up to the generic protocols
> that implement the same.
> 
> Changes since v1:
> - boot tested
> - add patch to fix pre-existing issue that causes a crash when DmaLib
>   attempts to set EFI_MEMORY_XP on allocated buffers
> - add a patch to force the correct dispatch order for the varstore
>   related drivers
> - fix line endings

For the added commits:
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>


> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Jeremy Linton <jeremy.linton@arm.com>
> 
> Ard Biesheuvel (8):
>   Platform/RaspberryPi: Mark RAM regions as write/execute protectable
>   Platform/RaspberryPi: Fix line endings in DSCs
>   Platform/RaspberryPi: Use depex based dispatch order for varstore
>   Platform/RaspberryPi/VarBlockServiceDxe: Refactor DumpVars event
>     handler
>   Platform/RaspberryPi/VarBlockServiceDxe: Register for reset
>     notification
>   Platform/RaspberryPi/PlatformBootManagerLib: Reimplement reset hook
>   Platform/RaspberryPi: Switch to generic reset runtime
>   Platform/RaspberryPi: Drop platform specific EfiResetSystemLib
> 
>  Platform/RaspberryPi/RaspberryPi.dec                                           |   1 -
>  Platform/RaspberryPi/RPi3/RPi3.dsc                                             |  15 +-
>  Platform/RaspberryPi/RPi4/RPi4.dsc                                             |  15 +-
>  Platform/RaspberryPi/RPi3/RPi3.fdf                                             |   2 +-
>  Platform/RaspberryPi/RPi4/RPi4.fdf                                             |   2 +-
>  Platform/RaspberryPi/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf         |   6 +-
>  Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf |   6 +
>  Platform/RaspberryPi/Library/ResetLib/ResetLib.inf                             |  45 ------
>  Platform/RaspberryPi/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.c           |  65 ++++++---
>  Platform/RaspberryPi/Library/MemoryInitPeiLib/MemoryInitPeiLib.c               |   2 +
>  Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c               |  77 ++++++++++
>  Platform/RaspberryPi/Library/ResetLib/ResetLib.c                               | 151 --------------------
>  12 files changed, 156 insertions(+), 231 deletions(-)
>  delete mode 100644 Platform/RaspberryPi/Library/ResetLib/ResetLib.inf
>  delete mode 100644 Platform/RaspberryPi/Library/ResetLib/ResetLib.c
> 
> --
> 2.46.0.rc1.232.g9752f9e123-goog
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120075): https://edk2.groups.io/g/devel/message/120075
Mute This Topic: https://groups.io/mt/107626473/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-