From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5AB2A941A6B for ; Tue, 30 Jul 2024 12:40:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=4Av+rnYKXi+MQEg5gyF5jvz0j9ru+NFeBmUDTBG1dcY=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1722343238; v=1; b=OnsAQJHNNjoic2m2Z758IFImnW6N7jrCLY2zUeiWSyiqqeTbFv3yZa/DYeNURl+/TgPDopBR h1reJYG0ARwmhuCPld0j5bO8waE8X6GbWGDnNjbJ3IBF42TJVeaPPJFZyTq7IIXqYjd+CgLZPet Yif2X/2bt8z01phOMd/BJHaKtNU3+S9MWw16J0VxBD77rW8Cojz0anKV8Uu4DhsWHfxIdoM2q2f xXWIMz5sHtBxWMeRT2Z1LIAPMgUzEospn8kuOqEghPHd8KT6+KTogRzUeU2NXPIrAXwiifieV8X J+Gq4DM9bK8JyRQnR+NlMe9cvSuGLuY10TlBUi6IYkYbw== X-Received: by 127.0.0.2 with SMTP id LZQpYY7687511xRoIaLaqTTK; Tue, 30 Jul 2024 05:40:36 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.16544.1722343236013661077 for ; Tue, 30 Jul 2024 05:40:36 -0700 X-Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46U8uv6V024000; Tue, 30 Jul 2024 12:40:33 GMT X-Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 40pw450kf8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Jul 2024 12:40:33 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 46UCeMFo012905 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Jul 2024 12:40:22 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 30 Jul 2024 05:40:21 -0700 Date: Tue, 30 Jul 2024 13:40:18 +0100 From: "Leif Lindholm" To: Ard Biesheuvel CC: , Ard Biesheuvel , Jeremy Linton Subject: Re: [edk2-devel] [PATCH edk2-platforms v2 0/8] RPi: Drop EmbeddedPkg reset runtime Message-ID: References: <20240728204437.4064847-1-ardb+git@google.com> MIME-Version: 1.0 In-Reply-To: <20240728204437.4064847-1-ardb+git@google.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: FJRTroFCdctgNbS7Fga7sS5o8w8SXnKs X-Proofpoint-ORIG-GUID: FJRTroFCdctgNbS7Fga7sS5o8w8SXnKs Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 30 Jul 2024 05:40:36 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: wRE4anipgiSP14kbH1vyHPOux7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=OnsAQJHN; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Sun, Jul 28, 2024 at 22:44:27 +0200, Ard Biesheuvel wrote: > From: Ard Biesheuvel > > The EmbeddedPkg runtime DXE is being retired in favour of the generic > one in MdeModulePkg which is actually being maintained. > > RPi uses this driver and the associated EfiResetSystemLib, of which it > has an implementation with value-add for reset notification. So this > logic needs to be moved elsewhere and hooked up to the generic protocols > that implement the same. > > Changes since v1: > - boot tested > - add patch to fix pre-existing issue that causes a crash when DmaLib > attempts to set EFI_MEMORY_XP on allocated buffers > - add a patch to force the correct dispatch order for the varstore > related drivers > - fix line endings For the added commits: Reviewed-by: Leif Lindholm > Cc: Leif Lindholm > Cc: Jeremy Linton > > Ard Biesheuvel (8): > Platform/RaspberryPi: Mark RAM regions as write/execute protectable > Platform/RaspberryPi: Fix line endings in DSCs > Platform/RaspberryPi: Use depex based dispatch order for varstore > Platform/RaspberryPi/VarBlockServiceDxe: Refactor DumpVars event > handler > Platform/RaspberryPi/VarBlockServiceDxe: Register for reset > notification > Platform/RaspberryPi/PlatformBootManagerLib: Reimplement reset hook > Platform/RaspberryPi: Switch to generic reset runtime > Platform/RaspberryPi: Drop platform specific EfiResetSystemLib > > Platform/RaspberryPi/RaspberryPi.dec | 1 - > Platform/RaspberryPi/RPi3/RPi3.dsc | 15 +- > Platform/RaspberryPi/RPi4/RPi4.dsc | 15 +- > Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +- > Platform/RaspberryPi/RPi4/RPi4.fdf | 2 +- > Platform/RaspberryPi/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf | 6 +- > Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 6 + > Platform/RaspberryPi/Library/ResetLib/ResetLib.inf | 45 ------ > Platform/RaspberryPi/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.c | 65 ++++++--- > Platform/RaspberryPi/Library/MemoryInitPeiLib/MemoryInitPeiLib.c | 2 + > Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c | 77 ++++++++++ > Platform/RaspberryPi/Library/ResetLib/ResetLib.c | 151 -------------------- > 12 files changed, 156 insertions(+), 231 deletions(-) > delete mode 100644 Platform/RaspberryPi/Library/ResetLib/ResetLib.inf > delete mode 100644 Platform/RaspberryPi/Library/ResetLib/ResetLib.c > > -- > 2.46.0.rc1.232.g9752f9e123-goog > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120075): https://edk2.groups.io/g/devel/message/120075 Mute This Topic: https://groups.io/mt/107626473/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-