From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: Nhi Pham <nhi@os.amperecomputing.com>
Cc: <devel@edk2.groups.io>, <chuong@os.amperecomputing.com>,
<rebecca@os.amperecomputing.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 2/5] AmpereSiliconPkg: Define PCDs for SMBUS and BMC
Date: Thu, 1 Aug 2024 16:02:21 +0100 [thread overview]
Message-ID: <ZqujfcOIKwu4gfvD@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <20240801093618.191274-3-nhi@os.amperecomputing.com>
On Thu, Aug 01, 2024 at 16:36:15 +0700, Nhi Pham wrote:
> This introduces fixed PCDs for SMBUS and BMC as specified to Ampere.
>
> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
> ---
> Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec b/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec
> index 56e8b2fd2f11..5c5015c1bf21 100644
> --- a/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec
> +++ b/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec
> @@ -69,6 +69,18 @@ [PcdsFixedAtBuild]
> gAmpereTokenSpaceGuid.PcdSmbiosTables0MajorVersion|0xFF|UINT8|0x00000005
> gAmpereTokenSpaceGuid.PcdSmbiosTables0MinorVersion|0xFF|UINT8|0x00000006
>
> + #
> + # SMBUS
> + #
> + gAmpereTokenSpaceGuid.PcdSmbusI2cBusNumber|0x00|UINT8|0x00000007
> + gAmpereTokenSpaceGuid.PcdSmbusI2cBusSpeed|100000|UINT32|0x00000008 # Hz
> +
> + #
> + # BMC
> + #
> + gAmpereTokenSpaceGuid.PcdBmcSlaveAddr|0x10|UINT8|0x00000009
Current Smbus specification uses controller/target terminology.
/
Leif
> + gAmpereTokenSpaceGuid.PcdBmcReadyGpio|0x18|UINT8|0x0000000A
> +
> [PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx]
> #
> # Firmware Volume Pcds
> --
> 2.25.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120180): https://edk2.groups.io/g/devel/message/120180
Mute This Topic: https://groups.io/mt/107662236/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-08-01 15:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 9:36 [edk2-devel] [edk2-platforms][PATCH 0/5] Add IPMI SSIF support Nhi Pham via groups.io
2024-08-01 9:36 ` [edk2-devel] [edk2-platforms][PATCH 1/5] AmpereAltraPkg/DwI2cLib: Add SmbusRead() function Nhi Pham via groups.io
2024-08-01 15:14 ` Leif Lindholm
2024-08-05 3:44 ` Nhi Pham via groups.io
2024-08-01 15:18 ` Leif Lindholm
2024-08-05 3:46 ` Nhi Pham via groups.io
2024-08-01 9:36 ` [edk2-devel] [edk2-platforms][PATCH 2/5] AmpereSiliconPkg: Define PCDs for SMBUS and BMC Nhi Pham via groups.io
2024-08-01 15:02 ` Leif Lindholm [this message]
2024-08-05 3:18 ` Nhi Pham via groups.io
2024-08-01 9:36 ` [edk2-devel] [edk2-platforms][PATCH 3/5] AmpereAltraPkg: Add SmbusHc PEI and DXE drivers Nhi Pham via groups.io
2024-08-01 9:36 ` [edk2-devel] [edk2-platforms][PATCH 4/5] JadePkg: Add PlatformBmcReadyLib to support BMC ready check Nhi Pham via groups.io
2024-08-01 9:36 ` [edk2-devel] [edk2-platforms][PATCH 5/5] Ampere/Jade: Enable IPMI SSIF Nhi Pham via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqujfcOIKwu4gfvD@qc-i7.hemma.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox