From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7EE19D8019A for ; Wed, 7 Aug 2024 16:30:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=AvbhLZKkuW7pBVBPcv7quxiwL3zgMfOf/DKnehPLdG8=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1723048206; v=1; b=D010cUDnl+rkgX57nKiSdmcOyR2u2AFTaQB8sNpGTxgeeeHzGJ/oRX17LeidIl2i1sGvHi94 I2wSgv/tE+ueyD/rAu/aVl5hkz+2qZNYpr8cjFl7j/tIttZFOtbrfgcMMQeEuOETY91E+IHBo2p RbXstLU6GuCLq+CDkvGgZYzIh0pvqrWkNCdRha2eMCHwPlUcRtOCjOI0OPQv0JStRcLofGXmh2i zw5U41ZjFaN9kYYuSoVus6tHoxZL3Tip0WobkQOxy008/pYRe6OtppG14LhGRuNVPFbQHn27kAa ozICmo0jHGZicN06J1iA19hLoYB6QR2Fh5MaWuVTdlLaw== X-Received: by 127.0.0.2 with SMTP id SEcrYY7687511xPA5raQFlcg; Wed, 07 Aug 2024 09:30:05 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.37921.1723048199338075558 for ; Wed, 07 Aug 2024 09:29:59 -0700 X-Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4778ATiX015691; Wed, 7 Aug 2024 16:29:58 GMT X-Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 40sc4yb9du-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Aug 2024 16:29:58 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 477GTvmE006659 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 7 Aug 2024 16:29:57 GMT X-Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 7 Aug 2024 09:29:55 -0700 Date: Wed, 7 Aug 2024 17:29:52 +0100 From: "Leif Lindholm" To: Marcin Juszkiewicz CC: , Xiong Yining , Ard Biesheuvel , Graeme Gregory , Chen Baozi , Jonathan Cameron Subject: Re: [edk2-devel] [PATCH edk2-platforms v6 0/6] SbsaQemu: Align the PPTT tables with QEMU Message-ID: References: <20240807-acpi65-v6-0-fc426e4abfe2@linaro.org> MIME-Version: 1.0 In-Reply-To: <20240807-acpi65-v6-0-fc426e4abfe2@linaro.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: P20TUZb6IXifbofqs4ZPOA6YyeQmi0kC X-Proofpoint-GUID: P20TUZb6IXifbofqs4ZPOA6YyeQmi0kC Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 07 Aug 2024 09:29:59 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 6zykVKNhzwbyt70U5AyTOCZ5x7686176AA= Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=D010cUDn; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none) On Wed, Aug 07, 2024 at 13:34:38 +0200, Marcin Juszkiewicz wrote: > We want to make sure that CPU topology information given to QEMU would > be provided to the operating system. So we use SMC call to ask TF-A for > amount of sockets, clusters, cores and threads set in QEMU config. > > The TF-A part is already merged: > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/27189 > > Signed-off-by: Xiong Yining > Signed-off-by: Marcin Juszkiewicz For the series: Reviewed-by: Leif Lindholm Thanks! / Leif > To: devel@edk2.groups.io > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Graeme Gregory > Cc: Chen Baozi > Cc: Xiong Yining > Cc: Jonathan Cameron > > Changes in v6: > - use ArmMonitorLib for GetCpuTopology() as we need 5 return values > - Link to v5: https://openfw.io/edk2-devel/20240711-acpi65-v5-0-a30180b74964@linaro.org > > Changes in v5: > - added support for cache sizes on cores with FEAT_CCIDX (Neoverse V1+) > - Link to v4: https://openfw.io/edk2-devel/20240710-acpi65-v4-0-bc32224e4be4@linaro.org > > Changes in v4: > - renamed all *Index variables to *Offset ones for clarity > - renamed static CpuId/CacheId variable to mCpuId/mCacheId > - moved above variables outside of pragma pack > - moved all variables definitions to start of functions > - added reading cpu cache size from CCIDR registers > - changed wording in SbsaHardwareInfoLib header > - changed wording in 3rd patch commit message > - Link to v3: https://openfw.io/edk2-devel/20240709-acpi65-v3-0-ee93ba536fcf@linaro.org > > Changes in v3: > - split ACPI 6.5 changes into separate patch > - moved adding cores/threads to separate function > - fixed cache offsets > - Link to v2: https://openfw.io/edk2-devel/20240702-acpi65-v2-0-3cb18a892221@linaro.org/T/#t > > Changes in v2 (Marcin Juszkiewicz): > - use ACPI 6.5 structures (instead of 6.3) > - add patch to move cache data to cores (instead of clusters) > - this is for future MPAM support > - reformatted sources using uncrustify > - changed debug output to allow singular values (s/are/:/) > > --- > Marcin Juszkiewicz (5): > SbsaQemu: get the information of CPU topology via SMC calls > SbsaQemu: update PPTT to ACPI 6.5 > SbsaQemu: provide cache info per core in PPTT > SbsaQemu: introduce helper in PPTT generation > SbsaQemu: export proper cache values in PPTT > > Xiong Yining (1): > SbsaQemu: align the PPTT tables with QEMU > > .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.h | 11 + > .../Include/IndustryStandard/SbsaQemuAcpi.h | 110 +++----- > .../SbsaQemu/Include/IndustryStandard/SbsaQemuSmc.h | 1 + > .../Qemu/SbsaQemu/Include/Library/HardwareInfoLib.h | 26 ++ > .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 274 +++++++++++++++++--- > .../SbsaQemuHardwareInfoLib.c | 35 +++ > 6 files changed, 341 insertions(+), 116 deletions(-) > --- > base-commit: a3c898956a4d48dc5980336fa6ce6eeb23c4f72b > change-id: 20240702-acpi65-1bfdb20bde1a > > Best regards, > -- > Marcin Juszkiewicz > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120283): https://edk2.groups.io/g/devel/message/120283 Mute This Topic: https://groups.io/mt/107767179/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-