From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id A89D7740038 for ; Tue, 10 Sep 2024 05:38:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=uB/Dbn2WIRUhI2qEb5kD/haC9tmzs/ob84yuq0SN2BE=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:User-Agent:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20240830; t=1725946707; v=1; x=1726205906; b=SOTV4A8EGnAocJqiX/dpAdtyryEY3uZtuCRLK85WzW9zJH/GQQ1Zof3s+MpZveLKbxe/adbc d2xYYw3ckjRJsZm/x+l/J0uW1VaHu4jFHhOoopXdxrBr4zyUVafts6xHGRKHjnPnQAvnugaxf+4 H6kFo1SAD/DutOWettQdsVAKseK03Eq4BbNHwTy+keXBRGuR/vNj7zwUBhrq9Icjt3Kk7eR3iMH k29znqQAsML7/g1yxexhFimoFjnQ0eE+2dD1X+3OhTqEshYv1ARTms/hxhjO6JU1WU65ubYWPqB /5rZGV0sF2fWnsWBwzCGCsUXtiNANS9p1w8f+6Dj588jw== X-Received: by 127.0.0.2 with SMTP id LqYDYY7687511xhbsaEF33Wv; Mon, 09 Sep 2024 22:38:26 -0700 X-Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web10.16347.1725946705108365052 for ; Mon, 09 Sep 2024 22:38:25 -0700 X-Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-42cb6f3a5bcso22951985e9.2 for ; Mon, 09 Sep 2024 22:38:24 -0700 (PDT) X-Gm-Message-State: kmjhYJwCajeH2xNGcba9s8U2x7686176AA= X-Google-Smtp-Source: AGHT+IF3ZXz8VSN6oJOJfdvVFu8XDBKZPV4BO9gt8/kUfUK6fRK21G6DdjMRMCGyKeDbbPt1hrmrew== X-Received: by 2002:a5d:4248:0:b0:374:c512:87ce with SMTP id ffacd0b85a97d-378922b7b58mr8223310f8f.30.1725946702945; Mon, 09 Sep 2024 22:38:22 -0700 (PDT) X-Received: from localhost.localdomain (118-168-204-67.dynamic-ip.hinet.net. [118.168.204.67]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7d8256d08b9sm4840513a12.63.2024.09.09.22.38.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Sep 2024 22:38:22 -0700 (PDT) Date: Tue, 10 Sep 2024 13:38:18 +0800 From: "Richard Lyu via groups.io" To: devel@edk2.groups.io Cc: richard.lyu@suse.com Subject: [edk2-devel][RFC PATCH] OvmfPkg/Include: Remove NETWORK_ENABLE check in ShellComponents.dsc.inc Message-ID: MIME-Version: 1.0 User-Agent: Mutt/2.2.13 (2024-03-09) Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 09 Sep 2024 22:38:25 -0700 Resent-From: richard.lyu@suse.com Reply-To: devel@edk2.groups.io,richard.lyu@suse.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=SOTV4A8E; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io I tried to fix the build error that occurred after commit 7f17a155640a. I have found that even when NETWORK_ENABLE=0, VirtioNet.inf is still being included. This causes errors by including network-related modules, but I’m not sure if there are other reasons. Does anyone have any ideas or suggestions on how to resolve this issue? Otherwise, the only solution would be to use this patch to remove the NETWORK_ENABLE check. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4829 The `NETWORK_ENABLE` condition in `ShellComponents.dsc.inc` causes build errors. This change removes the check, ensuring `TftpDynamicCommand` and `VariablePolicyDynamicCommand` are always included in the build. Signed-off-by: Richard Lyu --- OvmfPkg/Include/Dsc/ShellComponents.dsc.inc | 2 -- 1 file changed, 2 deletions(-) diff --git a/OvmfPkg/Include/Dsc/ShellComponents.dsc.inc b/OvmfPkg/Include/Dsc/ShellComponents.dsc.inc index 4075688e41..8e4385282e 100644 --- a/OvmfPkg/Include/Dsc/ShellComponents.dsc.inc +++ b/OvmfPkg/Include/Dsc/ShellComponents.dsc.inc @@ -5,7 +5,6 @@ !if $(BUILD_SHELL) == TRUE !if $(TOOL_CHAIN_TAG) != "XCODE5" -!if $(NETWORK_ENABLE) == TRUE ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE @@ -14,7 +13,6 @@ gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE } -!endif ShellPkg/DynamicCommand/VariablePolicyDynamicCommand/VariablePolicyDynamicCommand.inf { gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE -- 2.43.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120538): https://edk2.groups.io/g/devel/message/120538 Mute This Topic: https://groups.io/mt/108361994/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-