public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sunil V L" <sunilvl@ventanamicro.com>
To: devel@edk2.groups.io, blacktang482@gmail.com
Cc: dahogn <dahogn@hotmail.com>,
	caiyuqing379 <caiyuqing_hz@outlook.com>,
	meng-cz <mengcz1126@gmail.com>,
	USER0FISH <libing1202@outlook.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] Add BaseRiscVFpuLib.inf in SG2042.dsc it is necessary to build SG2042.fv
Date: Tue, 19 Nov 2024 09:35:03 +0530	[thread overview]
Message-ID: <ZzwOb9utUCK9c-U-@sunil-laptop> (raw)
In-Reply-To: <20241118152021.1442758-2-blacktang482@gmail.com>

Hi,

On Mon, Nov 18, 2024 at 11:20:21PM +0800, DennisDing2003 via groups.io wrote:
> Cc: dahogn <dahogn@hotmail.com>
> Cc: caiyuqing379 <caiyuqing_hz@outlook.com>
> Cc: meng-cz <mengcz1126@gmail.com>
> Cc: USER0FISH <libing1202@outlook.com>
> Signed-off-by: DennisDing2003 <blacktang482@gmail.com>
> Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

Please add this tag only after some reviewer actually gives this. In
this case, I didn't review it before this.

Anyway, the change looks good. Please raise a github PR.

Thanks,
Sunil
> ---
>  Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
> index 8825c8233ba2..6773868aa7df 100644
> --- a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
> +++ b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
> @@ -144,6 +144,7 @@ [LibraryClasses.common]
>  
>    # RISC-V Architectural Libraries
>    RiscVSbiLib|MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.inf
> +  RiscVFpuLib|UefiCpuPkg/Library/BaseRiscVFpuLib/BaseRiscVFpuLib.inf
>    RiscVMmuLib|UefiCpuPkg/Library/BaseRiscVMmuLib/BaseRiscVMmuLib.inf
>    CpuExceptionHandlerLib|UefiCpuPkg/Library/BaseRiscV64CpuExceptionHandlerLib/BaseRiscV64CpuExceptionHandlerLib.inf
>  
> -- 
> 2.47.0
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120799): https://edk2.groups.io/g/devel/message/120799
Mute This Topic: https://groups.io/mt/109651227/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-11-19  4:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-18 15:20 [edk2-devel] [PATCH v1 0/1] *** Add BaseRiscVFpuLib.inf in SG2042.dsc *** DennisDing2003 via groups.io
2024-11-18 15:20 ` [edk2-devel] [PATCH v1 1/1] Add BaseRiscVFpuLib.inf in SG2042.dsc it is necessary to build SG2042.fv DennisDing2003 via groups.io
2024-11-19  4:05   ` Sunil V L [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-11-15  2:36 [edk2-devel] [PATCH v1 0/1] *** Add BaseRiscVFpuLib.inf in SG2042.dsc *** DennisDing2003 via groups.io
2024-11-15  2:36 ` [edk2-devel] [PATCH v1 1/1] Add BaseRiscVFpuLib.inf in SG2042.dsc it is necessary to build SG2042.fv DennisDing2003 via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZzwOb9utUCK9c-U-@sunil-laptop \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox