From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3F2A8D8030C for ; Tue, 19 Nov 2024 04:05:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=TCRB89tjx/v5hdR6vgCw3phJcMArkcuz52lG6ZNYa80=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240830; t=1731989122; v=1; x=1732248320; b=N6v+GXtZsSz9F9b0QkuJZMdBFaJLtFM3QkDwrHJT/0ppzO1NXcUMT73oRSHBFlg74EYKbg+W id6bT3uojsI4VVoDcTcshyxHnzxoclaESXhUQ48wF3iXiROOInjtYK6gX4cB2/nLRPddiLa3QYt PQszvkdOMhmENBw700nUUaLH8PIVorik0T5oaUnaZOv3vwAFhCqxWE1Bztw34ayTHfT3iONtopV PxQtOhOcwqjRcW6cfM63EssOR/xunpJitz/yXHe6rCeASxahpxo56QoBqspuqBs/b5muxj4lwdO /nf8byVA9zsS5o+h9z4Jv3wrf+ZDjWZ82ErGnjpqrcTIw== X-Received: by 127.0.0.2 with SMTP id SNeEYY7687511xl8umtlFKeX; Mon, 18 Nov 2024 20:05:20 -0800 X-Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by mx.groups.io with SMTP id smtpd.web11.13313.1731989114866576730 for ; Mon, 18 Nov 2024 20:05:14 -0800 X-Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3e5f533e1c2so311477b6e.3 for ; Mon, 18 Nov 2024 20:05:14 -0800 (PST) X-Gm-Message-State: e9mfULoX0Kp0r2g0BXdQ7Mvdx7686176AA= X-Google-Smtp-Source: AGHT+IEFRXkRus7B3BTUqnQUe7LwbP8icJpC5pSLSYLH7tJDdXSZR9HzN70k1XMOxPPrNr8iODHRtQ== X-Received: by 2002:a05:6808:3027:b0:3e5:d5c3:e88b with SMTP id 5614622812f47-3e7bc7db3edmr12957118b6e.20.1731989113210; Mon, 18 Nov 2024 20:05:13 -0800 (PST) X-Received: from sunil-laptop ([106.51.195.233]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3e7bccfba87sm3471754b6e.5.2024.11.18.20.05.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2024 20:05:11 -0800 (PST) Date: Tue, 19 Nov 2024 09:35:03 +0530 From: "Sunil V L" To: devel@edk2.groups.io, blacktang482@gmail.com Cc: dahogn , caiyuqing379 , meng-cz , USER0FISH Subject: Re: [edk2-devel] [PATCH v1 1/1] Add BaseRiscVFpuLib.inf in SG2042.dsc it is necessary to build SG2042.fv Message-ID: References: <20241118152021.1442758-1-blacktang482@gmail.com> <20241118152021.1442758-2-blacktang482@gmail.com> MIME-Version: 1.0 In-Reply-To: <20241118152021.1442758-2-blacktang482@gmail.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 18 Nov 2024 20:05:15 -0800 Resent-From: sunilvl@ventanamicro.com Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=N6v+GXtZ; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none Hi, On Mon, Nov 18, 2024 at 11:20:21PM +0800, DennisDing2003 via groups.io wrote: > Cc: dahogn > Cc: caiyuqing379 > Cc: meng-cz > Cc: USER0FISH > Signed-off-by: DennisDing2003 > Reviewed-by: Sunil V L Please add this tag only after some reviewer actually gives this. In this case, I didn't review it before this. Anyway, the change looks good. Please raise a github PR. Thanks, Sunil > --- > Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc > index 8825c8233ba2..6773868aa7df 100644 > --- a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc > +++ b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc > @@ -144,6 +144,7 @@ [LibraryClasses.common] > > # RISC-V Architectural Libraries > RiscVSbiLib|MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.inf > + RiscVFpuLib|UefiCpuPkg/Library/BaseRiscVFpuLib/BaseRiscVFpuLib.inf > RiscVMmuLib|UefiCpuPkg/Library/BaseRiscVMmuLib/BaseRiscVMmuLib.inf > CpuExceptionHandlerLib|UefiCpuPkg/Library/BaseRiscV64CpuExceptionHandlerLib/BaseRiscV64CpuExceptionHandlerLib.inf > > -- > 2.47.0 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120799): https://edk2.groups.io/g/devel/message/120799 Mute This Topic: https://groups.io/mt/109651227/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-