From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.2667.1650586556899239519 for ; Thu, 21 Apr 2022 17:15:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=LajiLC6r; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.46.36]) by linux.microsoft.com (Postfix) with ESMTPSA id 4221320E5650; Thu, 21 Apr 2022 17:15:53 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4221320E5650 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1650586556; bh=STbU19LjeT3AfjrZ/PXR+USTO9BsGcQX2DjMXWdf03A=; h=Date:Subject:From:To:Cc:Reply-To:References:In-Reply-To:From; b=LajiLC6rfwIugxRgSMLJSMtoi/SNkMCIUqL6a8uu3Y/s1E5MX+eGs27qqLD0P7IxJ g5gIjeuVGkj7m6b+gMYSgrXkpW6Pz9IQdQh3A2BqYDNwvx6YhyhmADa6EGeIeSajQo FExdscNXt+pvS7ov8cX51iX135RTYttgF5F9efdE= Message-ID: Date: Thu, 21 Apr 2022 20:15:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [edk2-devel] [PATCH v4 0/8] Add Variable Flash Info HOB From: "Michael Kubacki" To: devel@edk2.groups.io, Liming Gao , Jian J Wang , Hao A Wu Cc: Abner Chang , Andrew Fish , Anthony Perard , Ard Biesheuvel , Benjamin You , Brijesh Singh , Erdem Aktas , Gerd Hoffmann , Guo Dong , James Bottomley , Jiewen Yao , Jordan Justen , Julien Grall , Leif Lindholm , Maurice Ma , Min Xu , Nickle Wang , Peter Grehan , Ray Ni , Rebecca Cran , Sami Mujawar , Sean Rhodes , Sebastien Boeuf , Tom Lendacky Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com References: <16E533166CF9F366.27279@groups.io> In-Reply-To: <16E533166CF9F366.27279@groups.io> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello MdeModulePkg maintainers, This patch series has received reviews for all patches. I have placed a rebased branch with up-to-date review tags in the following PR: https://github.com/tianocore/edk2/pull/2812 Please let me know if anything further is needed for you to merge the PR. Thanks, Michael On 4/12/2022 12:29 PM, Michael Kubacki wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 > > The UEFI variable drivers such as VariableRuntimeDxe, VariableSmm, > VariableStandaloneMm, etc. (and their dependent protocol/library > stack), typically acquire UEFI variable store flash information > with PCDs declared in MdeModulePkg. > > For example: > [Pcd] > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64 > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize > > These PCDs work as-is in the StandaloneMm driver if they are not > dynamic such as Dynamic or DynamicEx because PCD services are not > readily available in the Standalone MM environment. Platforms that > use Standalone MM today, must define these PCDs as FixedAtBuild in > their platform build. However, the PCDs do allow platforms to treat > the PCDs as Dynamic/DynamicEx and being able to support that is > currently a gap for Standalone MM. > > This patch series introduces a HOB that can be produced by the > platform to provide the same information. The HOB list is > available to Standalone MM. > > The PCD declarations are left as-is in MdeModulePkg for backward > compatibility. This means unless a platform wants to use the HOB, > their code will continue to work with no change (they do not need > to produce the HOB). Only if the HOB is found, is its value used > instead of the PCDs. > > Due to the large number of consumers of this information, access > to the base address and size values is abstracted in a new library > class (as requested in the v1 series) called VariableFlashInfoLib. > > The API of VariableFlashInfoLib does not bind the underlying data > structure to the information returned to library users to allow > flexibility in the library implementation in the future. > > V4 changes: > 1. Add a UINT32 "Reserved" field to VARIABLE_FLASH_INFO. > 2. Add a descriptive comment to VariableFlashInfo.h to explain > HOB usage. > > V3 changes: > 1. To better clarify usage, renamed the members > "NvStorageBaseAddress" and "NvStorageLength" in > "VARIABLE_FLASH_INFO" to "NvVariableBaseAddress" and > "NvVariableLength". > 2. Added description comments to the fields in "VARIABLE_FLASH_INFO". > > V2 changes: > 1. Abstracted flash info data access with VariableFlashInfoLib. > 2. Updated package builds in the repo that build the variable and > FTW drivers to include VariableFlashInfoLib. > 3. Removed a redundant variable assignment in VariableSmm.c. > 4. Updated comments in FtwMisc.c and FaultTolerantWritePei.c to > indicate driver assumption is UINTN (not UINT32) > 5. Added a version field to the VARIABLE_FLASH_INFO structure. > > Cc: Abner Chang > Cc: Andrew Fish > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Benjamin You > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: Gerd Hoffmann > Cc: Guo Dong > Cc: Hao A Wu > Cc: James Bottomley > Cc: Jian J Wang > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Julien Grall > Cc: Leif Lindholm > Cc: Liming Gao > Cc: Maurice Ma > Cc: Min Xu > Cc: Nickle Wang > Cc: Peter Grehan > Cc: Ray Ni > Cc: Rebecca Cran > Cc: Sami Mujawar > Cc: Sean Rhodes > Cc: Sebastien Boeuf > Cc: Tom Lendacky > Signed-off-by: Michael Kubacki > > Michael Kubacki (8): > MdeModulePkg: Add Variable Flash Info HOB > MdeModulePkg/VariableFlashInfoLib: Add initial library > MdeModulePkg/Variable: Consume Variable Flash Info > MdeModulePkg/FaultTolerantWrite: Consume Variable Flash Info > ArmVirtPkg/ArmVirt.dsc.inc: Add VariableFlashInfoLib > EmulatorPkg: Add VariableFlashInfoLib > OvmfPkg: Add VariableFlashInfoLib > UefiPayloadPkg: Add VariableFlashInfoLib > > MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.c | 178 ++++++++++++++++++++ > MdeModulePkg/Universal/FaultTolerantWriteDxe/FtwMisc.c | 41 +++-- > MdeModulePkg/Universal/FaultTolerantWriteDxe/UpdateWorkingBlock.c | 7 +- > MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.c | 28 +-- > MdeModulePkg/Universal/Variable/Pei/Variable.c | 14 +- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c | 16 +- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.c | 14 +- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c | 17 +- > ArmVirtPkg/ArmVirt.dsc.inc | 1 + > EmulatorPkg/EmulatorPkg.dsc | 1 + > MdeModulePkg/Include/Guid/VariableFlashInfo.h | 111 ++++++++++++ > MdeModulePkg/Include/Library/VariableFlashInfoLib.h | 68 ++++++++ > MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf | 48 ++++++ > MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.uni | 12 ++ > MdeModulePkg/MdeModulePkg.dec | 8 + > MdeModulePkg/MdeModulePkg.dsc | 2 + > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWrite.h | 7 +- > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf | 10 +- > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.inf | 10 +- > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.inf | 10 +- > MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.inf | 10 +- > MdeModulePkg/Universal/Variable/Pei/Variable.h | 2 + > MdeModulePkg/Universal/Variable/Pei/VariablePei.inf | 5 +- > MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h | 7 +- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf | 5 +- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf | 5 +- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf | 5 +- > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + > OvmfPkg/Bhyve/BhyveX64.dsc | 1 + > OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 1 + > OvmfPkg/Microvm/MicrovmX64.dsc | 1 + > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > OvmfPkg/OvmfXen.dsc | 1 + > UefiPayloadPkg/UefiPayloadPkg.dsc | 1 + > 37 files changed, 558 insertions(+), 94 deletions(-) > create mode 100644 MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.c > create mode 100644 MdeModulePkg/Include/Guid/VariableFlashInfo.h > create mode 100644 MdeModulePkg/Include/Library/VariableFlashInfoLib.h > create mode 100644 MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > create mode 100644 MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.uni >