From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=40.107.70.88; helo=nam04-sn1-obe.outbound.protection.outlook.com; envelope-from=brijesh.singh@amd.com; receiver=edk2-devel@lists.01.org Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700088.outbound.protection.outlook.com [40.107.70.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2C6842098EACB for ; Thu, 14 Jun 2018 08:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8024VYjPA18QaP+tHNgopfMsmqXpozldTDG9EPRXvb8=; b=tgktkU7Ui9o5p2HK7PwUQdaxyi1n38/w4jjjB8lMkcoHrUIWiNmYXYomDgc9D32KP3T7n8FnIaZiZNcxLYaBKy/RthJAh5tUVehTVU6qdhgMlEIrSYHq/+6p6cZKQFs9+A2VfVZ1HsNs4j6P8y2GthNGYsyRnaUamWdLX1xuRYg= Received: from [10.236.136.62] (165.204.77.1) by BL0PR12MB2452.namprd12.prod.outlook.com (2603:10b6:207:4e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.16; Thu, 14 Jun 2018 15:47:27 +0000 Cc: brijesh.singh@amd.com, "edk2-devel@lists.01.org" , Jordan Justen , Liming Gao , Paolo Bonzini , Jeff Fan To: Laszlo Ersek , Andrew Fish , "Duran, Leo" References: <1528920674-24912-1-git-send-email-leo.duran@amd.com> <1528920674-24912-2-git-send-email-leo.duran@amd.com> <9e2b3f74-c37e-06d9-293e-04976713ce8c@redhat.com> <69709be6-0469-1f82-7a5e-48a93a3520c2@redhat.com> From: Brijesh Singh Message-ID: Date: Thu, 14 Jun 2018 10:47:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <69709be6-0469-1f82-7a5e-48a93a3520c2@redhat.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0501CA0137.namprd05.prod.outlook.com (2603:10b6:803:2c::15) To BL0PR12MB2452.namprd12.prod.outlook.com (2603:10b6:207:4e::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8cdce667-a2dc-43cc-3139-08d5d20e21a1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:BL0PR12MB2452; X-Microsoft-Exchange-Diagnostics: 1; BL0PR12MB2452; 3:TsYzluWXW0rg59zx9+p93S4Uokqvq4huw4tGkgzy8/IrIRvV1/hteVtcoWD+L32h9t/Z+m1GW1oUcx5+YF3Lted7PWMSeKvZMPdyGecwptGvZU33PShpvZziBFhADLuVab2/FFWmBJvffJmZEUPyASEokTS5JkcT8Be5SY8WPFVuWAtuUvZG0T630+kOKoXTO0jwf4TCf5M+68p0ayi75ziMUW+2W/GWuA5d/wjqfd9xB/Vd1GY/t5bz1bN2uxVj; 25:gZ2Ky9kixwPebC/L+4caW/D2IwnJbt32wqZabPAHrbX4pfAKUpU4N+HaHUfW01BZ5v+GwXBYJpd2q/h/Hh380j87GIJfHi3lXbCi+i60yg2Teold7fhxr5WzBmYQYaJqtT2qsBrbkxg9hvz+PDc9Ol16GAQlmpG2AxcScts+Xr35pOoPhjv1kKiuB424QVVfazZyeB6Nv/9C6u1pWDseyElg6UJplisYYzn0TtCWTtTRLL6n4U0j3YEkv22KdbGpQyPzgxVPfBcEEy3Xde5PCDLfX1pzwnOtc+MJ7h9QL9k85VJm46h+hpSSo4+26UHpAg0n0Lgkk0bR4B7wMRcRAw==; 31:EN2Pujd0pjlL+xk03t8ZRd2tAGRr6E0nfGBZgw45aw8M6iXUeYSueZt4Vz36YidoMaiSByWnNvYFxvsYDWjAPv9xXIwXOi328fZ7cjiCl63aNJfSMRQy2zwtFzL4YlYFCsaCk6G3T1OutJZg3OjhOmaE4/gwtIwCIsZ0s+zVswutgx+SIPK+fl8xsnTkWQgZ/R0s7DGTi6EqlMZGbHLZ383tc8SgyMbWAxOF5dj2Dc0= X-MS-TrafficTypeDiagnostic: BL0PR12MB2452: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; X-Microsoft-Exchange-Diagnostics: 1; BL0PR12MB2452; 20:TJTc207wfCXR+x+BE9jP2WCcA5JCF+A29JprY1nvwbIK9LoOfEZArr7nqoOHt2ZSuHKIwVo2cIZ94livM5ysjDAOxa9CJ/yn9av2oOjNOO39+mIO19BoBW86m+FlxlDQzn+UM84p+rkM7aoBfYpjlYkVjccqX0IOTHmEurjqqa2inprTD9rk7WUNw9KMQ7JytwazgFgfw/pXvlVsA2sOjkOkAi3rUS2FxJzf0XAQPbSV2clZTjzBB+j8UAajv+tdxV8HGJa2aWh/wxVz1qHDHEmIpLz6ZAzvMrg7Zj2bIfJkScBjT/HtSlRha9Rq+NvgPTALPF/o+hCzt2xhUx4EMmj1Y15KqmohSCDcRxm+FuOtVgEV52D5+5skPU/L6ktSp4QLupyn9p9hLX3GkvrwewP962gzuQPsft64rfGm/kZoAiXn6zZO/kapqVkatp69OiymTtoIkbp6TJnGnVPGrJj7imegzmiqJruHFqSRwzoOLiZH9RC0Ri4z2PVvI36/; 4:9pIgUGHKtmHB23HdMQV/Nbp4lgyjSwlVK9SYi5I2pNyGTtgkHVWU6Z/6egbMN/+TjAAJN/CO1h7L7SxZii6YBf05t+8xEIhU+YtElIL/ViSdIM9fJWAe6oEypfbwrFODHF19Eg/OvSxeHUhFQGt46Hg5/EPegcip8a+QqsYovytvboZzWNyBnsgA8hxshpc1q1Y4RnZW/7q6b0YfLmR2Qb6D1MZPY4H1gExKCOsB70SZEvLKPl2L7s/iIAfhMGflp/wOxWYAssAoJ5LbI1zcZ8ccDg67zK+3zIPj2IcijawkUol+7nAnOpmphcy3LVEhQ0AutKHyqWf+QuOVH2nMls9RUxd0anLBFjMVdwrq5UFgxndqvN2IXmxL1XQ+4kkj X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(162533806227266)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:BL0PR12MB2452; BCL:0; PCL:0; RULEID:; SRVR:BL0PR12MB2452; X-Forefront-PRVS: 0703B549E4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(346002)(376002)(366004)(396003)(39860400002)(39380400002)(13464003)(199004)(189003)(58126008)(316002)(3846002)(86362001)(31696002)(6116002)(2906002)(305945005)(50466002)(230700001)(7736002)(4326008)(110136005)(54906003)(67846002)(65826007)(23746002)(5660300001)(6246003)(229853002)(16576012)(25786009)(93886005)(53936002)(68736007)(65806001)(66066001)(97736004)(65956001)(6486002)(8666007)(386003)(59450400001)(53546011)(8936002)(26005)(6636002)(77096007)(76176011)(52116002)(478600001)(186003)(2616005)(8676002)(64126003)(81166006)(16526019)(105586002)(81156014)(106356001)(31686004)(6666003)(11346002)(36756003)(476003)(956004)(486006)(47776003)(446003)(44832011); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR12MB2452; H:[10.236.136.62]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BL0PR12MB2452; 23:idd/PH1vMhbLJIHdZzvcFmLOYFnDSGQ0bsuNy?= =?Windows-1252?Q?8HOwGbqhH6TyPLVOWnw8jYsigYIP/1rxm1L6aSpM67IeAsMtQSJ5s9PA?= =?Windows-1252?Q?oYJFsMMKSUTFeXjJQcaMP7XNts3LDjMBwBLBejYCC77njBoAStWYXGuR?= =?Windows-1252?Q?i8wQKEIFsWP8ysWjpGDtt5pSErgUyzQkoOpzD7IpkRTvLiYJlQmzw212?= =?Windows-1252?Q?xiVt4zAIG7I/CZBNVIrayujvkyKhAuJtuIcEknmV6W3hZuP80y3omylU?= =?Windows-1252?Q?E9tJik9d+BLno5igawCnMlIazD4PkDUInjLhrEVtiOn0W7lbjp6lZDoo?= =?Windows-1252?Q?PL1CunFlamZA0sb3P0K8xjSpGS70+gWmijNlT9bq6P3wcyBtREv15j3D?= =?Windows-1252?Q?ztwb/biBR3YbWnogToPucaGmKDVBTenCIt0B4dvjO7UG/PKaYEySCetG?= =?Windows-1252?Q?gOvljn/ERDTtqI9mkTJlfvJELOWhbeOmKyaNRIQe8HAR6dngGAsxPeul?= =?Windows-1252?Q?LZ9g3seI6eM2bFp2PbiOLbQS8muA3eOuOL1m1lR7p7/Xws94qxSKQuCo?= =?Windows-1252?Q?2Tlo30bJBfqjAVbEopPhpVqz4Gzbtqv+C3ggZ7/0EFkfVh+A+xgeoazA?= =?Windows-1252?Q?Vbp0VKvMYscXgTmSAiVecP6rb4rD4Uc5DFUbLaxdDn1fPOQ2XetnwfIl?= =?Windows-1252?Q?hMGKBt5dU5/44scPbR8l6fsVE55f4mm6+Y0+uRV9KTKgopZzotDagN1m?= =?Windows-1252?Q?pQukfO9eVWo/I4G6X3QqJ2A9oMuvCQwMWHNplWxC8M0JmZzoNL14scVc?= =?Windows-1252?Q?FWdRwnLebpGpilellg6MTr8I+tDOgZyt6b4mjqkqRXj9Md6M7yOo1q3H?= =?Windows-1252?Q?xbZQsUZioZ1Skt8gesRMcvlzj/P21EcByoHVgXZOJrDb9x3uGdroXkI3?= =?Windows-1252?Q?O5Z+ahe/83kpQB21MBjLOOGkp7XwqJjEoyAzOsoBhR98XLJckOe8Z4rB?= =?Windows-1252?Q?/XhXcJMGgJ/rexKddNMVUdEZMlAI94eF4WC1B7bpW4WfuqPO7TF1xa9f?= =?Windows-1252?Q?BfP3PBvHUJCwO3zeNHU7Lq1wLpQMSu7v4ldTTL5fRG+0DoFuaYwKOxpA?= =?Windows-1252?Q?9bcX33qi6lbng18h1Fqvg90opWPLGOsM35P+n4xlAESf7j5Qp1VUJQCk?= =?Windows-1252?Q?0sukAXg1WjKyp9PQ+xJP9uFWGlW6Yg7C+94yxu23Jx2YTstOCSIILL+C?= =?Windows-1252?Q?3wcyBoZPFRg01fZi9Kf6l3d3jAmQD+3KKtIR3m+GHgBQu2oOTVZNU2CP?= =?Windows-1252?Q?arnd1VRPWMfY1+Ls6LScgPBfFiYjcGiVoLs/xUDWn8RCjS1Miq3ztOU+?= =?Windows-1252?Q?q8B0bC8AdybJXs28obAbGxtCFPt+Z8/XBRkGq6jAzSsTPjkFdu/JfjB5?= =?Windows-1252?Q?+o4s3EOWSdcUjChcuu4e4HAyqDYoSLTK6FTn2tOKsjCOHOZ5fh6nGRQN?= =?Windows-1252?Q?YnVJEjgsdAxw89ObkOBS9IN6VspFCHBRihZtwTBHiqt7YZc//pyCrINl?= =?Windows-1252?Q?I/4obp6PUCaKzFfRJzTa4Vo3pD9sGkJPtzobZseLAPRIOOBh3RYB/TIC?= =?Windows-1252?Q?yNBrFXw0gmh6CZ76r4q2yCxLvoKbUwC/q0RKsiC120ptFuIIIiyhls9p?= =?Windows-1252?Q?+KIH+Nv7w=3D=3D?= X-Microsoft-Antispam-Message-Info: HwHTX77CA1drz0rzVBZKYtGrXWUgSLGqLbdM72UQCchYIOH658e2hd+2328VeN22/6mlWH92oZ6VAWJiV9pfLnFTH+mA71UfOm43WIDsk0Yf/vJHm4D1zUYmA9rLuQwi3SuxMIXtNI7qd5DOSNWFTSQOcFnficPfYmn01lri2Zb8I0P1MQ3FxQFCt0WqfUKD X-Microsoft-Exchange-Diagnostics: 1; BL0PR12MB2452; 6:r+b1wsF1O6mVxyvrEoDKhgTDtrf+OC5GRX1g3pq0sAYJmLQMfsRAbqrE++bhRWzWr+RoCFy0Lpd2pyZOCt5oELrTmUFmIxL7GY24orJTzYedSXjBRuHPtgfzSXgegc+xPq95ikBcoe4kvQNBEQ3NOgjTj3Qh3a/b8ZgOGyO4RUQASf3XK8Rma5vAe9i1TOVMc1NP/i7agqR6Ol+rGnc6LJac7CGtS8AsLiJOHo7IfeqmdV20UPakgX4cxe8ZwuT1C1NeRyg0H3a7hZ31mBPDdE+Y2K+BvBJ9PCgMuw+rEhKRFkvVsBqsi+1douhzG8lmgz72r3whEX4+ei7lh2BF/sJk8G3rvVDVSMPwc5FjS5njgmVZrlFrT8WVOYRW2C7gNTXCXMR1bb0uTssfGL1TJP9RIQP9lQ7Y8JwBMgpj39Su/trL6NtRyg+KydWe4YiklmObY4GQld8AikVj7Huvow==; 5:PnNU4A8ETUWTv4Pby2BZTRTo0jRjq6y5GWPCU6X5E6JZb2FxlFJU1iZQoexCEVTVQIZjEGVt1TfkaKofEezWPkt5OVzLY+YkrMISRTbiCmu/Rqel+9Dy4br+e1Kmcn6IKndVvEJBlaffaXOXKBIcbKJGBnbxA9hW2jkvDDpudX4=; 24:EwZrqIy9KyzpjWwK6XJOLOtFhq2XvhwFAPDWv5ixtJN9v8Qk/t3BJLfL1+fJwL0m2P6GSeRnhIlCgxGusQJdlsTj3LJY4eIHqecKz3AhXjs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BL0PR12MB2452; 7:t/+qgbhng4ZdFQdknDdBCOg3D+XR/KCCB0d24brAz7cyUQeL4Xm1ietQJJpiDjH7XSvDiGkIX+cFJINygEvRykp4bKlMyu8/MRNTFSOGmy3qFXq3io5TIHFBh7AgI2sdwqmh8LHPPU6bnLH+zdDP7oJ2cstZLkNMuyS3eALRDkgwPAho6LK8RLsKN6qyl/7eaRhteLV2tC3wbibi3jxXsirtJz5MLGihtY6XEmbTqQpIaYY5fDWzIhajIUA6rUHH; 20:ty8UuJQKqpSh7H6w4EhCkVMOgXKCPtcvmInlZcn7x6e4MgHQ21PKaQNCicb3sk3qaymSLODN3d6Rxy59kx+7/+H+K0aI5au8yKXvdC4Z8RVYoaDxG9jmTca/AB7ZdIb+V0E6duabplNiQbQHJwXkvFcqiBtjyjT8meSU8faZQ0TVPGmz/rOOxGW9cClCX5FleWJpiblCAaKil0Re5/Z5ovckUrYoJf5/mnk9cb/wpq24KCWB3lTcYmRtvg2MJ4oT X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2018 15:47:27.2165 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8cdce667-a2dc-43cc-3139-08d5d20e21a1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB2452 Subject: Re: [PATCH] UefiCpuPkg/LocalApicLib: Exclude second SendIpi sequence on AMD processors. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 15:47:30 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/14/2018 10:00 AM, Laszlo Ersek wrote: > On 06/14/18 16:52, Andrew Fish wrote: >> >> >>> On Jun 14, 2018, at 7:08 AM, Duran, Leo wrote: >>> >>> >>> >>>> -----Original Message----- >>>> From: Laszlo Ersek > >>>> Sent: Wednesday, June 13, 2018 3:50 PM >>>> To: Duran, Leo >; edk2-devel@lists.01.org >>>> Cc: Jordan Justen >; Jeff Fan >>>> >; Liming Gao >; Singh, Brijesh >>>> >; Paolo Bonzini >; Igor >>>> Mammedov > >>>> Subject: Re: [edk2] [PATCH] UefiCpuPkg/LocalApicLib: Exclude second >>>> SendIpi sequence on AMD processors. >>>> >>>> Hello Leo, >>>> >>>> On 06/13/18 22:11, Leo Duran wrote: >>>>> On AMD processors the second SendIpi in the SendInitSipiSipi and >>>>> SendInitSipiSipiAllExcludingSelf routines is not required, and may >>>>> cause undesired side-effects during MP initialization. >>>>> >>>>> This patch leverages the StandardSignatureIsAuthenticAMD check to >>>>> exclude the second SendIpi and its associated MicroSecondDelay (200). >>>> >>>> QEMU and KVM emulate some AMD processors too; of particular interest is >>>> the recent EPYC addition, I believe (for SME/SEV, minimally). >>>> >>>> Did you check whether the StandardSignatureIsAuthenticAMD() check >>>> applies to those QEMU VCPU models, and if so, whether omitting the second >>>> Startup IPI interferes with *V*CPU startup in OVMF guests? (In >>>> multiprocessing modules, such as CpuMpPei, CpuDxe, and >>>> PiSmmCpuDxeSmm.) >>>> >>>> Adding Brijesh, Paolo and Igor. >>>> >>>> Thanks! >>>> Laszlo >>> >>> Hi Lazlo, >>> >>> My understanding is that hypervisors simply ignore the second SIPI, so a single (or double) SIPI should be fine. >>> In any event, I'm checking with Brijesh on your specific question. >>> >> >> My understanding is the 2nd SIPI was for an Intel processor bug in the mid 1990's and it has not been required since. People are just scared to change it since all the Operating Systems have been historically validated against INT SIPI SIPI. >> >> One of my co-works removed our extra SIPI, not knowing the history, and everything worked. Well we booted a little faster without the extra SIPI. >> >> If people still have the compatibility concern can we make the 2nd SIPI configurable via a PCD. But given the StandardSignatureIsAuthenticAMD() data point we should default the 2nd SIPI to off and move the world forward? What do folks think? > > Given that I asked Brijesh to comment too, I'd like to see his feedback > as well (or Leo to forward Brijesh's findings); then I'm OK with > removing the second SIPI. > I did a quick test with and without SEV enabled, QEMU seems to be working fine. As Leo pointed out that the second SIPI is not required on AMD processor. -Brijesh