From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.84]) by mx.groups.io with SMTP id smtpd.web10.27594.1653314331541628056 for ; Mon, 23 May 2022 06:58:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=YY+D2bqk; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.94.84, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y/rRDugfx1Ra89L8NdvSlAS/lEWSLzAtUn9CMhl620bOBEK5fC7/vkknMciAb19KK4Lnon6vTKpYz1N3JfjztGoXj6ITrhFkznkq3Rb7KWsVYOzXuh34cW2NNcE6p5p0nP8ySBb1OXWyF/FshvpmUb+9wazKAgfikjPVRl07VwkMb0B/hEM8glG2AqI6+PUF5sryGUwoXJ6ziuU1sV7gB6K2X+vdmkhVPxgEYyX+udARRoKRHl4MWzdOm7CYh7Xy9Tfo+aTgQ3Djs8Xwb5QFsqMxHyDxe0CG7odWm2jH12xr2uWJ2CuKHMf0hmCMOpptex8CJNQrYXhzMurFEas9JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tq8OTyuFHQZ/VaVwFEO5s42KM2oh7Kn6sf8TkKeALOU=; b=kxiibV64ClCD/16F5KljOJoG768UYD60SWKHsaYQ4zwuUXgIXYvBTesBGKOv0iOIWnq9DRJCTuJmfUGBZYYjaSJt/O5sLMIdi6n7iJx2lk1/534dvqpwe5gibg4gdQ4f6azXII7KXcOdF1/Emijwrh/pGBdLGgbP897QEoILzEIoEO3sQIRshu/SLmCKQhW9ppCJx/J3gJ6CVC0FrxXk1GlQvLKWzsvpvFud4+EYOwttXhkkxB0CB3lf6jsI5ykfOqensyiu46Md7pParBfJmZ+1zMwc4eK5Ygq7fGN53KMoDwGmWWGHoEHewVhNPf5y8UyWNO8J376PCrctWHTXrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tq8OTyuFHQZ/VaVwFEO5s42KM2oh7Kn6sf8TkKeALOU=; b=YY+D2bqkaaENhmgn0mWYuBcja1PHhl+gG0YgFGEvZh4f9yOcqI+LlrL08sLP/X7T51i5G84PQynQtDDsNnN5ZamY1dRWVPo+KuMn+IjNKmHSMh9XzsFgOzKbJJUBFrirPNd+0OwtiUNr0eNyzH3iQGdLpSq5yJ49KVcQNwFl038= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by BN6PR1201MB0097.namprd12.prod.outlook.com (2603:10b6:405:54::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Mon, 23 May 2022 13:58:49 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::db8:5b23:acf0:6f9a]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::db8:5b23:acf0:6f9a%4]) with mapi id 15.20.5273.019; Mon, 23 May 2022 13:58:49 +0000 Message-ID: Date: Mon, 23 May 2022 08:58:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 0/4] Fix AP Jump Table Handling for SEV-SNP To: Michael Roth , devel@edk2.groups.io Cc: "Ni, Ray" References: <20220520152730.7924-1-michael.roth@amd.com> From: "Lendacky, Thomas" In-Reply-To: <20220520152730.7924-1-michael.roth@amd.com> X-ClientProxiedBy: SN4PR0401CA0048.namprd04.prod.outlook.com (2603:10b6:803:2a::34) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f0cfb351-778e-4f3f-3bc6-08da3cc45cb4 X-MS-TrafficTypeDiagnostic: BN6PR1201MB0097:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RZC9G+BAwDBPi6C3V1TzugfQg+v4SJzidd8Eg0y4NuIsAbDr1/p1wOCHeuRRdfoDQk+2dLC0f0zPirkDRCAOgZwmCCdUtecFcQhi6PZlKYfL4KCQNkQHq3GLDwqzOr+URFoErEAxB1pHHWfzOfbQkC+EBxnw2wZRbaQZXIUbopmqf0al7aUzzQrWaiM7JVHCdA58qqBxyULwFiHSGuy5p2H3X3NIQ9U0PZqUFug/NORx2vusKm0O4e9tPmmE0bjmXCsf7MuBqCr9cmPJ9KTuOUjkyKkXo9mJYEulYrO02FKBIkqbejQpivJI1sTPi2P6m3SFWKet7lbpsfRFb2ctex33saF/d2GxmveHXkkyD1XoRVAlfy3Zc1sS8gw/Phmjtugzhh8xfXyUxaj34s/+m8RNNlUzzikUkxsY1E8tlh9d12vMUV76HwIoP9mWrYeWX26cjX++ZFf+2tqk40RZMgtccRMrCNMEKk+Zrdw5PppV6YGF/6GZ5PXGqvv010Z7BrMXq5rZvGlBuXGPgv3CgEhpDn5TotzemKtpP1qkNVYTxfn8e00LHB5sYQUiGpnlimgs/nmrW9EM9r+bMAS5l+vHWS64ENwvR3i59XqY2brM3S4bJrWUaqxh67M51HYa/zr/VSTtC8zOWs4Y3MK5gpKZoUQ7q/pY85S3Gqqw0cUhRDZ+aCRWT3BBMM8YWeMSLFAh7YH9L4YDKU/vCvx78v1YtkFJLybhuAaxCPtXSOWwqC6zebgiKDLxUThpPqjq X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(38100700002)(83380400001)(19627235002)(4326008)(8676002)(86362001)(2616005)(66946007)(66556008)(66476007)(31696002)(186003)(6486002)(508600001)(26005)(6512007)(6506007)(53546011)(8936002)(31686004)(2906002)(5660300002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ak5LdGhPRHlBdkFTdFRSbTdabGdQSmg2bW1RQ2Z5QUo0QlJqbHhjNHhZckdU?= =?utf-8?B?RFMwSDlENTNFdHVqbEJKelh4K2RDekxxTGZmbisrRE5QUGVkV0E3enZPcUk3?= =?utf-8?B?aEpYRTZFNGJJNTRoZjZJTWFMVWNmTlllc28wUnNqZlpkTW1XbFVqa3U5Y2Rt?= =?utf-8?B?dzNqQWxQVTBIM2RPbUMvM1ZjNDlIQVRYRWFVWnpsRDFLV0RZNmZqTE50MUdH?= =?utf-8?B?OHZDaU82TFlkYnVBbnNZVWxWNDl5MktIUEkvbFY1OU1VWFlNajNxSndYM2FW?= =?utf-8?B?Q3FLTm1BMUJna3NSWTZycmlodjVvZjlIaFpDQllTaDNJTHNzdVVZKzVHYnRw?= =?utf-8?B?RDV6VWgwanBQZ3gxTEU0cjJTckIrSUlhWTJVYzJwMUY4UEtSNFlncG54Tmp4?= =?utf-8?B?NzlidnBsRVBqRFd1WVNzK0RWRXBQV1BQTWNKemtwVTNQRnFYWW1jUi9mbVkv?= =?utf-8?B?L1dNVkxScjJNalpFb3pialR6b25RZS9STnA5ai9OcGlRaEVMNGdEWFVGT29U?= =?utf-8?B?RkFQN3NNZCtaYkJRTGx3eCtwTG5NOCtieU5zMFQzNUU1d3huTmNzblRwMnpW?= =?utf-8?B?UnpzQnQ0Szd3MlJLUlVxT3B4SXd1UWE0YWpQZ1lmQjVwT2VuSGRzM1hyc1Zx?= =?utf-8?B?aGNMSElDYWxwd3Y1RmcrbWVXT2c3Ky8zMXhGZGxhaWp2MmdLUXFoemdzMW4r?= =?utf-8?B?c09RQnR3M01qV0c3WUs1WTBMaThiSzFJRkRiNDlPMFpEbndXR3JteDRmV3Uv?= =?utf-8?B?Nzc3TXdsdGVOeVExU0lFcTB5MURiYnAvamIyUkdLYWRsQ3dyY0JabnlSWmlD?= =?utf-8?B?RXF6SDVNSG16Y2xvUXRpemlZZW5DdytDUnNySUUxamcwTklvQi9wVlBIRGJx?= =?utf-8?B?N3ZLTzU4ejVMcFVVcUVLaW1XSDRiWEVKSEdYUFdCT1RMNFQrZ2sxR2Y1Mm9y?= =?utf-8?B?UGdnWE9tRXNTWVJybTRESlhEWGYvdmJaalRxdDNldmpicU5QL21Ob0o1dHh1?= =?utf-8?B?T205aTFqRFdWOFFPTStzYUtrTjhZcTU5MldjN0FmRkhUZnk5a3lxMStLaUJs?= =?utf-8?B?VHpQNmk1aVZoejAxUUpGQ05EUWFESzczTytkVVNJOUZ1QzY4Z2RKbnJYaE00?= =?utf-8?B?bk93WHgySlVwcFIvNDBTQm1LQ3FtNGtzdzluaFhCdVhlOHYrRTMvNUt6bE1w?= =?utf-8?B?ZEhvTzVZeEFJalhVMkVkcHpXWm8xd3gvRG4yZTdzcWtEOGRvUmJlOXRLOGww?= =?utf-8?B?Q0QzaGI2OFQ3ci9sdkJ4STY5S1c1WkZ1c2dRN3N3VERIZmI3cmNKRC93OTlH?= =?utf-8?B?LzN2c2twaHUxeldaU2RNRk1USHplNlIxQmJlS3lsQ1loaTlvK0p3NUZxK216?= =?utf-8?B?YlFiV2J5UnhUbVlzalhDaU5Jajc0WmhKWmdZQkJGa2UwUHArWlNUVUdBNE9m?= =?utf-8?B?TDJwM2Q1YjJxOXdZaFY1cnl6ME5hY0pOWUh4dHdtUkY5UUQ0NzhoeFRJN01S?= =?utf-8?B?UFNaQjRadjRCL2FZeG5kY1FuV3BieUprUzlNNmNoN1ZwMGNyd0JjM2ZhVzM3?= =?utf-8?B?SUc5dE00WmRzcGVSM0VpbkJnZWZzd3JBSTEvd0cwVm52ZVZ4QnV4bHpxcGgr?= =?utf-8?B?TG1SdlppdzF3dmYzSkU0Q0t5Y2VQUmdJTlhhR2FwYTBrU2ludGxWbWJlc3Y0?= =?utf-8?B?eElINUNrZWNpZWUvUi9uSytYVVFyNXc4eW1jdGErdkVQd0pJcmlNRXN5OXpj?= =?utf-8?B?a0RjTEhaVmZJdWhGenIyY0prZGNEVkY0OW5OVUZsbHBlYkExYXJDQ25hYXIy?= =?utf-8?B?Sm1OeVlsNzlmVUVrbDMrQXZycGpENHpKOFU1emNndkRrOEtILzlNVHNEbElL?= =?utf-8?B?VCtBSXRmL1M3bElveEZPNHBzRHFwQXI1Q2ZkYkRFQ25iS2V3bkF6T0hvNlNt?= =?utf-8?B?SGxWRGozWmE0WlprdGdhZklrQyt4TzRNUmR0enVEYmVabGNKS3Z0ckU3TU1N?= =?utf-8?B?OHU5MW9ZTUlVcE85YWRHTDlqS09NMVJSQjVxdlcxSTJRRy9PL1JaeHdnb3Nw?= =?utf-8?B?QmpHd1NzTjR6c1JsSVhZRXNyYUVSMjVOR3hwU1NSdVBWQjVycGNHYU5EdW90?= =?utf-8?B?cHdVVlFGS2hoWFYreWhHN0JwTWc3cHluQThXclVZZEdBVGtOaXp2TWd2QzhP?= =?utf-8?B?L280Y2J5bWtkR2k1TytmRCt6N0Yzd1ZvNjhyVStROHJRNGpHR3RtdUFocW50?= =?utf-8?B?azk5WlFnYllCVFpoZ2JqSzNDU3lnN2p3cUh2UnQ0d25UNXJHNEdiU29tN2k5?= =?utf-8?B?ZFpnWlMrRldmNTBsZ09jL1RiV2xLOTAyQm5TdjF6QmpEK3hadkhndz09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0cfb351-778e-4f3f-3bc6-08da3cc45cb4 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 13:58:49.4637 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FDzSZ5/YX727kpJ2dochMI5iBhZ0o4gCf/6N5Obw9Q3IIa+lAMZEoxSVSpP7Nu06X2V0V2v+0frkViQ8utrseQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0097 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/20/22 10:27, Michael Roth wrote: > A full-featured SEV-SNP guest will not rely on the AP jump table, and > will instead use the AP Creation interface defined by the GHCB. However, > a guest is still allowed to use the AP jump table if desired. > > However, unlike with SEV-ES guests, SEV-SNP guests should not > store/retrieve the jump table address via GHCB requests to the > hypervisor, they should instead store/retrieve it via the SEV-SNP > secrets page. > > This series implements the store side of this for OVMF by introducing a > PCD that can be used to pass the SEV-SNP secrets page address to > UefiCpuPkg, where the jump table address is allocated. It also > introduces a struct that defines the SEV-SNP secrets page format > according to the GHCB v2.01 and SEV-SNP FW ABI specifications. > > v3: > - Break up single patch into a set of patches containing the specific > changes for each package. (Ray) > > v2: > - Update Secrets OS area to match latest GHCB 2.01 spec (Tom) > - Move Secrets header file into ./Register/AMD subdirectory (Tom) > - Fix CI EccCheck due to assignment in variable declaration Aside from the minor comment on patch 4, for the series: Reviewed-by: Tom Lendacky > > MdePkg/Include/Register/Amd/SnpSecretsPage.h | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > MdePkg/MdePkg.dec | 4 ++++ > OvmfPkg/AmdSev/AmdSevX64.dsc | 3 +++ > OvmfPkg/CloudHv/CloudHvX64.dsc | 3 +++ > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 3 +++ > OvmfPkg/Microvm/MicrovmX64.dsc | 3 +++ > OvmfPkg/OvmfPkgIa32.dsc | 3 +++ > OvmfPkg/OvmfPkgIa32X64.dsc | 3 +++ > OvmfPkg/OvmfPkgX64.dsc | 3 +++ > OvmfPkg/PlatformPei/AmdSev.c | 5 +++++ > OvmfPkg/PlatformPei/PlatformPei.inf | 1 + > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + > UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 10 ++++++++++ > 13 files changed, 98 insertions(+) > >