From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Siyuan Fu <siyuan.fu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Ye, Ting" <ting.ye@intel.com>,
"Wu, Jiaxin" <jiaxin.wu@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH v2 1/6] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.
Date: Mon, 10 Dec 2018 15:40:35 +0100 [thread overview]
Message-ID: <a03eb76a-8560-4af1-6984-c56013bd7e13@redhat.com> (raw)
In-Reply-To: <CAKv+Gu8y7ZD+iDbwEyTT-tJN3tFs-Huu_a_isxWFaHQ8488onw@mail.gmail.com>
Hi Ard,
On 12/10/18 09:36, Ard Biesheuvel wrote:
> Could anyone remind me why we have OpensslLib and OpensslLibCrypto?
> Since these are static libraries, only the referenced objects should
> be included in the final module anyway, so OpensslLibCrypto seems
> redundant to me.
please see commit 823005621ef4 ("CryptoPkg/OpensslLib: introduce
OpensslLibCrypto instance", 2017-02-25).
>> Namely, please *prepend* a patch to the series that simply deletes the
>> "[Components.IA32, Components.X64]" line, bringing all these drivers to
>> ARM/AARCH64, in the NetworkPkg.dsc build. Once we validate the new patch
>> separately (simply by test-building it), then the current patch can
>> simply replace the component list with the !include directive -- and
>> such a replacement won't incur arch-specific changes.
>>
>
> Ack
Liming and I strongly disagreed on this point, and I yielded. Please see
the sub-thread that ended with the following comment:
http://mid.mail-archive.com/e790855d-2cd9-1820-7187-0ec1dc52dabc@redhat.com
(Alternative link:
<https://lists.01.org/pipermail/edk2-devel/2018-November/032949.html>.)
[...]
Thanks
Laszlo
next prev parent reply other threads:[~2018-12-10 14:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 5:21 [PATCH v2 0/6] Add DSC/FDF include segment files for network stack Fu Siyuan
2018-11-22 5:21 ` [PATCH v2 1/6] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg Fu Siyuan
2018-11-22 9:56 ` Ni, Ruiyu
2018-11-22 10:52 ` Fu, Siyuan
2018-11-23 10:56 ` Laszlo Ersek
2018-12-10 8:36 ` Ard Biesheuvel
2018-12-10 14:40 ` Laszlo Ersek [this message]
2018-12-10 16:39 ` Ard Biesheuvel
2018-11-22 5:21 ` [PATCH v2 2/6] Nt32Pkg: Update DSC/FDF to use NetworkPkg's include fragment file Fu Siyuan
2018-11-22 5:21 ` [PATCH v2 3/6] ArmVirtPkg: " Fu Siyuan
2018-11-23 12:29 ` Laszlo Ersek
2018-11-23 12:30 ` Laszlo Ersek
2018-11-23 16:50 ` Laszlo Ersek
2018-11-22 5:21 ` [PATCH v2 4/6] EmulatorPkg: " Fu Siyuan
2018-11-22 5:21 ` [PATCH v2 5/6] OvmfPkg: " Fu Siyuan
2018-11-23 12:00 ` Laszlo Ersek
2018-11-23 12:10 ` Laszlo Ersek
2018-11-23 12:19 ` Laszlo Ersek
2018-11-22 5:21 ` [PATCH v2 6/6] Vlv2TbltDevicePkg: " Fu Siyuan
2018-11-22 6:14 ` [PATCH v2 0/6] Add DSC/FDF include segment files for network stack Gao, Liming
2018-11-22 15:48 ` Laszlo Ersek
2018-11-23 16:02 ` Gao, Liming
2018-11-23 18:35 ` Laszlo Ersek
2018-11-26 3:31 ` Gao, Liming
2018-11-26 11:34 ` Laszlo Ersek
2018-11-22 16:12 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a03eb76a-8560-4af1-6984-c56013bd7e13@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox