From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6D8DE2119AC24 for ; Mon, 10 Dec 2018 06:40:38 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CBD6631649A4; Mon, 10 Dec 2018 14:40:37 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-124-101.rdu2.redhat.com [10.10.124.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4161B5C1B4; Mon, 10 Dec 2018 14:40:36 +0000 (UTC) To: Ard Biesheuvel Cc: Siyuan Fu , "edk2-devel@lists.01.org" , "Ye, Ting" , "Wu, Jiaxin" , Leif Lindholm References: <20181122052153.89464-1-siyuan.fu@intel.com> <20181122052153.89464-2-siyuan.fu@intel.com> <6e29bd32-5d1c-17b3-dc70-de9cec0d781c@redhat.com> From: Laszlo Ersek Message-ID: Date: Mon, 10 Dec 2018 15:40:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 10 Dec 2018 14:40:38 +0000 (UTC) Subject: Re: [PATCH v2 1/6] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 14:40:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ard, On 12/10/18 09:36, Ard Biesheuvel wrote: > Could anyone remind me why we have OpensslLib and OpensslLibCrypto? > Since these are static libraries, only the referenced objects should > be included in the final module anyway, so OpensslLibCrypto seems > redundant to me. please see commit 823005621ef4 ("CryptoPkg/OpensslLib: introduce OpensslLibCrypto instance", 2017-02-25). >> Namely, please *prepend* a patch to the series that simply deletes the >> "[Components.IA32, Components.X64]" line, bringing all these drivers to >> ARM/AARCH64, in the NetworkPkg.dsc build. Once we validate the new patch >> separately (simply by test-building it), then the current patch can >> simply replace the component list with the !include directive -- and >> such a replacement won't incur arch-specific changes. >> > > Ack Liming and I strongly disagreed on this point, and I yielded. Please see the sub-thread that ended with the following comment: http://mid.mail-archive.com/e790855d-2cd9-1820-7187-0ec1dc52dabc@redhat.com (Alternative link: .) [...] Thanks Laszlo