From: "Sami Mujawar" <sami.mujawar@arm.com>
To: devel@edk2.groups.io, nhi@os.amperecomputing.com
Cc: patches@amperecomputing.com, Leif Lindholm <leif@nuviainc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Rebecca Cran <rebecca@nuviainc.com>, nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH 1/3] ArmPkg/SmbiosMiscDxe: Remove duplicate HII string definition
Date: Wed, 15 Dec 2021 17:08:10 +0000 [thread overview]
Message-ID: <a048c477-e6bd-85d8-652a-ce30cad1215a@arm.com> (raw)
In-Reply-To: <20211201041031.31824-2-nhi@os.amperecomputing.com>
Hi Nhi,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote:
> This patch removes duplicate HII string definition in the
> MiscSystemManufacturer.uni.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Rebecca Cran <rebecca@nuviainc.com>
> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
> ---
> ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni
> index 8038f0e4b0bf..2b3b19cab2ea 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni
> @@ -13,7 +13,6 @@
>
> #string STR_MISC_SYSTEM_MANUFACTURER #language en-US "Not Specified"
> #string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "Not Specified"
> -#string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "Not Specified"
> #string STR_MISC_SYSTEM_VERSION #language en-US "Not Specified"
> #string STR_MISC_SYSTEM_SERIAL_NUMBER #language en-US "Not Specified"
> #string STR_MISC_SYSTEM_SKU_NUMBER #language en-US "Not Specified"
next prev parent reply other threads:[~2021-12-15 17:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 4:10 [PATCH 0/3] ArmPkg/SMBIOS: Update HII string settings for SMBIOS Nhi Pham
2021-12-01 4:10 ` [PATCH 1/3] ArmPkg/SmbiosMiscDxe: Remove duplicate HII string definition Nhi Pham
2021-12-15 17:08 ` Sami Mujawar [this message]
2021-12-01 4:10 ` [PATCH 2/3] ArmPkg/SmbiosMiscDxe: Get full SMBIOS strings from OemMiscLib Nhi Pham
2021-12-15 17:19 ` [edk2-devel] " Sami Mujawar
2021-12-01 4:10 ` [PATCH 3/3] ArmPkg/ProcessorSubClassDxe: Get serial and part number " Nhi Pham
2021-12-15 18:47 ` [edk2-devel] " Sami Mujawar
2021-12-15 8:40 ` [edk2-devel] [PATCH 0/3] ArmPkg/SMBIOS: Update HII string settings for SMBIOS Ard Biesheuvel
2021-12-15 16:40 ` Rebecca Cran
2021-12-15 17:06 ` Sami Mujawar
2021-12-16 3:53 ` Nhi Pham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a048c477-e6bd-85d8-652a-ce30cad1215a@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox