From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.76]) by mx.groups.io with SMTP id smtpd.web08.1113.1639588101153784695 for ; Wed, 15 Dec 2021 09:08:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=67FuO/J2; spf=pass (domain: arm.com, ip: 40.107.22.76, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3TndOYN1IgqXwHwtN5o91lEwGIXSdMQI78EPyFvXIfY=; b=67FuO/J2jYn9tQfh5wVGhJTB6hsPV93N01FzVzTFvLto8TklqScXl5cT/0cQGURBTMArz+Bij/81/KwvytMiWqhGlCKtzLFbBDn3UxDyeu6p57dBkrFgksswIEcZmju/6lyDJWX6NbfGKu8hqLxzADP0hvjhKWfw9mFvyvBTV/8= Received: from FR3P281CA0086.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::13) by AS8PR08MB6021.eurprd08.prod.outlook.com (2603:10a6:20b:23c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Wed, 15 Dec 2021 17:08:17 +0000 Received: from VE1EUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1f:cafe::27) by FR3P281CA0086.outlook.office365.com (2603:10a6:d10:1f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.11 via Frontend Transport; Wed, 15 Dec 2021 17:08:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT050.mail.protection.outlook.com (10.152.19.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Wed, 15 Dec 2021 17:08:17 +0000 Received: ("Tessian outbound c61f076cbd30:v110"); Wed, 15 Dec 2021 17:08:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0db6b2f610bfe1f9 X-CR-MTA-TID: 64aa7808 Received: from 5fe4c2347856.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2E86A443-E174-42AB-AF1F-B579D1322125.1; Wed, 15 Dec 2021 17:08:05 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5fe4c2347856.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 15 Dec 2021 17:08:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e3/r/rdfGAJOjHTMSDRVHc9GEh/UBsWEZ3wLUOth5SaRSNUqKI4zwkJwXrv7s/InyDkjxizjNk6exehMgZpcSNInYcG8xOIf+Xy5jLq71+C8wt4+v9Obhrknc73AqdfueCqivnRDtIxkx645L6iSibV7dR25OTBQAy9NYSQntjlq8qXxmA3H0/LPoOR87aKWFSH6O5WNc/8OrWMs31RrGXEGRQD1lTPRrmvnkMFVauev+l1wjeu4vaIR64OZGVV4NRfA/8ykf0KBdc92ARDxUGVBaLVWpacyxzcNPJ0JzzmzJrp31Jj5KPOu7+oLHvdIt0kHu46IU3EaQ7BK+UwSKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3TndOYN1IgqXwHwtN5o91lEwGIXSdMQI78EPyFvXIfY=; b=W33f6oRhSaY/T7BepNGAUpCfV+O6BxSN7ssPqkJuFjDzK3lwUEg5iUUsv3TACoARQzrGIrsqRoRNzJ7BnTMEFHHoPZoSQc9gycIXGjOKDgXLBQQR0oJKyGHDz4HHggekFluJwln9F7bG5Pvx5zRfw3fclIVCyCxHkyVqPQxiTPD57YQSkcHMWiIM+0QptinVnBmE8F0WiAZuDlSdPXetvJxMjoSFGtbE3I7Or2CB73AcyDUFZ5IZlyFFRPwUekRgJri4r7dOiELs4bnOOHWoJaXIUavSTt6BRbr6dzmRSWnsX54LwVSC3lfxLGJe32jOU6i1Ll0/cS7ns1IvwbMFow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3TndOYN1IgqXwHwtN5o91lEwGIXSdMQI78EPyFvXIfY=; b=67FuO/J2jYn9tQfh5wVGhJTB6hsPV93N01FzVzTFvLto8TklqScXl5cT/0cQGURBTMArz+Bij/81/KwvytMiWqhGlCKtzLFbBDn3UxDyeu6p57dBkrFgksswIEcZmju/6lyDJWX6NbfGKu8hqLxzADP0hvjhKWfw9mFvyvBTV/8= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB3030.eurprd08.prod.outlook.com (2603:10a6:209:46::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Wed, 15 Dec 2021 17:08:03 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac%6]) with mapi id 15.20.4755.021; Wed, 15 Dec 2021 17:08:03 +0000 Subject: Re: [edk2-devel] [PATCH 1/3] ArmPkg/SmbiosMiscDxe: Remove duplicate HII string definition To: devel@edk2.groups.io, nhi@os.amperecomputing.com Cc: patches@amperecomputing.com, Leif Lindholm , Ard Biesheuvel , Rebecca Cran , nd References: <20211201041031.31824-1-nhi@os.amperecomputing.com> <20211201041031.31824-2-nhi@os.amperecomputing.com> From: "Sami Mujawar" Message-ID: Date: Wed, 15 Dec 2021 17:08:10 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211201041031.31824-2-nhi@os.amperecomputing.com> X-ClientProxiedBy: LO4P123CA0520.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::16) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.50) by LO4P123CA0520.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend Transport; Wed, 15 Dec 2021 17:08:02 +0000 X-MS-Office365-Filtering-Correlation-Id: 22e0ce25-3965-4797-73e1-08d9bfed7cd7 X-MS-TrafficTypeDiagnostic: AM6PR08MB3030:EE_|VE1EUR03FT050:EE_|AS8PR08MB6021:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2276;OLM:2276; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Y0e9GNMqyPGUobyr5AYFazISj3Rzx3u6akqylhsrNw8xkhbgzD6FSUGbb+vgW8h8CZmE7OgPbHJXEYUHpx5vYzS23Uxd9yebCr7eyTrM5SENR2k+fSGQvahgkuLQ9FI7iuGmTtZkjxZjRHjSphFbPVO/XnzlgsVeMuqOtzPEbgNzqtKUTCD64Vo5G4a0XFqZIpe0se5OfdB/i/Hq0ris+a7fbwaR9CzswATMJP93aYLlDoRYlmwx5wkSE4K/9KpUGFbOubfCcgMfQG6WsEXUPHT14hkYOICwlRzVsOFUxw7GhYDrp9IyeKY/zYf+v6U0z5qP6BfQF2x9zsQH55g+XYh97eblarpOh2+PBk82fWZlPFPPzMPxUnrqKpKmnGVrBejl21kWbV/nOsU6TRQNAMOg7rDcpcfNYVTO6q44yo6JJohiFjQjBykL8TWSedbOfjCDQQunnx9zisxZ2qeetpHVlXVrcF8nWVJ2+NmEJrzDND7WBhniuR4b7RmGNtKKKmvyuNG7KHj5xVcSyMgSiiFV43NRbjcMfQYebC+jYIjWGw4BX+9N5sA7tHPfXnXE2WtxWNe3C/A0YUzmQFVsEDNYG+I3qVlbP3o+DXRbXeRwXBk4immt9H7bP5trC45adiQQwqK8DjruNUOvgvXyT/lZ4q9jJ9sq2p5pqiwmmWebEirAoxPfhUyIvOZ+fG6oFpeA1ieTzcW1+w+OlC9Ed2DQjkVXeQyay140tOT3UEd5BQ8oAYp6S1JRiZ5NNFxfYJ9NKPjp/2/6NeN+wzcTIw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38350700002)(6486002)(186003)(38100700002)(86362001)(52116002)(31686004)(6666004)(36756003)(83380400001)(508600001)(16576012)(53546011)(66476007)(2906002)(66946007)(8676002)(5660300002)(316002)(66556008)(31696002)(4326008)(8936002)(956004)(26005)(2616005)(44832011)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3030 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 831804ab-7ece-472b-0747-08d9bfed7443 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nbUrwFR+MTRi5MRU9qRVx4CuoCk3ughbLRKMpH8dbNbwzbfGrUmDoKmYNzBd6JGz3+c10NmCzRaqk6nnTX38COnp4sePOkyR4A8ZVXaquyHptnnWkAHO9MHR2SsUdWq6QDOyJUlu4OJ/jtwj7PGx7wREs7XjmWHAoqyD+Q5oGCsf5nNvfOs0jA8AmImCWqHwxf1Iz71zQuuxSeSKGQJdIUDzuVlwl6dbgpIQ/UzzYFLF4ZY126sjX+UfTtvy4FaeWhBvCU8iX1MtEmGaJUlGprt9/EDfAInARwtgg0vQ2S71+Vkk6WG73EewrsNlUVRgtnPW2GjzwJbXSJOy617ceMbUXMqxkzCO5lo5tBuqBHgrG4i3ftqD77tqohm5QAoKPi2jgsnM5tFXZ9tgjUe8nF8x1s+7gsFQZRw96xC+wGF3KgF35fU+kDlh3xpCUPUY9+892XuMLXaxOzwrCOcJlHF4SMhJqeqTHMXVXW2tp0yGRHQeGcPu0XThpyk9aLkSdOA1cnMupOJUMQb0X0PRedjOUJFMHS+Pyft3iZym//R0eWXj0k+/bgrq1g1M/roU2gSAl6waTvjNibmsuo2LhGFYgQcWZecNibUiauMuUqDXuxIVm7EmQE3HiMqN8u1QxdEASzbBpM4hdi73QFHM2cVxo1Qz4p38hv5etDU1kiootw3SLdGRGqojjEJV67ZGgJQZWtVqs7SFZsyPG9ZlwNWcVHuGllAwOt7fUk3Y/I82wxpmub+qm2LO5k0GWCWVwDELsMhakLN7OJD8OPpysMwGcvyEyGlkfO9bZiu5ES8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(8936002)(47076005)(44832011)(83380400001)(31696002)(8676002)(336012)(70206006)(6666004)(54906003)(40460700001)(2616005)(36756003)(36860700001)(70586007)(508600001)(53546011)(86362001)(4326008)(6486002)(356005)(2906002)(186003)(26005)(316002)(956004)(5660300002)(82310400004)(81166007)(16576012)(31686004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 17:08:17.1191 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22e0ce25-3965-4797-73e1-08d9bfed7cd7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6021 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Nhi, Thank you for this patch. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote: > This patch removes duplicate HII string definition in the > MiscSystemManufacturer.uni. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Rebecca Cran > Signed-off-by: Nhi Pham > --- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni > index 8038f0e4b0bf..2b3b19cab2ea 100644 > --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni > +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni > @@ -13,7 +13,6 @@ > > #string STR_MISC_SYSTEM_MANUFACTURER #language en-US "Not Specified" > #string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "Not Specified" > -#string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "Not Specified" > #string STR_MISC_SYSTEM_VERSION #language en-US "Not Specified" > #string STR_MISC_SYSTEM_SERIAL_NUMBER #language en-US "Not Specified" > #string STR_MISC_SYSTEM_SKU_NUMBER #language en-US "Not Specified"