From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 60F3B2119489E for ; Fri, 23 Nov 2018 04:30:50 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E032B5AFF5; Fri, 23 Nov 2018 12:30:49 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-112.rdu2.redhat.com [10.10.120.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A4471055007; Fri, 23 Nov 2018 12:30:48 +0000 (UTC) From: Laszlo Ersek To: Fu Siyuan Cc: edk2-devel@lists.01.org, Ard Biesheuvel References: <20181122052153.89464-1-siyuan.fu@intel.com> <20181122052153.89464-4-siyuan.fu@intel.com> Message-ID: Date: Fri, 23 Nov 2018 13:30:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 23 Nov 2018 12:30:49 +0000 (UTC) Subject: Re: [PATCH v2 3/6] ArmVirtPkg: Update DSC/FDF to use NetworkPkg's include fragment file. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 12:30:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/23/18 13:29, Laszlo Ersek wrote: > (2) This is good, and the end result that we want; however, it does two > things at once -- it eliminates the MdeModulePkg network drivers, and it > adopts the NetworkPkg includes. > > In OvmfPkg, we handled the first step separately, in commit d2f1f6423bd1 > ("OvmfPkg: Replace obsoleted network drivers from platform DSC/FDF.", > 2018-11-06). > > I'm not proposing that we separate out the same change for ArmVirtPkg as > well. After all, we can consider the current patch as a *means* to > implementing the same -- just better. So, what I propose is, please add > the following to the commit message: > > This change automatically ports OvmfPkg commit d2f1f6423bd1 > ("OvmfPkg: Replace obsoleted network drivers from platform > DSC/FDF.", 2018-11-06) to NetworkPkg. Argh, obviously, I meant "... to ArmVirtPkg". :) Thanks, Laszlo