From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 425D81A1E00 for ; Wed, 3 Aug 2016 04:21:59 -0700 (PDT) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CEC3E7AE94; Wed, 3 Aug 2016 11:21:58 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-59.phx2.redhat.com [10.3.116.59]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u73BLv4f006194; Wed, 3 Aug 2016 07:21:58 -0400 To: Ard Biesheuvel References: <1470212464-28071-1-git-send-email-ard.biesheuvel@linaro.org> <1470212464-28071-2-git-send-email-ard.biesheuvel@linaro.org> <7ab6eb2f-30d8-a3b1-071e-b407c4a9fd3b@redhat.com> Cc: "edk2-devel@lists.01.org" , Leif Lindholm From: Laszlo Ersek Message-ID: Date: Wed, 3 Aug 2016 13:21:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 03 Aug 2016 11:21:58 +0000 (UTC) Subject: Re: [PATCH 1/2] EmbeddedPkg: make PrePiMemoryAllocationLib a SEC type library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2016 11:21:59 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 08/03/16 12:00, Ard Biesheuvel wrote: > On 3 August 2016 at 11:56, Laszlo Ersek wrote: >> On 08/03/16 10:21, Ard Biesheuvel wrote: >>> This library is only used by the various PrePi implementations, all of >>> which are of type SEC. >> >> You can actually enforce that client module type restriction, by setting >> >> LIBRARY_CLASS = MemoryAllocationLib|SEC >> >> Can you try that, in addition to the MODULE_TYPE change? >> >> Just an idea, of course. >> > > That is a valid point, but it is kind of orthogonal to the issue I am > trying to solve. > > In patch #2, I override the CC flags for SEC and BASE type modules, > but this static library gets build with the PEIM rules in effect, so I > don't really mind if anyone uses this module elsewhere. I could > perhaps simply change the type to BASE as well. Hm, after your explanation, I think your current patch is good. Reviewed-by: Laszlo Ersek