From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.1898.1587587766081004522 for ; Wed, 22 Apr 2020 13:36:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MHb+qSmj; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587587765; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jv8bLVvA6VrZPfAGXW70AJ9lwnDiNJSFBoxD2ryfnyo=; b=MHb+qSmjAYQDbXQWmvViVqur2PhSzjQS5g9Jf6686A1Nc/WY+YjemknBsyfexSTurk2xqa 6f1hJ4qcKSgKsonkR4bM1V5Q29zNlKMA4EU67U152JGe9XZZxc5jkMYYj3jADDXDIN8Zj8 h2bidY5C1UdxgQgu1WR4WpLe90bF8Yk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-36-sdz2NdhWMwahZCT1BzQRVg-1; Wed, 22 Apr 2020 16:35:56 -0400 X-MC-Unique: sdz2NdhWMwahZCT1BzQRVg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1D251801504; Wed, 22 Apr 2020 20:35:55 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-154.ams2.redhat.com [10.36.113.154]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1B68E19C70; Wed, 22 Apr 2020 20:35:52 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 0/6] OvmfPkg/ResetSystemLib: clean up, refactor, fix From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Rebecca Cran Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20200417153751.7110-1-lersek@redhat.com> Message-ID: Date: Wed, 22 Apr 2020 22:35:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200417153751.7110-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/17/20 17:37, Laszlo Ersek wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2675 > Repo: https://pagure.io/lersek/edk2.git > Branch: rsl_cleanup >=20 > Rebecca's >=20 > [PATCH 02/13] OvmfPkg: support powering off bhyve guests >=20 > at >=20 > https://edk2.groups.io/g/devel/message/57450 > http://mid.mail-archive.com/e4e9b29189b83076e1d1a0b9c989938f5226cab6.15= 86991816.git.rebecca@bsdio.com >=20 > made me realize OvmfPkg/ResetSystemLib should be refreshed. This will > let us add a simple bhyve-specific instance (later), and also allows us > to fix a long time dormant bug (now). >=20 > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daud=C3=A9 > Cc: Rebecca Cran >=20 > Thanks, > Laszlo >=20 > Laszlo Ersek (6): > OvmfPkg/ResetSystemLib: wrap long lines > OvmfPkg/ResetSystemLib: clean up library dependencies > OvmfPkg/ResetSystemLib: improve coding style in ResetSystem() > OvmfPkg/ResetSystemLib: factor out ResetShutdown() > OvmfPkg/ResetSystemLib: rename to BaseResetSystemLib > OvmfPkg/ResetSystemLib: introduce the DxeResetSystemLib instance >=20 > OvmfPkg/OvmfPkgIa32.dsc = | 8 +- > OvmfPkg/OvmfPkgIa32X64.dsc = | 8 +- > OvmfPkg/OvmfPkgX64.dsc = | 8 +- > OvmfPkg/OvmfXen.dsc = | 6 +- > OvmfPkg/Library/ResetSystemLib/{ResetSystemLib.inf =3D> BaseResetSystemL= ib.inf} | 12 ++- > OvmfPkg/Library/ResetSystemLib/DxeResetSystemLib.inf = | 43 ++++++++++ > OvmfPkg/Library/ResetSystemLib/BaseResetShutdown.c = | 51 ++++++++++++ > OvmfPkg/Library/ResetSystemLib/DxeResetShutdown.c = | 62 +++++++++++++++ > OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c = | 84 +++++--------------- > 9 files changed, 209 insertions(+), 73 deletions(-) > rename OvmfPkg/Library/ResetSystemLib/{ResetSystemLib.inf =3D> BaseReset= SystemLib.inf} (65%) > create mode 100644 OvmfPkg/Library/ResetSystemLib/DxeResetSystemLib.inf > create mode 100644 OvmfPkg/Library/ResetSystemLib/BaseResetShutdown.c > create mode 100644 OvmfPkg/Library/ResetSystemLib/DxeResetShutdown.c >=20 Merged as commit range c6a60cf4b990..93f6df5f3b25, via . Thanks Laszlo