From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web11.29701.1669853090091800811
 for <devel@edk2.groups.io>;
 Wed, 30 Nov 2022 16:04:50 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=YfVcsMCY;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id 8A99120B83C5;
	Wed, 30 Nov 2022 16:04:47 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8A99120B83C5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1669853089;
	bh=b4HkqVBq7EY5cu2we93hrGIj7PNbie0ve+TTlNGJvjs=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=YfVcsMCYUs23DIcf3GRQy8XsJKrNad3koP8Mg4NYOraQi+jADZPHALfBYz4F4De9s
	 3jm1pmGdZPZPAN9R5wITtgasniiJWFziJuxV6fWe9uCY1CLLYS35NsXUWGIWhY9fz+
	 dNQckLnXW5QrkQshqkcIjH5+DrUg26E5+AwyUugY=
Message-ID: <a0a31d71-6d6e-d204-b66b-e9d15c7b3bba@linux.microsoft.com>
Date: Wed, 30 Nov 2022 19:04:46 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [edk2-devel] [PATCH v9 02/12] OvmfPkg: CI: use Python version from defaults template
To: devel@edk2.groups.io, osteffen@redhat.com
Cc: Andrew Fish <afish@apple.com>, Ard Biesheuvel
 <ardb+tianocore@kernel.org>, Bob Feng <bob.c.feng@intel.com>,
 Daniel Schaefer <git@danielschaefer.me>, Gerd Hoffmann <kraxel@redhat.com>,
 Jiewen Yao <jiewen.yao@intel.com>, Jordan Justen
 <jordan.l.justen@intel.com>, Leif Lindholm <quic_llindhol@quicinc.com>,
 Liming Gao <gaoliming@byosoft.com.cn>,
 Michael D Kinney <michael.d.kinney@intel.com>, Ray Ni <ray.ni@intel.com>,
 Sami Mujawar <sami.mujawar@arm.com>, Sean Brogan
 <sean.brogan@microsoft.com>, Sunil V L <sunilvl@ventanamicro.com>,
 Yuwei Chen <yuwei.chen@intel.com>, Zhiguang Liu <zhiguang.liu@intel.com>,
 Pawel Polawski <ppolawsk@redhat.com>, Chris Fernald <chfernal@microsoft.com>
References: <20221130220125.1112760-1-osteffen@redhat.com>
 <CA+bRGFo8ad2KKLEXu+2-R57YQbTmQopDBmXBFOc74eT4ooi4wQ@mail.gmail.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <CA+bRGFo8ad2KKLEXu+2-R57YQbTmQopDBmXBFOc74eT4ooi4wQ@mail.gmail.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Like patch v9 1/12, I suggest updating Ubuntu-GCC5.yml in 
OvmfPkg/PlatformCI/.azurepipelines to use the template in this patch.

On 11/30/2022 5:01 PM, Oliver Steffen wrote:
> Use the default Python version from the defaults template
> (.azurepipelines/templates/defaults.yml) in the Windows
> CI jobs.
> 
> Previous changes to the CI job templates make it necessary
> to specify a version number, if Python shall be pulled
> at CI runtime.
> 
> The Linux CI jobs will use Python from the container image,
> so these changes are for Windows only.
> 
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
>   OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> index 7d6344d6383d..7e63f419b26b 100644
> --- a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> +++ b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> @@ -14,6 +14,10 @@ trigger:
>   pr:
>     - master
>     - stable/*
> +
> +variables:
> +  - template: ../../../.azurepipelines/templates/defaults.yml
> +
>   jobs:
>     - job: Platform_CI
>       variables:
> @@ -133,6 +137,7 @@ jobs:
>           build_file: $(Build.File)
>           build_flags: $(Build.Flags)
>           run_flags: $(Run.Flags)
> +        usePythonVersion: ${{ variables.default_python_version }}
>           extra_install_step:
>           - powershell: choco install qemu --version=2021.5.5;
> Write-Host "##vso[task.prependpath]c:\Program Files\qemu"
>             displayName: Install QEMU and Set QEMU on path # friendly
> name displayed in the UI