From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D67C5AC100D for ; Thu, 12 Oct 2023 12:14:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0xFGVVq2mf5EqsMU+oCiwzSd7EomeOuszakt6Ii2ZNA=; c=relaxed/simple; d=groups.io; h=Subject:To:Cc:References:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1697112851; v=1; b=XLZlqRtV6cHq+xchePPIqOktD35mYuwH5fRBDxcuGdXnlsBo+PXhyVwx51QYEdRbfXQXBQkO hLFx6bcJxRypVE3YdEhUtavWpdqUUBHgxgcLqsO4QWgetLE2ZlJkWKU4nrP7wNb4dGukEafo8tF i397z7j66/uAXN+8KtpqKRY4= X-Received: by 127.0.0.2 with SMTP id a6DFYY7687511xiV588Nxj0N; Thu, 12 Oct 2023 05:14:11 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.9591.1697112849526802966 for ; Thu, 12 Oct 2023 05:14:10 -0700 X-Received: from loongson.cn (unknown [10.20.42.32]) by gateway (Coremail) with SMTP id _____8Dx_+sN4ydlJ10xAA--.28430S3; Thu, 12 Oct 2023 20:14:05 +0800 (CST) X-Received: from [10.20.42.32] (unknown [10.20.42.32]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxPC8I4ydlBuIhAA--.3221S2; Thu, 12 Oct 2023 20:14:02 +0800 (CST) Subject: Re: [edk2-devel] [edk2-platforms PATCH 14/19] LoongArchQemuPkg/LsRealTimeClockLib: hide LibRtcVirtualNotifyEvent To: devel@edk2.groups.io, lersek@redhat.com Cc: Bibo Mao , Chao Li References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012090950.108577-1-lersek@redhat.com> <20231012090950.108577-15-lersek@redhat.com> From: "xianglai" Message-ID: Date: Thu, 12 Oct 2023 20:14:00 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20231012090950.108577-15-lersek@redhat.com> X-CM-TRANSID: AQAAf8DxPC8I4ydlBuIhAA--.3221S2 X-CM-SenderInfo: 5ol0xt5qjotxo6or00hjvr0hdfq/ X-Coremail-Antispam: 1Uk129KBj93XoWxXw15CryxKFy5CFWrtF1xCrX_yoW5GF1kpr yUWayxKr4jqr4avayfW345uFZY9anIyF4DJr4vkw48KrykJ3W8tFnrArn8Xr4UXr12ka40 qw18Kw42y3Z8u3gCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvIb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07 AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02 F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw 1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7Cj xVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r 1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07j8 yCJUUUUU= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lixianglai@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: cYRTyUfKq5hiha31G22rlu5Tx7686176AA= Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=XLZlqRtV; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Laszlo Ersek: > The RealTimeClockLib class header in edk2 mistakenly declares a function > called LibRtcVirtualNotifyEvent(). No component ever calls this function > crossing module boundaries; all RealTimeClockLib instances in edk2 and > edk2-platforms are supposed to register (and do register) their > SetVirtualAddressMap() notification functions. > > Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it > static, in preparation for removing the LibRtcVirtualNotifyEvent() > declaration from the lib class header later. > > Build-tested only (with "Loongson.dsc"). > > Cc: Bibo Mao > Cc: Chao Li > Cc: Xianglai li > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 > Signed-off-by: Laszlo Ersek > --- > Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTim= eClockLib.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLi= b/LsRealTimeClockLib.c b/Platform/Loongson/LoongArchQemuPkg/Library/LsRealT= imeClockLib/LsRealTimeClockLib.c > index 4315c2074d2f..eeac011a9400 100644 > --- a/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRea= lTimeClockLib.c > +++ b/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRea= lTimeClockLib.c > @@ -180,9 +180,10 @@ LibSetWakeupTime ( > @param[in] Event The Event that is being processed > @param[in] Context Event Context > **/ > +STATIC > VOID > EFIAPI > -LibRtcVirtualNotifyEvent ( > +VirtualNotifyEvent ( > IN EFI_EVENT Event, > IN VOID *Context > ) > @@ -325,7 +326,7 @@ LibRtcInitialize ( > Status =3D gBS->CreateEventEx ( > EVT_NOTIFY_SIGNAL, > TPL_NOTIFY, > - LibRtcVirtualNotifyEvent, > + VirtualNotifyEvent, > NULL, > &gEfiEventVirtualAddressChangeGuid, > &mRtcVirtualAddrChangeEvent > This patch was compiled and tested on loongson without problems, and=20 modification is agreed. Thanks, xianglai. > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109569): https://edk2.groups.io/g/devel/message/109569 Mute This Topic: https://groups.io/mt/101914663/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-