From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web08.5903.1631970909242665441 for ; Sat, 18 Sep 2021 06:15:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=SkhAZglZ; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: jejb@linux.ibm.com) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18I7iAvd017914; Sat, 18 Sep 2021 08:15:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : reply-to : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=vYcvYBUihKUUMwsIb29EJFirmh6SVSFfWenLFZ4Uha8=; b=SkhAZglZqFwI4x8K3pz050Y1wIMaKVHNij3CsfXqFflptIHIcvOsObK9xf9PaxqHz/0V WuDT+dafASD2/SC43n3/ewugiv+U4vF4DcCeM9jrIoSawvgIsfoBt6AIkg16fattREZ6 VfZxJkroRl2/YC/30K2z2SoqjEZvKKJlGe6f6jd2f4RubThXkEqKEPY7O8JcTviNlcFW kuO24pZAhX6SlXAitpuA3X6B5LFBA4TzH9TikI02YY8+NnghUtUMuZXvaOpWO3K+HZ2Y Byr6IwwSKEoAfttJU4QNfV9NPXMA7wJhF8vrkrmxBtl/4OPfiSe54xSIbm2DPVLvcCxx zw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3b5bywtwg2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 18 Sep 2021 08:15:05 -0400 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 18IC9D5e006104; Sat, 18 Sep 2021 08:15:05 -0400 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com with ESMTP id 3b5bywtwfu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 18 Sep 2021 08:15:05 -0400 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 18ICDCDB017062; Sat, 18 Sep 2021 12:15:04 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma01wdc.us.ibm.com with ESMTP id 3b57r8vks7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 18 Sep 2021 12:15:04 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 18ICF3n134996708 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 18 Sep 2021 12:15:03 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3A09678067; Sat, 18 Sep 2021 12:15:03 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E467678066; Sat, 18 Sep 2021 12:15:01 +0000 (GMT) Received: from jarvis.lan (unknown [9.211.54.195]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Sat, 18 Sep 2021 12:15:01 +0000 (GMT) Message-ID: Subject: Re: [edk2-devel] [PATCH V6 1/1] OvmfPkg: Enable TDX in ResetVector From: "James Bottomley" Reply-To: jejb@linux.ibm.com To: Brijesh Singh , "Xu, Min M" , "devel@edk2.groups.io" , Vishal Annapurve Cc: Ard Biesheuvel , "Justen, Jordan L" , Gerd Hoffmann , Erdem Aktas , "Yao, Jiewen" , Tom Lendacky Date: Sat, 18 Sep 2021 08:15:00 -0400 In-Reply-To: <3069705d-bf76-bcb7-e94f-dec9d19b47d6@amd.com> References: <2d085336-386b-8492-5f0e-ce9e0c49e8b6@amd.com> <9757562a-d155-be50-45fe-926ce9427e1b@amd.com> <3069705d-bf76-bcb7-e94f-dec9d19b47d6@amd.com> User-Agent: Evolution 3.34.4 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: g9Ucj6ouzys_djikdoQ2mJS1ZoAViOnt X-Proofpoint-GUID: oFvhDwQ1bkO1xvuPraAJ0O8Yr4Zps7fS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-18_04,2021-09-17_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 malwarescore=0 mlxscore=0 impostorscore=0 clxscore=1015 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109180084 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Sat, 2021-09-18 at 06:30 -0500, Brijesh Singh wrote: > On 9/18/21 12:16 AM, Xu, Min M wrote: [...] > > I usually do the development in windows and build the OVMF image > > with VS2019. > > If the new feature works, then I cherry-pick the patch-sets to code > > base in ubuntu 18.04 and build/test the new feature. > > > > The weird thing is that, with VS2019, even the OVMF image is built > > from edk2-master, such image doesn't work on AMD SEV server either. > > But if the image is built by Ubuntu 18.04, it does work on AMD SEV > > server. > > This seems very strange that we are failing to execute the hand > written assembly code. I am wondering if somehow the VS compiler is > generating a wrong byte code and thus causing a trap on KVM that > requires emulation. This theory should be verifiable by doing objdump on the windows binary ... can someone do that? James