public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "levi.yun" <yeoreum.yun@arm.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "nd@arm.com" <nd@arm.com>, "sami.mujawar@arm.com" <sami.mujawar@arm.com>
Subject: [edk2-devel] [Question] using Flexible Array Member in Structure.
Date: Wed, 3 Apr 2024 10:27:12 +0100	[thread overview]
Message-ID: <a0f22482-e945-4f24-a64f-ad7ed62420bb@arm.com> (raw)

Hello all!

while I see the code. I have one question related using Flexible Array 
Member.

For example)

///
/// Socket Type Data.
///
typedef struct {
   EFI_ACPI_6_4_PMTT_COMMON_MEMORY_DEVICE CommonMemoryDeviceHeader;
   UINT16 SocketIdentifier;
   UINT16 Reserved;
   // EFI_ACPI_6_4_PMTT_COMMON_MEMORY_DEVICE MemoryDeviceStructure[];
} EFI_ACPI_6_4_PMTT_SOCKET_TYPE_DATA;

In here, why MemoryDeviceStructure should remain with comments?

IIUC, edk2 coding style guide doesn't seem to prevent use of Flexible 
Array Member which is C99 standard.

And consider the compiler used to compile edk2 uses defaults standard 
above of C99 standard.

Couldn't I use the flexible array member like:

///
/// Socket Type Data.
///
typedef struct {
   EFI_ACPI_6_4_PMTT_COMMON_MEMORY_DEVICE CommonMemoryDeviceHeader;
   UINT16 SocketIdentifier;
   UINT16 Reserved;
   EFI_ACPI_6_4_PMTT_COMMON_MEMORY_DEVICE  MemoryDeviceStructure[]
}

Thanks!


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117365): https://edk2.groups.io/g/devel/message/117365
Mute This Topic: https://groups.io/mt/105305209/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



             reply	other threads:[~2024-04-03  9:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03  9:27 levi.yun [this message]
2024-04-03 16:17 ` [edk2-devel] [Question] using Flexible Array Member in Structure Michael D Kinney
2024-04-05  6:43   ` levi.yun
2024-04-05  7:29     ` Pedro Falcato
2024-04-05  7:34 ` Pedro Falcato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0f22482-e945-4f24-a64f-ad7ed62420bb@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox