From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.1225.1673030447035767262 for ; Fri, 06 Jan 2023 10:40:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=YR+TQvnl; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 306I4ZrO007954; Fri, 6 Jan 2023 18:40:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=IuhjAD6SMccyIpXSP6O3oRCxM+iYjkhyZTpPCLbVgfU=; b=YR+TQvnlcGp9YYZtUkWocPH7hW5HS0FdQz7/w7ponqxQuexnRy6nFuHzu/o3MPlhFRNQ MT+3U4psjlwH5agOUxXVx9tvR5prfZ+9egy8zOCHhM3lievqFnu2FqMWCoTZNUlRZZCO dA7FHxgX9xBsD8bbrrmXvEg1EXyaft40Qhgncvy5RfY5X6vppwdwV0WK9DNsk5GqPZWk RhylhxmRwIiXeriunX+ZQpyWZvLfPDYCa3AIHwKNmuEonfJ3Bwz3G29H4VLmjUhf2fQX 9lpt6KQOCTXd78NvGDWYVzrWG9ZaHYyWi/t+NurEahdMAAS8R/9VArxnxgmH+FBqeVOk GA== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3mx3f32wp0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Jan 2023 18:40:34 +0000 Received: from nasanex01b.na.qualcomm.com (corens_vlan604_snip.qualcomm.com [10.53.140.1]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 306IeXig002937 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 6 Jan 2023 18:40:33 GMT Received: from [10.110.23.237] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Fri, 6 Jan 2023 10:40:32 -0800 Message-ID: Date: Fri, 6 Jan 2023 11:40:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [edk2-devel] [PATCH v4 3/3] MdeModulePkg: Add new Application/MpServicesTest application To: Laszlo Ersek , , CC: Sami Mujawar , Ard Biesheuvel , Leif Lindholm , "Jian J Wang" , Liming Gao , "Tiger Liu" References: <20230104153727.345236-1-rebecca@quicinc.com> <20230104153727.345236-4-rebecca@quicinc.com> <5da2a432-e609-4c3a-1b65-048da876bf0b@redhat.com> From: "Rebecca Cran" In-Reply-To: <5da2a432-e609-4c3a-1b65-048da876bf0b@redhat.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 5KBhobmzRU17U4N3XNH6bBqbgzhjq8ys X-Proofpoint-ORIG-GUID: 5KBhobmzRU17U4N3XNH6bBqbgzhjq8ys X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-06_12,2023-01-06_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1011 priorityscore=1501 bulkscore=0 mlxscore=0 mlxlogscore=846 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301060143 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 1/6/23 04:02, Laszlo Ersek wrote: > The ShellLib dependency was incorrectly used for bringing in > "gEfiShellParametersProtocolGuid". But "gEfiShellParametersProtocolGuid" > is a standard protocol GUID, it is declared in "MdePkg/MdePkg.dec". So > you just need to spell it out in the [Protocols] section. > > And then (IIUC) no invalid cross-Pkg dependency remains. > > (The INF file was not right in the first place: the ShellLib class comes > from "ShellPkg/ShellPkg.dec", but that DEC file is not listed in the INF > file's [Packages] section.) Oh, thanks! -- Rebecca Cran