From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web09.5630.1582817015662798028 for ; Thu, 27 Feb 2020 07:23:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OeW5sQnY; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582817014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WxrGKcoVn5kpCUWPS4mwvKgF/Sv29hseiwPoTZrtcZs=; b=OeW5sQnYls7rQ1dh0NlBOafjecY2c3bkJOd/qPXGi8yHJzR/ahsA3JwQeaHKURrTMDTimd U5mfIlI2kNF0A1kXWHgYBHTFYE2gs2tVcslVkV7M2clohzBG4nv4AsGyfn0wUntVdtyW0z u22zSnipXmZYOkI2HisDywlmMPTfuSQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-281-vXcAG1mHPYy1tCzVdX2vAg-1; Thu, 27 Feb 2020 10:23:32 -0500 X-MC-Unique: vXcAG1mHPYy1tCzVdX2vAg-1 Received: by mail-wr1-f71.google.com with SMTP id w6so1436113wrm.16 for ; Thu, 27 Feb 2020 07:23:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WxrGKcoVn5kpCUWPS4mwvKgF/Sv29hseiwPoTZrtcZs=; b=WOvufnLWrli7a0n89L5c393jX8cnk2cwi9LdwgmjrgQobOpnE8l8OSNJGlHqI029yg dCtvnH12K7oTgwUYqYJPUpWt+0w4PDqStgMPWziDG3XjPRPr9QIWCGK8YQOi6xWoD9fe xMWzPF/PqZCfGl/tUVySxAAeyh2BkcossDZ1nXec+7QRHrdzdB43+bhQGFE/szFbSYfr E2V3QqTR/VWcuOnTXJ36FpzkF465XZ+XdnokJPGEXJPYjGKgPmfv8LZohcLIr8mMcjbn LEU2vIBCbwCUAOXTdL9h4dWU8gK4l7W4o2qUm6vLhx8TGexGjzP3Ni+nNg8VUOxqt4Wd lrUQ== X-Gm-Message-State: APjAAAWqeioNUaEollYClPZ5z2Cw/uC3Cb0lbXyM0dB/QQP52QFdsjeQ lVsmg6T/EpgqlksH2C6vNdihy+t8vYGAtTicPCQJMmyqlF+jXkTkLX8CNfPcAXxwtXuOAtAOdCO 7K5QVYAOgWNvS2A== X-Received: by 2002:a7b:c395:: with SMTP id s21mr11126wmj.121.1582817011365; Thu, 27 Feb 2020 07:23:31 -0800 (PST) X-Google-Smtp-Source: APXvYqxjJuWTobjQQSd/YM92dlAicu5JgGwYuP2JUB+Qo+CqUJBeNL93UU1I8yD8se6RbVx+bSRVZw== X-Received: by 2002:a7b:c395:: with SMTP id s21mr11099wmj.121.1582817011111; Thu, 27 Feb 2020 07:23:31 -0800 (PST) Return-Path: Received: from [192.168.1.35] (47.red-88-21-205.staticip.rima-tde.net. [88.21.205.47]) by smtp.gmail.com with ESMTPSA id v8sm8196672wrw.2.2020.02.27.07.23.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Feb 2020 07:23:30 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v4 02/11] ArmVirtPkg/PlatformPeiLib: make PcdLib dependency explicit in .INF To: devel@edk2.groups.io, ard.biesheuvel@linaro.org Cc: lersek@redhat.com, eric.auger@redhat.com, marcandre.lureau@redhat.com, stefanb@linux.ibm.com, leif@nuviainc.com References: <20200227144056.56988-1-ard.biesheuvel@linaro.org> <20200227144056.56988-3-ard.biesheuvel@linaro.org> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Thu, 27 Feb 2020 16:23:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200227144056.56988-3-ard.biesheuvel@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 2/27/20 3:40 PM, Ard Biesheuvel wrote: > We currently include PcdLib.h in PlatformPeiLib, without declaring > this dependency in its .INF description. Since all the PCDs we use > resolve to fixed type in practice, this does not really matter at > the moment, but since we will be adding dynamic PCD references in > a subsequent patch, let's make the PcdLib dependency explicit, so > that its dispatch is guaranteed to be ordered correctly with respect > to the provider of the dynamic PCD PPI. > > Signed-off-by: Ard Biesheuvel > Reviewed-by: Laszlo Ersek > --- > ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.inf b/ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.inf > index 46db117ac28e..5428040f121d 100644 > --- a/ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.inf > +++ b/ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.inf > @@ -29,6 +29,7 @@ [LibraryClasses] > DebugLib > HobLib > FdtLib > + PcdLib > > [FixedPcd] > gArmTokenSpaceGuid.PcdFvSize > Reviewed-by: Philippe Mathieu-Daude