From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web11.746.1596474739842053528 for ; Mon, 03 Aug 2020 10:12:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=eteqLtMS; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.66, mailfrom: pete@akeo.ie) Received: by mail-wr1-f66.google.com with SMTP id y3so34919746wrl.4 for ; Mon, 03 Aug 2020 10:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8/GbD3FDIdC+xwJryzi56miwdnYivTa/EuOK6NIQpw4=; b=eteqLtMSTW9blaDPulh+L8bEcRSMkriuR/GSdFsl36P4ksBIJg8v96g6tY85DgRqLf iLwgYI2w9006btWADpczRRPUn66r7PlkVsSfOWlclpXduxTxR60uZEqcMfXi+9ZdB1V8 k9L5icOk2CxYEUKaNt3Z6UUdgLY0X5sHkKPOC3PAFaYwoJgLna7ZUBw7nB4bVR4a6R2b FFqGX+/mqRlFnFMi4vpt8n8p49LASgLmy3RzWS6hSfamPlNrt8KFWjyTmFPeUtGn8xk3 fkcEpCRST7OkfytuxHjQdFnw6m19DGaIYzGZ3GihO4eakMZgyHLD3IjASq6L9t9PTE6/ hLig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8/GbD3FDIdC+xwJryzi56miwdnYivTa/EuOK6NIQpw4=; b=Y13eMCQM5fhhQBaFfR9uDAXWH183TRs2l1j8eMpnLmHrvDqYoqvfwiwblUbukbPu0f cis0FQERQuM3UTdfUPmFs/Zx4NRYVrc8G6dwpn4SZysJtAqikdv1AgKdJXJqV7A2Fb1Y EyAiMR4sboMk4qYPLLRwn12/2W/PGUmVpJCpURMdOP6hp/L69XxYVkmjgM3QOrkfqa4k LD9ukLE7DFjmItcOsq8VYlHuK25prGRtMfM9EqrFASENEqwLmJReG/oQaJP3l5vVCYnM jtxEorMDg9CehFVPOEPnIoW8q8w9ikHBIJdwFm8tz5ulEvPmrDu2JrJcfuTXp5ghn7DO dXqw== X-Gm-Message-State: AOAM533ViH+8OIU8xjYw7XolkEEgnuoDP7rKkB1K4pCpMX4/O2TNDhbr kBK+WtcFYWeo7jIYNYScOWw7qQ== X-Google-Smtp-Source: ABdhPJyWOLlejkuV1LxyOTDubGW4GYupRpiblC2YnTbW5tOLLBk4/LIWiql3rTsLEN4rr1TKbMQkzQ== X-Received: by 2002:adf:e9cd:: with SMTP id l13mr17481271wrn.340.1596474735964; Mon, 03 Aug 2020 10:12:15 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.69.222]) by smtp.googlemail.com with ESMTPSA id m20sm2074717wmc.1.2020.08.03.10.12.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2020 10:12:15 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix RPi4 GICC PMU PPI To: devel@edk2.groups.io, Samer El-Haj-Mahmoud Cc: Leif Lindholm , Andrei Warkentin , Ard Biesheuvel References: <20200728210028.6024-1-Samer.El-Haj-Mahmoud@arm.com> <1626C72E5FC5B4C0.4967@groups.io> From: "Pete Batard" Message-ID: Date: Mon, 3 Aug 2020 18:12:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1626C72E5FC5B4C0.4967@groups.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Adding a tested-by, since these are values that could potentially trip the custom handling that Windows seems to have of MADT, and I hadn't tested that yet. Testing shows that Windows is happy with these new values, so with this: On 2020.07.31 08:55, Pete Batard via groups.io wrote: > On 2020.07.28 22:00, Samer El-Haj-Mahmoud wrote: >> Arm SBSA specification section ver 6.0, 4.1.5 defines specific PPI >> values for certain standard interrupt IDs. The value for >> "Performance Monitors Interrupt" needs to be 23. >> >> REF: https://developer.arm.com/documentation/den0029/latest >> >> This partially fixes SBSA test #11 ("Incorrect PPI value") reported in >> https://github.com/pftf/RPi4/issues/74 >> >> Cc: Leif Lindholm >> Cc: Pete Batard >> Cc: Andrei Warkentin >> Cc: Ard Biesheuvel >> Signed-off-by: Samer El-Haj-Mahmoud >> --- >>   Platform/RaspberryPi/RPi4/RPi4.dsc | 8 ++++---- >>   1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc >> b/Platform/RaspberryPi/RPi4/RPi4.dsc >> index c481c3534263..00683afe96b9 100644 >> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc >> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc >> @@ -433,10 +433,10 @@ [PcdsFixedAtBuild.common] >>     gRaspberryPiTokenSpaceGuid.PcdGicInterruptInterfaceHBase|0xFF844000 >>     gRaspberryPiTokenSpaceGuid.PcdGicInterruptInterfaceVBase|0xFF846000 >>     gRaspberryPiTokenSpaceGuid.PcdGicGsivId|0x19 >> -  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq0|0x30 >> -  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq1|0x31 >> -  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq2|0x32 >> -  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq3|0x33 >> +  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq0|23 >> +  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq1|23 >> +  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq2|23 >> +  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq3|23 >>     # >>     # Fixed CPU settings. >> > > Reviewed-by: Pete Batard Tested-by: Pete Batard > > >