From: Laszlo Ersek <lersek@redhat.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Paolo Bonzini <pbonzini@redhat.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH 0/2] MdeModulePkg/AtaAtapiPassThru: Revert patch to disable PCI attributes
Date: Tue, 28 Nov 2017 13:55:39 +0100 [thread overview]
Message-ID: <a129b195-2265-58c2-735e-0e402315bc53@redhat.com> (raw)
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BAD41A6@SHSMSX104.ccr.corp.intel.com>
On 11/28/17 08:39, Ni, Ruiyu wrote:
> Laszlo,
> The Windows resume issue is urgent to fix.
> I'd like to check-in the patches first.
> If I didn't know the change may cause combability issue, I'd be very fine
> to change it to AhciReset() then submit the patch, then after got a R-b,
> I'd be very happy to check in that patch.
> But since now I know there might be some combability issue, I don't
> want to switch to AhciReset() solution without thoroughly testing.
> And frankly I don't know what a thoroughly testing would be like.
> There are many OSes and many PCI storage cards! ☹
Fair enough; thank you for the explanation.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Laszlo
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Monday, November 27, 2017 10:10 PM
>> To: Ni, Ruiyu <ruiyu.ni@intel.com>
>> Cc: edk2-devel@lists.01.org; Paolo Bonzini <pbonzini@redhat.com>; Yao,
>> Jiewen <jiewen.yao@intel.com>; Zeng, Star <star.zeng@intel.com>
>> Subject: Re: [edk2] [PATCH 0/2] MdeModulePkg/AtaAtapiPassThru: Revert
>> patch to disable PCI attributes
>>
>> Hello Ray,
>>
>> On 11/27/17 02:19, Ruiyu Ni wrote:
>>> The patches caused Windows 10 S4 resume failure.
>>> Considering the similar changes are reverted from PciBus driver,
>>> revert the patches from AtaAtapiPassThru as well.
>>>
>>> Ruiyu Ni (2):
>>> MdeModulePkg/AtaAtapiPassThru: Revert patch to disable Bus Master
>>> MdeModulePkg/AtaAtapiPassThru: Revert patch to disable PCI
>>> attributes
>>>
>>> .../Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c | 58 +--------------------
>> -
>>> .../Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h | 5 --
>>> 2 files changed, 1 insertion(+), 62 deletions(-)
>>>
>>
>> it looks like these patches have not been committed yet, which is a good
>> thing, because apparently there's a better solution than a full revert.
>> Namely, in the other sub-thread at
>> <http://mid.mail-archive.com/0236afa2-e365-af7a-9374-
>> 7fd1ad742c36@redhat.com>
>> (alternative link:
>> <https://lists.01.org/pipermail/edk2-devel/2017-November/018046.html>),
>> Jiewen and Star seem to accept AhciReset() as a better way to abort pending
>> DMA.
>>
>> This means that we need not revert the EBS-handler altogether, only change
>> what it does. Could you give that a try please?
>>
>> (If the Windows regression is very urgent to fix, then I don't mind if the Bus
>> Master disabling is removed separately, before AhciReset() is added; but in
>> that case, a full revert looks unjustified, since the EBS handler will have to be
>> re-added for AhciReset() anyway.)
>>
>> Thanks,
>> Laszlo
prev parent reply other threads:[~2017-11-28 12:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 1:19 [PATCH 0/2] MdeModulePkg/AtaAtapiPassThru: Revert patch to disable PCI attributes Ruiyu Ni
2017-11-27 1:19 ` [PATCH 1/2] MdeModulePkg/AtaAtapiPassThru: Revert patch to disable Bus Master Ruiyu Ni
2017-11-27 1:19 ` [PATCH 2/2] MdeModulePkg/AtaAtapiPassThru: Revert patch to disable PCI attributes Ruiyu Ni
2017-11-27 4:20 ` [PATCH 0/2] " Yao, Jiewen
2017-11-27 5:18 ` Zeng, Star
2017-11-27 14:09 ` Laszlo Ersek
2017-11-28 7:39 ` Ni, Ruiyu
2017-11-28 12:55 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a129b195-2265-58c2-735e-0e402315bc53@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox