Re: [edk2-devel] [Patch ] Static IP based HTTP Support

["Laszlo Ersek" <lersek@redhat.com>]

Hi,

On 08/13/20 17:59, Sivaraman Nainar wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2888
> 
> *** NetworkPkg\HttpBootDxe\HttpBootClient.c             2020-05-07 22:54:46.000000000 +05-30
> --- NetworkPkg\HttpBootDxe\HttpBootClient.c 2020-08-09 21:03:01.000000000 +05-30
> ***************
> *** 1,6 ****
> --- 1,13 ----
> + //***********************************************************************
> + //*                                                                     *
> + //*   Copyright (c) 1985-2020, American Megatrends International LLC.   *
> + //*                                                                     *
> + //*      All rights reserved. Subject to AMI licensing agreement.       *
> + //*                                                                     *
> + //***********************************************************************
>   /** @file
>     Implementation of the boot file download function.
> 
>   Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.<BR>
>   (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>   SPDX-License-Identifier: BSD-2-Clause-Patent

this patch does not have a proper commit message, a proper Signed-off-by
line, a proper subject line, and a proper diff format (it's not
expressed as a unified diff).

Please consult the following references:

- official:

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

- unofficial:

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers

I'd also think that the huge legal banner added at the top of the file
is out of place. I think you can add a (C) notice (with the year 2020)
near the existing copyright notices. However, the line

"All rights reserved. Subject to AMI licensing agreement."

is wrong; it conflicts with

  SPDX-License-Identifier: BSD-2-Clause-Patent

Thanks,
Laszlo